From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C5C1C433E0 for ; Wed, 1 Jul 2020 09:30:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C6D820722 for ; Wed, 1 Jul 2020 09:30:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Wp8u7fvv"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xS0+pcVk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C6D820722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2uIO3rPZhoZGzEIIXC9Dc1wlVjS4ElSaFlT5Ir/uv4Y=; b=Wp8u7fvvO1AZChTy8iCHBVful uBr8qV16guvpTfcpD3S4zu8wsPby6iFjbbpwuiknqb3VEHtN3GQi7jlQbB93/3zUntptgwJqa3592 HoaB1wzkTamXk17bdmDA4XSn7FdzeZAyM+bCcAHClFJqJZd7Nvf3eLfcqhgaUWykLzNRZ0D6bgdeK JZSw1O0+nkU0JvYzLIfwURSuWhhHh0SOFAwsUj9StirCUvMCF0XpIKAVDpnFG0qxZkL93q7lzDKVy TqyKKaXhe0mdi33CutsmCq8MhkjssI/+29vW3B4/z7L0Ow1B7E7MmlasQ1sB+Lc+5WgVsfHBKk/s5 zBvsk1rpA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqZ3U-0005d6-Da; Wed, 01 Jul 2020 09:29:24 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqYpv-00052e-3k for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 09:15:25 +0000 Received: by mail-wm1-x344.google.com with SMTP id f139so22421098wmf.5 for ; Wed, 01 Jul 2020 02:15:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=AnYLIkeHE6sj58+nv0/Vk5hg57FNjdW3Ac6WAVrff6s=; b=xS0+pcVkWqEMdrN3G6PRZZ72teAo9M8JSk2x57oODJObiFNfviodK5FYKFimXG5Gfz vV3O2WkFiGUMZ40b7RlPP1wskQ1M//TbbPzaKSpKlroanc9aIPdlAZPRKQloznTkjSlX /U7M2wq99kVsVQTywWCUpk9dliR8PGHSgcoU+tp3JF5SK1L6U/OcIhPYXOv1Ejm+4oDU B7Qjup19Sjr9DP+30D8R+6nNJuS8fY0T2Tv5UygsEz7nR+qsH7YzKLbtv0azCGkgygh2 O0YsS2HHs4iOrs2K28Mj9gjWQ5dD0pko8MsL5QP1qSHBoKEWPdhJDWwHqs5qPs8S840z idHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AnYLIkeHE6sj58+nv0/Vk5hg57FNjdW3Ac6WAVrff6s=; b=f1UeEu4MNjnG8Ls+YFKLmqTzjv9K5KNm7Zg8I5Ww8VUIZcPdBr+GE2y4VCaC9MvIUj kSyGGMlMsDUZx1sVHm7TeoOwa25gZb+mGNndckBMreh71t6QsxU5ee93C5dQIeObEaSK 1DZt6mSyrqlZzTONrCjfU/MF1FMVgBq9T4ubvdf9tUrRDAgePxjhmTfRvfq25M6vnOPQ IN5DPFahf3kjkgm0TGI4ccmWMWTElkpRSCErYaaRNrLlf0p1Mh3uwn9zPuhGG6xu9k1+ JzrsqRsW7vMWfnwPfgl6P7tFKgmqDzmy29Oq7qbl0nCdMOTWc0osd3PEZl5Yy2taK0TH dx4w== X-Gm-Message-State: AOAM530WuXUjzAzhKEzWc67JZ5o/XnLBZAONQ6RsHcXLJnXAPfzj4Yr5 ooW0nSPoZhA62nzfTQrtpvGd85YyEDY= X-Google-Smtp-Source: ABdhPJyeOgaXiHTz+gCNHlzMD8MWNNPfQrblF7m7rJMPcUQ3GQpi7aApPikTlIkbvswu85ysGKIAcg== X-Received: by 2002:a7b:c8c2:: with SMTP id f2mr24483326wml.57.1593594920333; Wed, 01 Jul 2020 02:15:20 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id f13sm6174611wmb.33.2020.07.01.02.15.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 02:15:19 -0700 (PDT) Date: Wed, 1 Jul 2020 10:15:18 +0100 From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Orson Zhai , Baolin Wang , Chunyan Zhang Subject: [PATCH] mfd: sprd-sc27xx-spi: Fix-up bogus IRQ register offset and mask setting Message-ID: <20200701091518.GW1179328@dell> References: <20200629123215.1014747-1-lee.jones@linaro.org> <20200629123215.1014747-5-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200629123215.1014747-5-lee.jones@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_051523_524792_6FA0AB21 X-CRM114-Status: GOOD ( 11.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: johan@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org 'i / pdata->num_irqs' always equates to 0 and 'BIT(i % pdata->num_irqs)' always ends up being BIT(i) here, so make that clearer in the code. If the code base needs to support more than 32 IRQs in the future, this will have to be reworked, but lets just keep it simple for as long as we can. This fixes the following W=1 warning: drivers/mfd/sprd-sc27xx-spi.c:255 sprd_pmic_probe() debug: sval_binop_unsigned: divide by zero Cc: Orson Zhai Cc: Chunyan Zhang Cc: Johan Hovold Suggested-by: Baolin Wang Signed-off-by: Lee Jones diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c index c305e941e435c..4a1a61e1a86ea 100644 --- a/drivers/mfd/sprd-sc27xx-spi.c +++ b/drivers/mfd/sprd-sc27xx-spi.c @@ -251,10 +251,8 @@ static int sprd_pmic_probe(struct spi_device *spi) return -ENOMEM; ddata->irq_chip.irqs = ddata->irqs; - for (i = 0; i < pdata->num_irqs; i++) { - ddata->irqs[i].reg_offset = i / pdata->num_irqs; - ddata->irqs[i].mask = BIT(i % pdata->num_irqs); - } + for (i = 0; i < pdata->num_irqs; i++) + ddata->irqs[i].mask = BIT(i); ret = devm_regmap_add_irq_chip(&spi->dev, ddata->regmap, ddata->irq, IRQF_ONESHOT | IRQF_NO_SUSPEND, 0, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel