From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 960B7C433E0 for ; Wed, 1 Jul 2020 10:17:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 65CB3206B6 for ; Wed, 1 Jul 2020 10:17:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0wIbGh97"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="x9F1GjIc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 65CB3206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lVQLdIABgq/d/TamadgsLn9+r4ScOGYgZUI0ZeaR46k=; b=0wIbGh971whAIXT5XfhXJQ3pi aVxQ55IOIcTw3JBP5oO2v3MQs3XCZyixTBkf5flGzjy8fzq7IRKjixsHIaTiFAjd+qtP/7hB+9lm3 b9zPKEh/2/RRiBuXwajqTZqPinZ0RhmkP62yYZQ2ZT84MfD3RxMkn02vmZSkCW6bBduIQIFXB3jt9 NwzX9OAfY9P1i7icYcEQCZH73mTK26nwGv076pskFhk6ObD9Af4j+DatL5KCfAeS1YdH25iMH8ZWX uhQfo5GIGqKqBLhuDbgIipFARb6yM0PH0GDtecaUwcdsRUTZNZaDHSu8l3mAqLK1P0mNTKygE6bVf 1gkEHRYgA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqZmn-000819-R0; Wed, 01 Jul 2020 10:16:13 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqZml-0007zI-ST for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 10:16:12 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2AECE206B6; Wed, 1 Jul 2020 10:16:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593598570; bh=zaXs2CbDvdszPriMRibslBZHNsXjv65VQsj0rfFmR+o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=x9F1GjIcBBX3hdCVHlt6wJhlZPB1N66WRkkqZTlXlWM63OjP7z5kH6BN/nqF+TGdK 0l2eDCnBkdVi58H2QL0fQ2HW5wh+cQZXqBCv4zjoK3BLLwxqaxwskMx48hdn7mC2PX hIbO1vcmH/rJuuU6I20zoA0/9Lb9QB1M0qPY6kII= Date: Wed, 1 Jul 2020 11:16:04 +0100 From: Will Deacon To: Arnd Bergmann Subject: Re: [PATCH 02/18] compiler.h: Split {READ,WRITE}_ONCE definitions out into rwonce.h Message-ID: <20200701101603.GB14959@willie-the-truck> References: <20200630173734.14057-1-will@kernel.org> <20200630173734.14057-3-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_061612_003552_8C1E7ADF X-CRM114-Status: GOOD ( 17.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Marco Elver , Kees Cook , "Paul E. McKenney" , "Michael S. Tsirkin" , Peter Zijlstra , Catalin Marinas , Jason Wang , Nick Desaulniers , "linux-kernel@vger.kernel.org" , Josh Triplett , Ivan Kokshaysky , Sami Tolvanen , alpha , Alan Stern , Matt Turner , virtualization@lists.linux-foundation.org, Android Kernel Team , Boqun Feng , Linux ARM , Richard Henderson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Arnd, On Tue, Jun 30, 2020 at 09:11:32PM +0200, Arnd Bergmann wrote: > On Tue, Jun 30, 2020 at 7:37 PM Will Deacon wrote: > > > > In preparation for allowing architectures to define their own > > implementation of the READ_ONCE() macro, move the generic > > {READ,WRITE}_ONCE() definitions out of the unwieldy 'linux/compiler.h' > > file and into a new 'rwonce.h' header under 'asm-generic'. > > > > Acked-by: Paul E. McKenney > > Signed-off-by: Will Deacon > > --- > > include/asm-generic/Kbuild | 1 + > > include/asm-generic/rwonce.h | 91 ++++++++++++++++++++++++++++++++++++ > > include/linux/compiler.h | 83 +------------------------------- > > Very nice, this has the added benefit of allowing us to stop including > asm/barrier.h once linux/compiler.h gets changed to not include > asm/rwonce.h. Yeah, with this series linux/compiler.h _does_ include asm/rwonce.h because otherwise there are many callers to fix up, but that could be addressed subsequently, I suppose. > The asm/barrier.h header has a circular dependency, pulling in > linux/compiler.h itself. Hmm. Once smp_read_barrier_depends() disappears, I could actually remove the include of from asm-generic/rwonce.h. It would have to remain for arch/alpha/, however, since we need the barrier definitions to implement READ_ONCE(). I can probably also replace the include of in asm-generic/barrier.h with too (so it's still circular, but at least a lot simpler). I'll have a play... Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel