From: "Guido Günther" <guido.gunther@puri.sm>
To: Ondrej Jirman <megous@megous.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
Purism Kernel Team <kernel@puri.sm>,
Samuel Holland <samuel@sholland.org>,
David Airlie <airlied@linux.ie>,
Linus Walleij <linus.walleij@linaro.org>,
Bhushan Shah <bshah@kde.org>, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, Martijn Braam <martijn@brixit.nl>,
linux-sunxi@googlegroups.com,
Thierry Reding <thierry.reding@gmail.com>,
Maxime Ripard <mripard@kernel.org>,
Daniel Vetter <daniel@ffwll.ch>, Sam Ravnborg <sam@ravnborg.org>,
Luca Weiss <luca@z3ntu.xyz>,
linux-arm-kernel@lists.infradead.org,
Icenowy Zheng <icenowy@aosc.io>
Subject: Re: [PATCH v6 11/13] drm/panel: st7703: Assert reset prior to powering down the regulators
Date: Wed, 1 Jul 2020 18:04:44 +0200 [thread overview]
Message-ID: <20200701160444.GJ174356@bogon.m.sigxcpu.org> (raw)
In-Reply-To: <20200701103126.1512615-12-megous@megous.com>
Hi,
On Wed, Jul 01, 2020 at 12:31:24PM +0200, Ondrej Jirman wrote:
> The reset pin is inverted, so if we don't assert reset, the actual gpio
> will be high and may keep driving the IO port of the panel.
Reviewed-by: Guido Günther <agx@sigxcpu.org>
>
> Signed-off-by: Ondrej Jirman <megous@megous.com>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/gpu/drm/panel/panel-sitronix-st7703.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
> index 0c4167994d01..e303b7b1a215 100644
> --- a/drivers/gpu/drm/panel/panel-sitronix-st7703.c
> +++ b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
> @@ -417,6 +417,7 @@ static int st7703_unprepare(struct drm_panel *panel)
> if (!ctx->prepared)
> return 0;
>
> + gpiod_set_value_cansleep(ctx->reset_gpio, 1);
> regulator_disable(ctx->iovcc);
> regulator_disable(ctx->vcc);
> ctx->prepared = false;
> --
> 2.27.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-01 16:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 10:31 [PATCH v6 00/13] Add support for PinePhone LCD panel Ondrej Jirman
2020-07-01 10:31 ` [PATCH v6 01/13] dt-bindings: vendor-prefixes: Add Xingbangda Ondrej Jirman
2020-07-01 10:31 ` [PATCH v6 02/13] dt-bindings: panel: Convert rocktech, jh057n00900 to yaml Ondrej Jirman
2020-07-01 15:58 ` [PATCH v6 02/13] dt-bindings: panel: Convert rocktech,jh057n00900 " Guido Günther
2020-07-01 16:07 ` Sam Ravnborg
2020-07-01 16:32 ` Ondřej Jirman
2020-07-01 10:31 ` [PATCH v6 03/13] dt-bindings: panel: Add compatible for Xingbangda XBD599 panel Ondrej Jirman
2020-07-01 10:31 ` [PATCH v6 04/13] drm/panel: rocktech-jh057n00900: Rename the driver to st7703 Ondrej Jirman
2020-07-01 16:00 ` Guido Günther
2020-07-01 10:31 ` [PATCH v6 05/13] drm/panel: st7703: Rename functions from jh057n prefix " Ondrej Jirman
2020-07-01 16:01 ` Guido Günther
2020-07-01 10:31 ` [PATCH v6 06/13] drm/panel: st7703: Prepare for supporting multiple panels Ondrej Jirman
2020-07-01 16:02 ` Guido Günther
2020-07-01 10:31 ` [PATCH v6 07/13] drm/panel: st7703: Move code specific to jh057n closer together Ondrej Jirman
2020-07-01 16:02 ` Guido Günther
2020-07-01 10:31 ` [PATCH v6 08/13] drm/panel: st7703: Move generic part of init sequence to enable callback Ondrej Jirman
2020-07-01 16:02 ` Guido Günther
2020-07-01 10:31 ` [PATCH v6 09/13] drm/panel: st7703: Add support for Xingbangda XBD599 Ondrej Jirman
2020-07-01 16:03 ` Guido Günther
2020-07-01 10:31 ` [PATCH v6 10/13] drm/panel: st7703: Enter sleep after display off Ondrej Jirman
2020-07-01 16:04 ` Guido Günther
2020-07-01 10:31 ` [PATCH v6 11/13] drm/panel: st7703: Assert reset prior to powering down the regulators Ondrej Jirman
2020-07-01 16:04 ` Guido Günther [this message]
2020-07-01 10:31 ` [PATCH v6 12/13] arm64: dts: sun50i-a64-pinephone: Enable LCD support on PinePhone Ondrej Jirman
2020-07-01 10:31 ` [PATCH v6 13/13] arm64: dts: sun50i-a64-pinephone: Add touchscreen support Ondrej Jirman
2020-07-01 12:01 ` Icenowy Zheng
2020-07-01 18:57 ` Ondřej Jirman
2020-07-01 15:25 ` [PATCH v6 00/13] Add support for PinePhone LCD panel Sam Ravnborg
2020-07-01 16:30 ` Ondřej Jirman
2020-07-01 16:37 ` Linus Walleij
2020-07-01 15:54 ` Guido Günther
2020-07-01 16:42 ` Ondřej Jirman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701160444.GJ174356@bogon.m.sigxcpu.org \
--to=guido.gunther@puri.sm \
--cc=airlied@linux.ie \
--cc=bshah@kde.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=icenowy@aosc.io \
--cc=kernel@puri.sm \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=luca@z3ntu.xyz \
--cc=martijn@brixit.nl \
--cc=megous@megous.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=samuel@sholland.org \
--cc=thierry.reding@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).