From: Dan Carpenter <dan.carpenter@oracle.com>
To: Cristian Marussi <cristian.marussi@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, sudeep.holla@arm.com
Subject: Re: [bug report] firmware: arm_scmi: Add notification callbacks-registration
Date: Thu, 2 Jul 2020 14:17:56 +0300 [thread overview]
Message-ID: <20200702111756.GQ2571@kadam> (raw)
In-Reply-To: <20200701122639.GA31379@e119603-lin.cambridge.arm.com>
On Wed, Jul 01, 2020 at 01:29:24PM +0100, Cristian Marussi wrote:
> > 1273 if (!scmi_event_handler_enable_events(hndl)) {
> >
> > I really don't like that half these functions follow normal kernel error
> > style and half return true/false on failure. Normally we would want
> > boolean functions to be clear from the name like access_ok() which
> > clearly returns true/false. But I didn't see that it causes any bugs
> > yet.
>
> Ok I'll convert all the functions to classical 0-Success style dumping
> the booleans. I cannot see in fact any suitable func_ok() style function.
You are a hero. Thanks!
regards,
dan carpenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-07-02 11:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 17:57 [bug report] firmware: arm_scmi: Add notification callbacks-registration Dan Carpenter
2020-07-01 12:29 ` Cristian Marussi
2020-07-02 11:17 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702111756.GQ2571@kadam \
--to=dan.carpenter@oracle.com \
--cc=cristian.marussi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).