From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1BE3C433DF for ; Thu, 2 Jul 2020 11:20:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70D482070C for ; Thu, 2 Jul 2020 11:20:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aEBqGw71"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="QOXazhXF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70D482070C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZeuCIgXKA7ccIDCTwbOjtbYdSsD7a5Fc9TAkHTBBjR8=; b=aEBqGw71t0en1NOOBmMvSQv9l XqAiVdlFVqKHFxfoFZHQHXF1O1dK4SI30eGzWeV3HUQ3apd3YyIShyVmNpdyyXt7YUdF1mCA/SQjC SkfxVq8GaHitimskw30MGi5E9UY9s7H9bsI4e+BMzPI1+cIclf5VExakaZzb0oZJnVxKkhNpH6FoT RUK6jtRmBHGZYrC9ZU36wWK8S7ozlndMVMRDZmBo9Min2mI7VlMp9R8gO0p9uUGeeRgX+9ogM7zuh SgQPymOF8C3lVd3IpAQg2aU/7CA11HvJilgGgLdgNXbKrF/tMM1rmI/2OBDMw0Wr4LQQQHPnbGT5Z 4wba3wPiQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqxEs-00015K-9W; Thu, 02 Jul 2020 11:18:46 +0000 Received: from userp2120.oracle.com ([156.151.31.85]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqxEp-00013b-IN for linux-arm-kernel@lists.infradead.org; Thu, 02 Jul 2020 11:18:44 +0000 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 062BDUth127387; Thu, 2 Jul 2020 11:18:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=ldPh7TzCpFK23ikhoefqbr5hcQqAjeuLxqKK5yqxBBo=; b=QOXazhXFUGphw/SQEXBAsN4lBs8273tzAkTLi2G8mXEo8wIWFXZnIdwkSzo5tjmIN92b BEDBwyYYfCEdCxTBNEqFs3e/IuUyQaAxj7mdVAij701YoTqsr3Fw9vsnIyDYopORRB3F nFcWBQ5Z22NcZtlbJdPkWAsk0UhepdIJdvY7MTFIzw5I3kilmV/wdtrSyK5o4cs7W/t6 5vcZbFfUEFYTk4Xc/iJwhxXN6Vpmf2TUP7R8JYWvUW3hK4Eb34OjkYlfNm5jBJPnYkoi S0iihx7V/MXEhlczUZfkIiK9knDh3kbpb3dj8ojp+n+Kf1/Zwd0RDGaAbR2L+ApiyIOV Iw== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 31wxrnfrkt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 02 Jul 2020 11:18:37 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 062BCoZK196278; Thu, 2 Jul 2020 11:18:36 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 31xg18ypwd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 02 Jul 2020 11:18:36 +0000 Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 062BIYmS030335; Thu, 2 Jul 2020 11:18:35 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 02 Jul 2020 11:18:01 +0000 Date: Thu, 2 Jul 2020 14:17:56 +0300 From: Dan Carpenter To: Cristian Marussi Subject: Re: [bug report] firmware: arm_scmi: Add notification callbacks-registration Message-ID: <20200702111756.GQ2571@kadam> References: <20200630175718.GB34614@mwanda> <20200701122639.GA31379@e119603-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200701122639.GA31379@e119603-lin.cambridge.arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9669 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 mlxscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2007020083 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9669 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 priorityscore=1501 impostorscore=0 bulkscore=0 clxscore=1015 malwarescore=0 phishscore=0 adultscore=0 cotscore=-2147483648 lowpriorityscore=0 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2007020083 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200702_071843_798904_EF7AED11 X-CRM114-Status: GOOD ( 19.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, sudeep.holla@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 01, 2020 at 01:29:24PM +0100, Cristian Marussi wrote: > > 1273 if (!scmi_event_handler_enable_events(hndl)) { > > > > I really don't like that half these functions follow normal kernel error > > style and half return true/false on failure. Normally we would want > > boolean functions to be clear from the name like access_ok() which > > clearly returns true/false. But I didn't see that it causes any bugs > > yet. > > Ok I'll convert all the functions to classical 0-Success style dumping > the booleans. I cannot see in fact any suitable func_ok() style function. You are a hero. Thanks! regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel