From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55A1AC433E0 for ; Fri, 3 Jul 2020 13:14:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 228F2208E4 for ; Fri, 3 Jul 2020 13:14:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="abPF4YlR"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ItGZjDRI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 228F2208E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Vk5Aufc8KuFNhwMYbEvZ3EK395BDQGZxvksYDdVwwk0=; b=abPF4YlRXEtt57d/1OgYlTiRW 6sXJCc8ecKVSQUBTiBqL+ezMnz7ewJnxfla8T0YFbxqoSphIVOHnCWf5qk8CCbVexdvTihCXXmzVK P8cOoS6WXHBySW0EJDA6OoBo9THnCc3jF7QXcxWsHZuQC0LMQkeLoSvsq5V3i7ClGJcoEFYds7o6U G/v78HvmIthdBGHRT7FeOT9HYHlvPgG/oIgWeH5mTePNjrihbHAuRTs3Mxac8F+jhvcF0IAmEXBdn DDmvTko24jKschKXUWo1ObDXhPpTcYcch8G+zliHwpCeTXtY82u13d7lv6HSJHk5JY8IMw+k/Xa/S Stl60TlbQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrLVZ-0000iq-D4; Fri, 03 Jul 2020 13:13:37 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrLVW-0000i1-LH for linux-arm-kernel@merlin.infradead.org; Fri, 03 Jul 2020 13:13:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=uqsQimSA3ZVIJmzJ+g3hxvE+rQFiKwkEojhvCeRdahw=; b=ItGZjDRIImf27YsAGtOG8yy/um tHTSFrVgQyOISf1u9ovbSydWGKTsYFOu1QdZqaIrPrVC+BQULRRFgfurUr+UHbhbVAjFYXc0yCGNH NRV6Ty0xvDowLbPzhWsEfUHzZqw0FT874nx/34bvhnQsXXmIDYEOYRNqxPNQYH8rAHKE2/8AwTRk8 wHLizFfF5+qhuvmcj3dz1f5NSP8/5ZJsGkhy1O/RcYnmb5zr+RExexvUuyCwYq8Luedw4dSOP2EUv Sin4pSha9/RbjtlWc8OZlJovtZ17d+oq5poGsjxjQDDenUnzl1rkiSj26lYRo48qjQPCyZuX1TsWH IDaagGpA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrLVT-0003j1-Sa; Fri, 03 Jul 2020 13:13:32 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 71D12301124; Fri, 3 Jul 2020 15:13:30 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 30A0521476E91; Fri, 3 Jul 2020 15:13:30 +0200 (CEST) Date: Fri, 3 Jul 2020 15:13:30 +0200 From: Peter Zijlstra To: "Paul E. McKenney" Subject: Re: [PATCH 00/22] add support for Clang LTO Message-ID: <20200703131330.GX4800@hirez.programming.kicks-ass.net> References: <20200630191931.GA884155@elver.google.com> <20200630201243.GD4817@hirez.programming.kicks-ass.net> <20200630203016.GI9247@paulmck-ThinkPad-P72> <20200701114027.GO4800@hirez.programming.kicks-ass.net> <20200701140654.GL9247@paulmck-ThinkPad-P72> <20200701150512.GH4817@hirez.programming.kicks-ass.net> <20200701160338.GN9247@paulmck-ThinkPad-P72> <20200702082040.GB4781@hirez.programming.kicks-ass.net> <20200702175948.GV9247@paulmck-ThinkPad-P72> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200702175948.GV9247@paulmck-ThinkPad-P72> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , Marco Elver , "maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , Kees Cook , Kernel Hardening , Greg Kroah-Hartman , Masahiro Yamada , Linux Kbuild mailing list , Nick Desaulniers , LKML , clang-built-linux , Sami Tolvanen , linux-pci@vger.kernel.org, Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 02, 2020 at 10:59:48AM -0700, Paul E. McKenney wrote: > On Thu, Jul 02, 2020 at 10:20:40AM +0200, Peter Zijlstra wrote: > > On Wed, Jul 01, 2020 at 09:03:38AM -0700, Paul E. McKenney wrote: > > > > > But it looks like we are going to have to tell the compiler. > > > > What does the current proposal look like? I can certainly annotate the > > seqcount latch users, but who knows what other code is out there.... > > For pointers, yes, within the Linux kernel it is hopeless, thus the > thought of a -fall-dependent-ptr or some such that makes the compiler > pretend that each and every pointer is marked with the _Dependent_ptr > qualifier. > > New non-Linux-kernel code might want to use his qualifier explicitly, > perhaps something like the following: > > _Dependent_ptr struct foo *p; // Or maybe after the "*"? After, as you've written it, it's a pointer to a '_Dependent struct foo'. > > rcu_read_lock(); > p = rcu_dereference(gp); > // And so on... > > If a function is to take a dependent pointer as a function argument, > then the corresponding parameter need the _Dependent_ptr marking. > Ditto for return values. > > The proposal did not cover integers due to concerns about the number of > optimization passes that would need to be reviewed to make that work. > Nevertheless, using a marked integer would be safer than using an unmarked > one, and if the review can be carried out, why not? Maybe something > like this: > > _Dependent_ptr int idx; > > rcu_read_lock(); > idx = READ_ONCE(gidx); > d = rcuarray[idx]; > rcu_read_unlock(); > do_something_with(d); > > So use of this qualifier is quite reasonable. The above usage might warrant a rename of the qualifier though, since clearly there isn't anything ptr around. > The prototype for GCC is here: https://github.com/AKG001/gcc/ Thanks! Those test cases are somewhat over qualified though: static volatile _Atomic (TYPE) * _Dependent_ptr a; \ Also, if C goes and specifies load dependencies, in any form, is then not the corrolary that they need to specify control dependencies? How else can they exclude the transformation. And of course, once we're there, can we get explicit support for control dependencies too? :-) :-) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel