From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96297C433DF for ; Sat, 4 Jul 2020 21:07:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63F3F2145D for ; Sat, 4 Jul 2020 21:07:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S5q01PYX"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="GVBp98WO"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gmx.net header.i=@gmx.net header.b="IKr+7zFW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63F3F2145D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gmx.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FQocCXg+7yvnbJTRxh37rnd2natPKb6xOQYTWWPR87I=; b=S5q01PYXz4w3CzYczMDcqH6MH HVBz4LiG02uOiwBpNm7icbHlAIumuduBGdjlVTBQjLUonTNa4qnIrc23SmVpvIRDbFfz+MtW62vY8 hcUPlj/kk9dIpLkpFj3xajWEeFCRUCHfvlsN4Io+bg2ct3JjxAIPEYSLDmqcDrDmoza2XNezh9qKQ Bj9sfbm9QkVZMs6v80zWk3QvBmxqnys+K+vgNq7wEXh/cEOqIuzejWNK3e3a5p2p5Lv4+y2DCNIUO x6mQmQP5Uz7jxUzPjmSbRpCydtZ1myVXKRN10KohjgIc4e7NJLnihrlXaRM7v5fyevZ0Uhj8tPCNF EpKgQHnYQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrpLS-0006gx-Mg; Sat, 04 Jul 2020 21:05:10 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrpLQ-0006gq-Lc for linux-arm-kernel@merlin.infradead.org; Sat, 04 Jul 2020 21:05:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OXuLhe54Dr8nuC1l2iScGztwjySWPlEhH4bXmzrhTQg=; b=GVBp98WOT6N5RwCfDADkN0X0ct Dv7sxxKqXYX2Wr7NbhCaZB3sMMnrkk/nkY7p8m4Ok4HN3kIzuAgjEWIMubXU0YX2EfIH50Pw6FAcj 9MslJHZVZBwSWIdwLiHkoq3UjnXgHTyKNShqKvFHDuyw22GOnVmBTAL6SOfv30caCgagAsNdK9530 pqnPeFvIDGldgRTRxzunTODgFONaK8HtrmqOKQ5QdMP0NT1ew3kHt83jt1xNxna8FTy7R8IOT8LKc jzNOJDPCSc4lPe9pUXVM4nJL+b7OI5TtERs9Eqf9rkwt1WuWBLDkHYwLLW7hGo2E0qMkBBU/9eYx4 KAOhqSCA==; Received: from mout.gmx.net ([212.227.15.18]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrpLM-0000JD-2O for linux-arm-kernel@lists.infradead.org; Sat, 04 Jul 2020 21:05:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1593896693; bh=2oIii+dEa/rMktNI0QfrGboAftGZ7VgeERC+pMMVvCE=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=IKr+7zFWhHjgbv6p0yDw/plsZ7mAXi3IYaiBsjetb2/d6ZgXEXzskaeL9RceP4fHS FJ+7Yf+1zI5XGHn3WV0nwVfHZQ8CDPqsO8VP1zecGOB3P9Kc2CqrvQ5F0ObwbVwbFh irOoiF54Ye213D+dgqPWiVj1tBddI6SOvf5uVXew= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from longitude ([5.146.195.26]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M8hV5-1jwW4Q2HFx-004mOY; Sat, 04 Jul 2020 22:58:11 +0200 Date: Sat, 4 Jul 2020 22:58:08 +0200 From: Jonathan =?utf-8?Q?Neusch=C3=A4fer?= To: Andreas Kemnade Subject: Re: [RFC PATCH 00/10] Netronix embedded controller driver for Kobo and Tolino ebook readers Message-ID: <20200704205808.GD2578@latitude> References: <20200620223915.1311485-1-j.neuschaefer@gmx.net> <20200630084051.66feadea@aktux> <20200630071523.GA2983@latitude> <20200630221447.3e03ae28@aktux> MIME-Version: 1.0 In-Reply-To: <20200630221447.3e03ae28@aktux> X-Provags-ID: V03:K1:55puWQ+2GGyp7xcFFLkgMg7nkitQvyCSK5CCeExXNQutjzBzOIO vOWLHCUn89dwzlDLbv07iW8fG/Rzs6Y6iEj6IFAtgcy/ImnrcMnMPhm5BVSsrqc8fOv5zgU JLB+V6JL3G03CFL+MN9xGbxb3NBHFJ9S8wudrcml8m642V0u7SCEaLsS0IKObqSwkePjNsy VYCWd9xclZmIdnQaLD0FQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:WReF7M0sgy4=:V5qS01AB/9exsfMZf08/25 RX1g/tu50B4UPeOwYvAkw2HfP827fYsjEkd67Yk7PbDvr80I/Yv2AC7MWBMNNocTp5rLyjA9P t1U8VkDX6K1drdwQrWRkHXRi2PvNF3NJlKejryvNAkOqYUGxAMGL6+a6TLsa52irgH5cAp2bN Y1+ADP/Fs9AAiFU4DSGajpA+ibxUQJlNcFMNjt4mRN42yeMMMx9vZT5/3iydn1mh0FwpWwJRo H/ZYjYj6VCBKE5Bh4Ob0Wpqws55jzpce89xjRDplRJ9TpCeti8ZNhPCIN+La8Jcz+FFgU1czI KEqyHdy9hTGT2OXMzaVd1QN9URwYDr8n/wYQOMsIrho72L2IdvPcCjgR5hSy4A1eWEArulgtM TCp37ncQWD0l2Uik4DOh0ZaQyi0h+oY88UAhWFEHP7UlFO39i34DuZksnYa2llQQVW2lzuYAJ LJB0ox7JehxtJiXEPJfGrh5kss6vJga7t8nK1AO18WAcEqLLMI8nmtFWRh1x7cSUOHnRc7/vp vkojAj4fjZ7d+E8a6ew5HSMeQT5aGwzShjpNNLedy9GtPJjele0hZ6LmOIkTTv8PHidHP12yj +BBbyksmdkxIoOXY41V7OKRn/CTdJUI0kJLehk5fgcKIlsnr+7PHsxviKU9EvOK9+kH3oOQhs PkD+KyGBuff60tARYL3YCkFUt2SafIgikxIXZX3ibIOrIP4OFL5uRSzJMMphpOqNvN48PJMef 0d745ACVATfyt/+od0eivGBNKoCSqjKzmOJhR2BE4PVEcstbi0BS1sf+81mE3jUjGmf08+GEu BrwOsxCO2r2Fb2J8xn69rq6I5czBJ2xixtNDDP0B2S44GZ4dssewthcwwAETc5jkF/ASiNU+o JhAO4KeUf837Z0ZPD8HqXEqOoSuYrwIn4ZLmT/I0kVloNtif8A9xpGS/joerhTWB6ExHxKFs1 Cdh2V3l2ihcU6Gb6+Zw7q42ct4DhqjXDhbKIAnSSXpeCxzbF9VnllQNXcuZA8oAkpCUNGuUTI Q/pz4cJXphzEdkTlFapxa2f3mdyPpmqjg4QrD0OewitWJDzlrSx53UWqvLYg4upUxFfGXLXUP fQHWo2a+5fIznHmud6CYCespFdxQxn1HOM1Xzpn53zXK+QrB7ighFUvB+1wWb8yHaqQCfnK9w 6+w+V+MhRgDhpfjCUsC8fGd7YNrD58rcRVwCxyEGkXNMfFZjBj9iD7R4MiKeFd32aTOyNJt1z iqKemqI/cu7Sy7Co/ X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200704_220504_528612_A544AE8C X-CRM114-Status: GOOD ( 21.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Heiko Stuebner , linux-pwm@vger.kernel.org, Linus Walleij , Thierry Reding , Fabio Estevam , linux-rtc@vger.kernel.org, Mauro Carvalho Chehab , Sam Ravnborg , NXP Linux Team , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , devicetree@vger.kernel.org, Stephan Gerhold , allen , Sascha Hauer , Jonathan =?utf-8?Q?Neusch=C3=A4fer?= , Lubomir Rintel , Rob Herring , Lee Jones , linux-arm-kernel@lists.infradead.org, Alessandro Zummo , linux-kernel@vger.kernel.org, Mark Brown , Pengutronix Kernel Team , Heiko Stuebner , Josua Mayer , Shawn Guo , "David S. Miller" Content-Type: multipart/mixed; boundary="===============0649721869289615568==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0649721869289615568== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="d01dLTUuW90fS44H" Content-Disposition: inline --d01dLTUuW90fS44H Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 30, 2020 at 10:14:47PM +0200, Andreas Kemnade wrote: > On Tue, 30 Jun 2020 09:15:23 +0200 > Jonathan Neusch=C3=A4fer wrote: >=20 > > On Tue, Jun 30, 2020 at 08:40:51AM +0200, Andreas Kemnade wrote: > > [...] > > > got a chance to test it on a Tolino Shine 2 HD. > > > It uses the RTC from the RC5T619 but backlight seems to go via MSP430 > > > EC. > > >=20 > > > I got this. > > >=20 > > > [ 1.453603] ntxec 0-0043: Netronix embedded controller version f11= 0 detected. > > > [ 10.723638] ntxec-rtc 21a0000.i2c:embedded-controller@43:rtc: regi= stered as rtc0 > > > [ 10.775276] ntxec-pwm: probe of 21a0000.i2c:embedded-controller@43= :pwm failed with error -5 =20 > >=20 > > Hmm, -EIO from the PWM driver. > >=20 > turing debugging on: (edited for compactness:) > [ 330.332971] i2c i2c-0: write slave address: addr=3D0x86 ACK received > [ 330.334420] i2c i2c-0: write byte: B0=3D0xA3 ACK received > [ 330.334790] i2c i2c-0: write byte: B1=3D0x0 No ACK > [ 330.352339] i2c i2c-0: write slave address: addr=3D0x86 ACK received > [ 330.362208] i2c i2c-0: write byte: B0=3D0xA1 ACK received > [ 330.362479] i2c i2c-0: write byte: B1=3D0xFF No ACK > [ 330.363112] i2c i2c-0: write slave address: addr=3D0x86 ACK received > [ 330.363362] i2c i2c-0: write byte: B0=3D0xA2 ACK received > [ 330.363608] i2c i2c-0: write byte: B1=3D0xFF No ACK Hmm, it doesn't ack the writes to 0xA3, 0xA1 and 0xA2, which should disable the PWM output and then disable the auto-off timer (according to the vendor kernel). And you said in your other mail that you can actually toggle the light with writes to 0xA3, so I suspect a bug in the EC firmware here (which may have gone unnoticed because the vendor kernel doesn't check if the i2c transfers succeed). :/ IMHO we should get this driver merged first, and perhaps add a quirk to deal with the missing ACKs later (unless a better solution is found). Jonathan --d01dLTUuW90fS44H Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAl8A7VcACgkQCDBEmo7z X9vtUBAApZaMG6edUQzNMvP9gVMXHNm96Rk1KQowxkW4xF6zOnil/x4PcUwgqfKV tA1xaZMavflayrHqj1wKuLPWnrJ1xdulK/PnULdnXalCJSVqGHjwyKf3/+onibzr o6rS+U9ToxbkTeTdV8DjcGz2qmNeJjpaExuZTlvXHQxH7a6SUwK23JVuiChwe2M3 ycD3RQp/jvAOEW4+e/y6iGat1skMV+dUglcitX6pYBoYu8u4FoSfZ3v/O6JTqqS3 IeLfBc0IMjGuYbEn+RRkHbnLTNidHt+ptsNl6Q+p7eaRGCeGXIaCeeFPbBp1LXMf C559niYKdWD+MQV6diLUHGMO5s4WrQiQ/qP4K+R9qQHKXyD84XYPXJX+QO+up2qb jDyutjtILNt5YFUKNbvimcWy/rlDa1sdVaFK8Dt9o0zdkT25FATE8SU0eRFwf396 vqwWeGF2b9mNRPzWzbpQYhEDvIR+OCuDfi085F0sYtBuPBY1vcy4mbVDjDGU0ulT T90dH/DU7C7DJwA7w6sxeb+8MZ5VGTHLsGZ+tB84pMaKJOlvTdRLD7J1+aUpqBmh BiSTJlIZeiiR04ip4vNYgsuHM79LlEapJuhJbYLMk3oBWtRAkrToyZEjWTDfp3Ik JzLHmXz38TYOeGG7A2vWQTIQb1eAw9Alh4Gu2OdzWW0fmR8NWCI= =5RFu -----END PGP SIGNATURE----- --d01dLTUuW90fS44H-- --===============0649721869289615568== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0649721869289615568==--