From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB7E9C433DF for ; Tue, 7 Jul 2020 11:56:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9584206BE for ; Tue, 7 Jul 2020 11:56:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nb+2uOJN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9584206BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2kdvl9xWTmSmKStsHJDRy4XKQjWexZ65zJmApAVv3Ac=; b=nb+2uOJNnXQn8+0Jlnto58R6u 7vnaHVmEThDO2OaH1hYMTxQY/tXnISRO1qsB6iIRrWVFABnbBgUR/WSxS/vFL0w5tmbYK7IZnBmMD XZ2K7hsyX5yT31eLD02IQG0j8r/rJIV8WlAdukf8KvyB/01LT+94dZuP1kgpSpuKfDSUt+H8QEQso pRR46jOcasK8k5U5TTxZ9k2liGJbvx7oRd6AE8dJjBk7SujD9kOLy1TCkL+uaG7kCmded8JZ08Ht0 4IJPw+anmlEb0Eweq+pV2Gj37aKZM+GYu55w2SfP8TtQ5hKyi4EOKddEhs9mKogYmRhFboZxzzzIP /216q7XFQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsmBg-0002lF-HF; Tue, 07 Jul 2020 11:55:00 +0000 Received: from mail-wr1-f65.google.com ([209.85.221.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsmBd-0002k1-MI for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 11:54:58 +0000 Received: by mail-wr1-f65.google.com with SMTP id z15so33550914wrl.8 for ; Tue, 07 Jul 2020 04:54:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PaBT0lPoXs7IdlUtnsvP+VH1DgYh/P2jJzUAU6vUbNU=; b=kkS4i33PLxYznpT0d+xV/CT0pWwvzv0jn71+trmkflWe7l4bCjjkUWD0KPNc6irl9d GW1F0uhh9NBcF2OtwQwt4OGQPr9ieRLBkPjTQE9BXnt62Fd7R2Du3CZqgIcHFPILV+66 BsSl0ngXjdjdBKp6UujX/jKWO0LL18pJv5c3mLMug2nInN+ApoQbdI3coQITDvG9v7CL 9pLrBm2fXzE5VeP90HipF/s6XSs4gokr3ifJhGHy6aOl+g/Z00t9+A89mQQF7QySOQEO DZUWxVM6jy4Kep2V0AtQXHjoc+xAiv+mUmsyopuz8yjfSu38yxejNH9LQujLKWR4aYIs gg3g== X-Gm-Message-State: AOAM531CcBU6k9NMMFpYyr0jZpfSwkHg2k3wYBJLQtul1HrJEGTqJG05 kkzN3WmzJULh/Y0SyC8QN6Y= X-Google-Smtp-Source: ABdhPJzjupRW40+WN4FUZja0iCFY7iXyazV3EiU8SfOuII8h8MCdacV4SFghHmY4jlkuWGms463J9Q== X-Received: by 2002:a5d:4dc2:: with SMTP id f2mr54625097wru.399.1594122896601; Tue, 07 Jul 2020 04:54:56 -0700 (PDT) Received: from localhost (ip-37-188-179-51.eurotel.cz. [37.188.179.51]) by smtp.gmail.com with ESMTPSA id m10sm791787wru.4.2020.07.07.04.54.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 04:54:55 -0700 (PDT) Date: Tue, 7 Jul 2020 13:54:54 +0200 From: Michal Hocko To: Jia He Subject: Re: [PATCH v2 1/3] arm64/numa: export memory_add_physaddr_to_nid as EXPORT_SYMBOL_GPL Message-ID: <20200707115454.GN5913@dhcp22.suse.cz> References: <20200707055917.143653-1-justin.he@arm.com> <20200707055917.143653-2-justin.he@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200707055917.143653-2-justin.he@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_075457_737413_66F2AFC2 X-CRM114-Status: GOOD ( 20.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kaly Xin , Dave Jiang , Baoquan He , linux-nvdimm@lists.01.org, Catalin Marinas , Chuhong Yuan , linux-kernel@vger.kernel.org, Mike Rapoport , linux-mm@kvack.org, Vishal Verma , Dan Williams , Will Deacon , Andrew Morton , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue 07-07-20 13:59:15, Jia He wrote: > This exports memory_add_physaddr_to_nid() for module driver to use. > > memory_add_physaddr_to_nid() is a fallback option to get the nid in case > NUMA_NO_NID is detected. > > Suggested-by: David Hildenbrand > Signed-off-by: Jia He > --- > arch/arm64/mm/numa.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c > index aafcee3e3f7e..7eeb31740248 100644 > --- a/arch/arm64/mm/numa.c > +++ b/arch/arm64/mm/numa.c > @@ -464,10 +464,11 @@ void __init arm64_numa_init(void) > > /* > * We hope that we will be hotplugging memory on nodes we already know about, > - * such that acpi_get_node() succeeds and we never fall back to this... > + * such that acpi_get_node() succeeds. But when SRAT is not present, the node > + * id may be probed as NUMA_NO_NODE by acpi, Here provide a fallback option. > */ > int memory_add_physaddr_to_nid(u64 addr) > { > - pr_warn("Unknown node for memory at 0x%llx, assuming node 0\n", addr); > return 0; > } > +EXPORT_SYMBOL_GPL(memory_add_physaddr_to_nid); Does it make sense to export a noop function? Wouldn't make more sense to simply make it static inline somewhere in a header? I haven't checked whether there is an easy way to do that sanely bu this just hit my eyes. -- Michal Hocko SUSE Labs _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel