From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C641C433DF for ; Tue, 7 Jul 2020 18:46:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4ECE6206E2 for ; Tue, 7 Jul 2020 18:46:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Elgj1DuY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ZRAbnoYe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4ECE6206E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PRBzumTvJrk2eVBWx6sl1nmMmFKeZQMsXr2jCguDpMI=; b=Elgj1DuYl8WwIGNmZY0I2aAvn ehpijTfUYxZ8QRuThIKI6BpqM7atLwvKBKrYoo9CEszst9BfOcDqEkdKnfF9AzX+0GRmI6z/GY2rC q8FFhMYvK9yEPn1lks4MGbRKsU7JjYkrSbQuMRmL1NxUP35LQFS2mFe9MuDvEq/zuPwkjsJtQhyyA dm2vbAyGW/88hFcNnoBt63elejBsd4nID/lcDVmEQT8nWrOHteOaoeg3dKTIWTtMr+RnzJh3MLtQW 26mtE/mFtlzRv0Pk6sdubR03RqJDpe5GD55D90cX9HiHkTUruWdIIgJ/VtU3gFXbsH7BfoKrMpGJp 1/HgPqQtQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jssZl-0002Ms-Uc; Tue, 07 Jul 2020 18:44:17 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jssZj-0002MG-MG for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 18:44:16 +0000 Received: by mail-wr1-x441.google.com with SMTP id f18so38260173wrs.0 for ; Tue, 07 Jul 2020 11:44:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=quRkH3piDVa59+VlMcisxCHSXNWjK1kUY5S/yF3xCpA=; b=ZRAbnoYeouFM1/H/tYHdc9ipGYXv4euR+tMeEcMnO6WGF+gx2vOHZ4Tr2eFazJkkEd 60O4ahEF6Nj58WW0Cz/gPtEuDUawAmWRgAMaG1Cf0x7Ne+IyOSwGIFVz/Dsbq7Pk8OMJ kGCTxQvmAj6NBIe7P5YI8MNpEf34m1t7jt74o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=quRkH3piDVa59+VlMcisxCHSXNWjK1kUY5S/yF3xCpA=; b=A6bdSp8zQM9bx8ME3kwxH96JE2BrquKGnYGIF7XuAOZwJ+eMi4hPM56wgF6zy9/Elg 137kRQxcL32L0Nr3fv6/u4HFqp/Ep1CrFd/lcVshWS3PC5k9TgQntZHyW/BFW3N/S39f VlifJdjKnT3Z182quTFXk/HGuzU6P60cVXvizfwPjENzchpZyEE2WKvmGruUN9rmrNgx S/6JsTK69eU+6V67NdWzErtc0RA6fS4k79rKu9yoooLIGlGUhF+02G9HVMbbmfgUBKp7 unPdybWjCpGcsdNAhyl2KbnNIiC0BflPMuPVqo0ZTkNfwWpCte3sp9CctGQyLtzIycL7 K54w== X-Gm-Message-State: AOAM5320AAF5cv0Uxc9i/0+4bjpDd19YaK2BMksZJjuBrgMNk0YcGVwQ 7jw71yLMHnRpVIscgHeh+tDT3VX0a1Xleg== X-Google-Smtp-Source: ABdhPJxgjESKdQWY9pLtFBqLyAUIW60bnRZRaPezyKkNG1iu3kU0qO+BJCOsPvxhOCFHBejqU6mveA== X-Received: by 2002:adf:8444:: with SMTP id 62mr52648218wrf.278.1594147454606; Tue, 07 Jul 2020 11:44:14 -0700 (PDT) Received: from chromium.org (205.215.190.35.bc.googleusercontent.com. [35.190.215.205]) by smtp.gmail.com with ESMTPSA id u186sm2173926wmu.10.2020.07.07.11.44.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 11:44:14 -0700 (PDT) Date: Tue, 7 Jul 2020 18:44:12 +0000 From: Tomasz Figa To: Jonathan Bakker Subject: Re: [PATCH 10/11] media: exynos4-is: Prevent duplicate call to media_pipeline_stop Message-ID: <20200707184412.GJ2621465@chromium.org> References: <20200426022650.10355-1-xc-racer2@live.ca> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_144415_777332_88718FCF X-CRM114-Status: UNSURE ( 9.00 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, krzk@kernel.org, kyungmin.park@samsung.com, kgene@kernel.org, s.nawrocki@samsung.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jonathan, On Sat, Apr 25, 2020 at 07:26:49PM -0700, Jonathan Bakker wrote: > media_pipeline_stop can be called from both release and streamoff, > so make sure they're both protected under the streaming flag and > not just one of them. First of all, thanks for the patch. Shouldn't it be that release calls streamoff, so that only streamoff is supposed to have the call to media_pipeline_stop()? Best regards, Tomasz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel