From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E489DC433E1 for ; Wed, 8 Jul 2020 06:22:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5D4720720 for ; Wed, 8 Jul 2020 06:22:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MC2UHFCW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5D4720720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Op18fmrwXoyxT4En5IivsuJy0cGcUlH89D2CXvwnF8g=; b=MC2UHFCWEoq5U+m0eV33LpRRm UrXFcue9bdNEEKV0rMjPbV29JVyxXzLcY3WpYF69woECdjTgIwKU3XVIsN+XIjftgSRMAprmVMEsm TcARtpr7G3xSYWlgYAnJvTaIwU8YzE0bNd/w2shMdS7x/hIaDxHHUC5dBddkryzhpkeLnMWifKYtA l3vjbQCiW1MimHZTyYvT6Tik4oK4atQ/BpefIJhloicVaP/l0DgmXCzR0A07BBdYHBqLTxz8fhZ7k eleju5RAdc1AS29PTyLTIDqN88nw19IDwgm008ecuaKpAC4nY2nufqQtmSrEuj9dsofVIi11fT5Jc fxYnHXbNQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jt3R0-0002a0-Qq; Wed, 08 Jul 2020 06:19:58 +0000 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jt3Qy-0002Yd-J7 for linux-arm-kernel@lists.infradead.org; Wed, 08 Jul 2020 06:19:57 +0000 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0686Ce0o118031; Wed, 8 Jul 2020 02:19:43 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3258nxg53j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Jul 2020 02:19:43 -0400 Received: from m0098394.ppops.net (m0098394.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 0686DxQb125567; Wed, 8 Jul 2020 02:19:42 -0400 Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com with ESMTP id 3258nxg52v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Jul 2020 02:19:42 -0400 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0686GvI5004232; Wed, 8 Jul 2020 06:19:40 GMT Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by ppma06ams.nl.ibm.com with ESMTP id 322h1h44n3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Jul 2020 06:19:40 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0686Jchh63307830 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 8 Jul 2020 06:19:38 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0689CAE045; Wed, 8 Jul 2020 06:19:38 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 76559AE053; Wed, 8 Jul 2020 06:19:36 +0000 (GMT) Received: from linux.ibm.com (unknown [9.148.202.29]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Wed, 8 Jul 2020 06:19:36 +0000 (GMT) Date: Wed, 8 Jul 2020 09:19:34 +0300 From: Mike Rapoport To: Dan Williams Subject: Re: [PATCH v2 1/3] arm64/numa: export memory_add_physaddr_to_nid as EXPORT_SYMBOL_GPL Message-ID: <20200708061934.GD386073@linux.ibm.com> References: <20200707055917.143653-1-justin.he@arm.com> <20200707055917.143653-2-justin.he@arm.com> <20200707115454.GN5913@dhcp22.suse.cz> <20200708053239.GC386073@linux.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-07-08_01:2020-07-08, 2020-07-08 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=1 clxscore=1015 lowpriorityscore=0 bulkscore=0 phishscore=0 mlxlogscore=999 priorityscore=1501 malwarescore=0 impostorscore=0 cotscore=-2147483648 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2007080038 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200708_021956_836862_91E4968B X-CRM114-Status: GOOD ( 39.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kaly Xin , Justin He , Baoquan He , David Hildenbrand , Catalin Marinas , "linux-nvdimm@lists.01.org" , Chuhong Yuan , "linux-kernel@vger.kernel.org" , Michal Hocko , "linux-mm@kvack.org" , Vishal Verma , Dave Jiang , Andrew Morton , Will Deacon , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 07, 2020 at 10:48:19PM -0700, Dan Williams wrote: > On Tue, Jul 7, 2020 at 10:33 PM Mike Rapoport wrote: > > > > On Tue, Jul 07, 2020 at 08:56:36PM -0700, Dan Williams wrote: > > > On Tue, Jul 7, 2020 at 7:20 PM Justin He wrote: > > > > > > > > Hi Michal and David > > > > > > > > > -----Original Message----- > > > > > From: Michal Hocko > > > > > Sent: Tuesday, July 7, 2020 7:55 PM > > > > > To: Justin He > > > > > Cc: Catalin Marinas ; Will Deacon > > > > > ; Dan Williams ; Vishal Verma > > > > > ; Dave Jiang ; Andrew > > > > > Morton ; Mike Rapoport ; > > > > > Baoquan He ; Chuhong Yuan ; linux- > > > > > arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux- > > > > > mm@kvack.org; linux-nvdimm@lists.01.org; Kaly Xin > > > > > Subject: Re: [PATCH v2 1/3] arm64/numa: export memory_add_physaddr_to_nid > > > > > as EXPORT_SYMBOL_GPL > > > > > > > > > > On Tue 07-07-20 13:59:15, Jia He wrote: > > > > > > This exports memory_add_physaddr_to_nid() for module driver to use. > > > > > > > > > > > > memory_add_physaddr_to_nid() is a fallback option to get the nid in case > > > > > > NUMA_NO_NID is detected. > > > > > > > > > > > > Suggested-by: David Hildenbrand > > > > > > Signed-off-by: Jia He > > > > > > --- > > > > > > arch/arm64/mm/numa.c | 5 +++-- > > > > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > > > > > > > > > diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c > > > > > > index aafcee3e3f7e..7eeb31740248 100644 > > > > > > --- a/arch/arm64/mm/numa.c > > > > > > +++ b/arch/arm64/mm/numa.c > > > > > > @@ -464,10 +464,11 @@ void __init arm64_numa_init(void) > > > > > > > > > > > > /* > > > > > > * We hope that we will be hotplugging memory on nodes we already know > > > > > about, > > > > > > - * such that acpi_get_node() succeeds and we never fall back to this... > > > > > > + * such that acpi_get_node() succeeds. But when SRAT is not present, > > > > > the node > > > > > > + * id may be probed as NUMA_NO_NODE by acpi, Here provide a fallback > > > > > option. > > > > > > */ > > > > > > int memory_add_physaddr_to_nid(u64 addr) > > > > > > { > > > > > > - pr_warn("Unknown node for memory at 0x%llx, assuming node 0\n", > > > > > addr); > > > > > > return 0; > > > > > > } > > > > > > +EXPORT_SYMBOL_GPL(memory_add_physaddr_to_nid); > > > > > > > > > > Does it make sense to export a noop function? Wouldn't make more sense > > > > > to simply make it static inline somewhere in a header? I haven't checked > > > > > whether there is an easy way to do that sanely bu this just hit my eyes. > > > > > > > > Okay, I can make a change in memory_hotplug.h, sth like: > > > > --- a/include/linux/memory_hotplug.h > > > > +++ b/include/linux/memory_hotplug.h > > > > @@ -149,13 +149,13 @@ int add_pages(int nid, unsigned long start_pfn, unsigned long nr_pages, > > > > struct mhp_params *params); > > > > #endif /* ARCH_HAS_ADD_PAGES */ > > > > > > > > -#ifdef CONFIG_NUMA > > > > -extern int memory_add_physaddr_to_nid(u64 start); > > > > -#else > > > > +#if !defined(CONFIG_NUMA) || !defined(memory_add_physaddr_to_nid) > > > > static inline int memory_add_physaddr_to_nid(u64 start) > > > > { > > > > return 0; > > > > } > > > > +#else > > > > +extern int memory_add_physaddr_to_nid(u64 start); > > > > #endif > > > > > > > > And then check the memory_add_physaddr_to_nid() helper on all arches, > > > > if it is noop(return 0), I can simply remove it. > > > > if it is not noop, after the helper, > > > > #define memory_add_physaddr_to_nid > > > > > > > > What do you think of this proposal? > > > > > > Especially for architectures that use memblock info for numa info > > > (which seems to be everyone except x86) why not implement a generic > > > memory_add_physaddr_to_nid() that does: > > > > That would be only arm64. > > > > Darn, I saw ARCH_KEEP_MEMBLOCK and had delusions of grandeur that it > could solve my numa api woes. At least for x86 the problem is already > solved with reserved numa_meminfo, but now I'm trying to write generic > drivers that use those apis and finding these gaps on other archs. I'm not sure if x86's numa_meminfo is a part of the solution or a part of the problem ;-) Anyway, this all indeed messy and there is a lot to improve there. -- Sincerely yours, Mike. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel