From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: "Eric Biggers" <ebiggers@google.com>,
"Ayush Sawal" <ayush.sawal@chelsio.com>,
"Jamie Iles" <jamie@jamieiles.com>,
"Fabio Estevam" <festevam@gmail.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Horia Geantă" <horia.geanta@nxp.com>,
"Rohit Maheshwari" <rohitm@chelsio.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Corentin Labbe" <clabbe@baylibre.com>,
"Tom Lendacky" <thomas.lendacky@amd.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Vinay Kumar Yadav" <vinay.yadav@chelsio.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"John Allen" <john.allen@amd.com>,
"Tero Kristo" <t-kristo@ti.com>,
linux-crypto@vger.kernel.org,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Shawn Guo" <shawnguo@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v4 05/13] crypto: sun8i-ce - permit asynchronous skcipher as fallback
Date: Wed, 8 Jul 2020 09:53:36 +0200 [thread overview]
Message-ID: <20200708075336.GB19609@Red> (raw)
In-Reply-To: <20200707063203.5018-6-ardb@kernel.org>
On Tue, Jul 07, 2020 at 09:31:55AM +0300, Ard Biesheuvel wrote:
> Even though the sun8i-ce driver implements asynchronous versions of
> ecb(aes) and cbc(aes), the fallbacks it allocates are required to be
> synchronous. Given that SIMD based software implementations are usually
> asynchronous as well, even though they rarely complete asynchronously
> (this typically only happens in cases where the request was made from
> softirq context, while SIMD was already in use in the task context that
> it interrupted), these implementations are disregarded, and either the
> generic C version or another table based version implemented in assembler
> is selected instead.
>
> Since falling back to synchronous AES is not only a performance issue, but
> potentially a security issue as well (due to the fact that table based AES
> is not time invariant), let's fix this, by allocating an ordinary skcipher
> as the fallback, and invoke it with the completion routine that was given
> to the outer request.
>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
> drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 41 ++++++++++----------
> drivers/crypto/allwinner/sun8i-ce/sun8i-ce.h | 8 ++--
> 2 files changed, 25 insertions(+), 24 deletions(-)
>
I finally took the time to rebase all my hash/xrng serie on top of this change and test this patch.
Tested-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Tested-on: sun50i-h6-pine-h64
Tested-on: sun8i-h3-orangepi-pc
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-08 7:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 6:31 [PATCH v4 00/13] crypto: permit asynchronous skciphers as driver fallbacks Ard Biesheuvel
2020-07-07 6:31 ` [PATCH v4 01/13] crypto: amlogic-gxl - default to build as module Ard Biesheuvel
2020-07-07 6:31 ` [PATCH v4 02/13] crypto: amlogic-gxl - permit async skcipher as fallback Ard Biesheuvel
2020-07-07 6:31 ` [PATCH v4 03/13] crypto: omap-aes - permit asynchronous " Ard Biesheuvel
2020-07-07 6:31 ` [PATCH v4 04/13] crypto: sun4i " Ard Biesheuvel
2020-07-07 6:31 ` [PATCH v4 05/13] crypto: sun8i-ce " Ard Biesheuvel
2020-07-08 7:53 ` Corentin Labbe [this message]
2020-07-07 6:31 ` [PATCH v4 06/13] crypto: sun8i-ss " Ard Biesheuvel
2020-07-07 6:31 ` [PATCH v4 07/13] crypto: ccp " Ard Biesheuvel
2020-07-07 20:04 ` John Allen
2020-07-07 6:31 ` [PATCH v4 08/13] crypto: chelsio " Ard Biesheuvel
2020-07-07 6:31 ` [PATCH v4 09/13] crypto: mxs-dcp " Ard Biesheuvel
2020-07-07 6:32 ` [PATCH v4 10/13] crypto: picoxcell " Ard Biesheuvel
2020-07-07 6:32 ` [PATCH v4 11/13] crypto: qce " Ard Biesheuvel
2020-07-07 6:32 ` [PATCH v4 12/13] crypto: sahara " Ard Biesheuvel
2020-07-07 6:32 ` [PATCH v4 13/13] crypto: mediatek - use AES library for GCM key derivation Ard Biesheuvel
2020-07-16 11:53 ` [PATCH v4 00/13] crypto: permit asynchronous skciphers as driver fallbacks Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708075336.GB19609@Red \
--to=clabbe.montjoie@gmail.com \
--cc=ardb@kernel.org \
--cc=ayush.sawal@chelsio.com \
--cc=clabbe@baylibre.com \
--cc=davem@davemloft.net \
--cc=ebiggers@google.com \
--cc=festevam@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@nxp.com \
--cc=jamie@jamieiles.com \
--cc=john.allen@amd.com \
--cc=kernel@pengutronix.de \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-omap@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=rohitm@chelsio.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=t-kristo@ti.com \
--cc=thomas.lendacky@amd.com \
--cc=vinay.yadav@chelsio.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).