From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7381BC433DF for ; Thu, 9 Jul 2020 16:50:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3FF03206A1 for ; Thu, 9 Jul 2020 16:50:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NBOXzSaq"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CF2pkdTO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3FF03206A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Rm+mUUTU3yyfYVyJC9Im0EQYabitmGdeU54WQhAEyIA=; b=NBOXzSaqVSi+veFAQ8d7+LuFt /bOkTL5ZC1gx0CER4T7ZPKdEg6E69/z/HoZ3XAoZegYfICa60mfmxKG4xmWWT2uKXWgV8cxA7HoR1 NoHuhQzMMWhZ7TbE+zUfoPlB0VcgL8BW2raVqKB4uLI9Pa6sj34l7uaJUomQSs07mdqHFihcZ8JnM nSyQJmfYyXrrt6rQaAeUc0IwShFOEhJhi5De6hGLEpqvJWTXRcRAItjcLgGtPW41d7xX2Tdg4x4yB MO9I6I3CRPiT8MeGQa5p3NVYxJtHayySDTRYk0PkdCjmlDRrazi/keElLRKp7MMRqBZyrNwLn6myI P7dN9Zliw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtZj7-00071B-Ci; Thu, 09 Jul 2020 16:48:49 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtZj4-0006z8-3p for linux-arm-kernel@lists.infradead.org; Thu, 09 Jul 2020 16:48:47 +0000 Received: by mail-pl1-x641.google.com with SMTP id f2so1060413plr.8 for ; Thu, 09 Jul 2020 09:48:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8JulLZkbhkxBJld9UcW1bp7kKFXu909a3L7NGHRfHog=; b=CF2pkdTO/cmM1aimn9kGQiMUMY8ZIeZzvrIAjzlPk2GimjcgWS8XUfvFmfhnT6a2KT 72SMMVNATr1EcnJ6XoPeFH1/wAmjX8QN9y6dnSB5lz2+WYkF0FkvrgIkA0oqIboA4/Ov uvNSSUDpDyYwAFfwTsTh7ZbnkuIQsY6dvVXWQ+3m1UEN34wQhbsJBBCKpqmqX959w/CK jACQ0XgWOItT5xl+kyOTcT/q5cTvqWZ7vULfsVNwndu4b+w0Eu+1VLDnthMPFTb7A84U PxQLIaS+brjNP4vU+sMuQyer+QAWr6xT1HrdciTaxdZ2Li2YF8zCBQkINqtjhzMwtfyt T+zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8JulLZkbhkxBJld9UcW1bp7kKFXu909a3L7NGHRfHog=; b=NpAS5OE1cb0orM+v1N2VV4NYX2Z/EOHtUrep0ZpuUlU3oBoiq7II8q3X2/xMPt55i7 7ixPPzSAXx+RVisY16kRLra0X0zfQzQPG2+eB0bTmfj12iVcnPrMJY3a94FsT2HyKpO/ kTVvH6lzrKf1x9EbiOQsJi9AKa8/lGBdAa0JFuT6KOjjdwZs+f9i8cgcHDT2YIuwn05n ePQwkWta/f68TQp26LYkHqeG0JZEEMs/2iYuNi6Dg7xEZSiKXtxvT2KgGu4PO9Smoikk ij3c6MJmIgYZwCCnj3aeASMqEbqzqpC45YNXU2ch9FLVwzaIHQ+F+zUOLSFXY7XHYr1M Y3Sw== X-Gm-Message-State: AOAM532HVh+xVx+L5uHe31gsv6dGeXqQpHmQxQyo/AK/WLbx/CHrdpKK 8PzjU/R7nrtpFtzKto+d+wC+ug== X-Google-Smtp-Source: ABdhPJwDJM3uQ2KakQWSb/5lIKFeBEQm4VshEG9AnmftSIGRVhm29Zscyx+er1CWEdTOkUl3kSyQVg== X-Received: by 2002:a17:902:ab8e:: with SMTP id f14mr57060503plr.80.1594313322777; Thu, 09 Jul 2020 09:48:42 -0700 (PDT) Received: from yoga (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id q29sm3225777pfl.77.2020.07.09.09.48.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2020 09:48:42 -0700 (PDT) Date: Thu, 9 Jul 2020 09:48:37 -0700 From: Bjorn Andersson To: Rob Clark Subject: Re: [PATCH 2/5] iommu/arm-smmu: Emulate bypass by using context banks Message-ID: <20200709164833.GR11847@yoga> References: <20200709050145.3520931-1-bjorn.andersson@linaro.org> <20200709050145.3520931-3-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200709_124846_717402_4871D39C X-CRM114-Status: GOOD ( 21.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jonathan Marek , Will Deacon , Joerg Roedel , Linux Kernel Mailing List , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Thierry Reding , linux-arm-msm , Robin Murphy , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Laurentiu Tudor Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu 09 Jul 09:17 PDT 2020, Rob Clark wrote: > On Wed, Jul 8, 2020 at 10:01 PM Bjorn Andersson > wrote: [..] > > @@ -678,7 +680,11 @@ static int arm_smmu_init_domain_context(struct iommu_domain *domain, > > if (smmu_domain->smmu) > > goto out_unlock; > > > > - if (domain->type == IOMMU_DOMAIN_IDENTITY) { > > + /* > > + * Nothing to do for IDENTITY domains,unless disabled context banks are > > + * used to emulate bypass mappings on Qualcomm platforms. > > + */ > > + if (domain->type == IOMMU_DOMAIN_IDENTITY && !smmu->qcom_bypass_quirk) { > > maybe I'm overlooking something, but I think this would put us back to > allocating pgtables (and making iommu->map/unmap() no longer no-ops), > which I don't think we want > You're right, we are allocating page tables for these contexts and map/unmap would modify the page tables. But afaict traversal is never performed, given that the banks are never enabled. But as drivers probe properly, or the direct mapped drivers sets up their iommu domains explicitly with translation this would not be used. So afaict we're just wasting some memory - for the gain of not overcomplicating this function. Regards, Bjorn > BR, > -R > > > smmu_domain->stage = ARM_SMMU_DOMAIN_BYPASS; > > smmu_domain->smmu = smmu; > > goto out_unlock; > > @@ -826,6 +832,10 @@ static int arm_smmu_init_domain_context(struct iommu_domain *domain, > > domain->geometry.aperture_end = (1UL << ias) - 1; > > domain->geometry.force_aperture = true; > > > > + /* Enable translation for non-identity context banks */ > > + if (domain->type != IOMMU_DOMAIN_IDENTITY) > > + cfg->m = true; > > + > > /* Initialise the context bank with our page table cfg */ > > arm_smmu_init_context_bank(smmu_domain, &pgtbl_cfg); > > arm_smmu_write_context_bank(smmu, cfg->cbndx); > > diff --git a/drivers/iommu/arm-smmu.h b/drivers/iommu/arm-smmu.h > > index d172c024be61..a71d193073e4 100644 > > --- a/drivers/iommu/arm-smmu.h > > +++ b/drivers/iommu/arm-smmu.h > > @@ -305,6 +305,8 @@ struct arm_smmu_device { > > > > /* IOMMU core code handle */ > > struct iommu_device iommu; > > + > > + bool qcom_bypass_quirk; > > }; > > > > enum arm_smmu_context_fmt { > > @@ -323,6 +325,7 @@ struct arm_smmu_cfg { > > }; > > enum arm_smmu_cbar_type cbar; > > enum arm_smmu_context_fmt fmt; > > + bool m; > > }; > > #define ARM_SMMU_INVALID_IRPTNDX 0xff > > > > -- > > 2.26.2 > > > > _______________________________________________ > > iommu mailing list > > iommu@lists.linux-foundation.org > > https://lists.linuxfoundation.org/mailman/listinfo/iommu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel