From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 415CAC433DF for ; Fri, 10 Jul 2020 08:54:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A00A207BC for ; Fri, 10 Jul 2020 08:54:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vWHH9MBL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A00A207BC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hZkuzO1lL6n/3fsMrHfozMyEhjgEC/cR+DjIsd1l8Rs=; b=vWHH9MBLOWxTngrgQQeuLJPMw nF+vx6QaNT1Y4JMLxYSmJBnvOkXWeyuQ5/abKw06bEoalPm2oMK8MnTLCDe78sHukMnMS2qr8EqSh EIbXmnOYbDZ+WRtGieppMcnvuzkqgbqyIRU9zSlgiUFl8vGH1h+g2ov4h9kVdBpvxgQ75daPIDlsI l3AOlTlVrttmZLpdi4neAGER4WJztZhHJ2B+vF/Q44+MWj14y8M+awtgKFT1FWDBygin6zaSXanER fMym+KzSsLII57397JjBUcOf4phzYfIrVXf2W6+APXze7yBF+/Ck6jSKnzSWV0Nt9fBJsoaBiuikY 2DCcJgSnA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtomo-00070X-1o; Fri, 10 Jul 2020 08:53:38 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtomk-0006ys-Iy for linux-arm-kernel@lists.infradead.org; Fri, 10 Jul 2020 08:53:35 +0000 Received: from gaia (unknown [95.146.230.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E6EA0207BC; Fri, 10 Jul 2020 08:53:29 +0000 (UTC) Date: Fri, 10 Jul 2020 09:53:27 +0100 From: Catalin Marinas To: Zhenyu Ye Subject: Re: [RESEND PATCH v5 3/6] arm64: Add tlbi_user_level TLB invalidation helper Message-ID: <20200710085326.GA11839@gaia> References: <20200625080314.230-1-yezhenyu2@huawei.com> <20200625080314.230-4-yezhenyu2@huawei.com> <20200709164845.GB6579@gaia> <33a5dc75-8209-e198-bb41-8b4ab82c000e@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <33a5dc75-8209-e198-bb41-8b4ab82c000e@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200710_045334_714554_E9E2FC5A X-CRM114-Status: GOOD ( 15.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, peterz@infradead.org, linux-mm@kvack.org, guohanjun@huawei.com, will@kernel.org, linux-arch@vger.kernel.org, yuzhao@google.com, aneesh.kumar@linux.ibm.com, steven.price@arm.com, arm@kernel.org, Dave.Martin@arm.com, arnd@arndb.de, suzuki.poulose@arm.com, npiggin@gmail.com, zhangshaokun@hisilicon.com, broonie@kernel.org, rostedt@goodmis.org, prime.zeng@hisilicon.com, kuhn.chenqun@huawei.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, xiexiangyou@huawei.com, linux-kernel@vger.kernel.org, maz@kernel.org, akpm@linux-foundation.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 10, 2020 at 09:20:59AM +0800, Zhenyu Ye wrote: > On 2020/7/10 0:48, Catalin Marinas wrote: > > On Thu, Jun 25, 2020 at 04:03:11PM +0800, Zhenyu Ye wrote: > >> @@ -189,8 +195,9 @@ static inline void flush_tlb_page_nosync(struct vm_area_struct *vma, > >> unsigned long addr = __TLBI_VADDR(uaddr, ASID(vma->vm_mm)); > >> > >> dsb(ishst); > >> - __tlbi(vale1is, addr); > >> - __tlbi_user(vale1is, addr); > >> + /* This function is only called on a small page */ > >> + __tlbi_level(vale1is, addr, 3); > >> + __tlbi_user_level(vale1is, addr, 3); > >> } > > > > Actually, that's incorrect. It was ok in v2 of your patches when I > > suggested to drop level 0, just leave the function unchanged but I > > missed that you updated it to pass level 3. > > > > pmdp_set_access_flags -> ptep_set_access_flags -> > > flush_tlb_fix_spurious_fault -> flush_tlb_page -> flush_tlb_page_nosync. > > How do you want to fix this error? I notice that this series have been applied > to arm64 (for-next/tlbi). Should I send a new series based on arm64 (for-next/tlbi)? Just a patch on top with a Fixes: tag. Thanks. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel