From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCDEEC433E4 for ; Fri, 10 Jul 2020 12:26:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8BE5120748 for ; Fri, 10 Jul 2020 12:26:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="k+WOl2z0"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BmPVJH93" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8BE5120748 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gVjHuOIr/IAzFD8K78Fa0ZP2b4bK2040+DZD0g2Rp6w=; b=k+WOl2z0EYaNbuHmw2c3WbuxZ kJDv/3I8e3UTXOp9uvwMhzBR7qoZlcNEgn253xQYEljWxTi9fYJBQZwJIesqafp8M+xr4QHyMp+Lv 7GSM2qLqKxhbZiDhsWkSuKxnj+X3jyYACSpbhBK8I51QkkMX15EacqQTyFEFb448l3eEaVEs4KGmU A0IxCXEPJWccXsRN4UIioeMyzF8i7uDXVeWnJTzjIdwoKKbjO+V6LdLI9GbesmVl5JN1ja5nqgOhR MXAdw6Gbx7ozfmYEQev2LD/veuQP37TJCQDn0uyQpF6JGxPcVgHc/V3GnkGWgQRAAatkZfQffoQlw v1rsxHi3g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jts5S-0001Vv-Vl; Fri, 10 Jul 2020 12:25:07 +0000 Received: from us-smtp-1.mimecast.com ([205.139.110.61]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jts5Q-0001V8-87 for linux-arm-kernel@lists.infradead.org; Fri, 10 Jul 2020 12:25:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594383902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L0hOyZUN+03GuTp9OTs3UI1n+mDLLNwC0EajqWUs9a0=; b=BmPVJH935M2AjMvw942EKz0CjMiCgnhg+9UAaFn2v6H9f3uOXaSpXp3qi+5O9UxDl/rch0 ICLMFU3M8KT2BsELIP2skPrmmbJGP9d2fIZGE5igkOfgfQCl2hxin/BscLq0PIzLLUoKB5 LrkofTDIFZIdTYGsMS28KdX6KrakUv8= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-16-QcHBoec0Oe2uEAkVqLSrkQ-1; Fri, 10 Jul 2020 08:25:00 -0400 X-MC-Unique: QcHBoec0Oe2uEAkVqLSrkQ-1 Received: by mail-qk1-f197.google.com with SMTP id i6so4213349qkn.22 for ; Fri, 10 Jul 2020 05:25:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=L0hOyZUN+03GuTp9OTs3UI1n+mDLLNwC0EajqWUs9a0=; b=FY27gAkncKAoABz4Rn6L1dyNaZE+4OxZ4hiJg7wF/peoRfPAXNmRVMF+Y5YRz53TNG OGrvvfgFpnSe5VC5BZgcJxcXQpn5IHTxVCRpmb7ATsmCCmxl+hxfoj1rsnWztI8WYGEK tjYHXdt+9Rew6IplqG5HmOKux1/E3Si7XWwJpJVcDui/RR1doolCtL+TG3tEhV8XRoBo 3kgkPvyXYXLX1Mw9PNMwIezU3CRbqXl7QQKCdwMPSj539F5RlLdF1AuSjbl6B707QfQw XTRl+RwMRF8pdifuO4fammnRqEzyWTLjcYLxr6RXtYLkV7bXy7e6CNYn5c1sD29bqpTE 0LVQ== X-Gm-Message-State: AOAM531qL66c9CuasiBbXQsYwi8uRc4TyT3X7FFH6wLxfdcjXobTzm9y pyuSJ1JEg8OT4ApDZOdpyn7U3oTBCN8EaSUp5ky0+8UfZ7C28rRtyyi/fJmpNzAIUK/KkeIQaQ8 KHOCxNWzIMQ+K/LHNGOGVuP9kqHx/z7t5ueo= X-Received: by 2002:a37:5c04:: with SMTP id q4mr69897701qkb.192.1594383899628; Fri, 10 Jul 2020 05:24:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZCEam4ITHLazo8LlqpUBa3bRvYodX8117NUGTyJ0/4vVQlviNcOv4NGAru2IbJa8w8CcoAA== X-Received: by 2002:a37:5c04:: with SMTP id q4mr69897670qkb.192.1594383899322; Fri, 10 Jul 2020 05:24:59 -0700 (PDT) Received: from xz-x1 ([2607:9880:19c8:6f::1f4f]) by smtp.gmail.com with ESMTPSA id u27sm7435925qkm.121.2020.07.10.05.24.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2020 05:24:58 -0700 (PDT) Date: Fri, 10 Jul 2020 08:24:57 -0400 From: Peter Xu To: Mark Brown Subject: Re: Build failure in -next with get_user_pages_remote() API change Message-ID: <20200710122457.GK199122@xz-x1> References: <20200710113201.GC5653@sirena.org.uk> MIME-Version: 1.0 In-Reply-To: <20200710113201.GC5653@sirena.org.uk> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200710_082504_335889_AEFEF672 X-CRM114-Status: GOOD ( 12.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Hubbard , Steven Price , linux-next@vger.kernel.org, Catalin Marinas , Andrew Morton , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 10, 2020 at 12:32:01PM +0100, Mark Brown wrote: > Today's -next fails to build in various arm64 configs with: > > arch/arm64/kernel/mte.c:225:23: error: too many arguments to function call, expected 7, have 8 > &page, &vma, NULL); > ^~~~ > ./include/linux/stddef.h:8:14: note: expanded from macro 'NULL' > #define NULL ((void *)0) > ^~~~~~~~~~~ > ./include/linux/mm.h:1705:6: note: 'get_user_pages_remote' declared here > long get_user_pages_remote(struct mm_struct *mm, > ^ > 1 error generated. > > caused by b7363b0ab88d66d3c (mm/gup: remove task_struct pointer for all > gup code) which updated the signature of get_user_pages_remote() without > updating the caller in mte.c. We should need to squash into "mm/gup: remove task_struct pointer for all gup code" with: diff --git a/arch/arm64/kernel/mte.c b/arch/arm64/kernel/mte.c index 934639ab225d..11e558b02a05 100644 --- a/arch/arm64/kernel/mte.c +++ b/arch/arm64/kernel/mte.c @@ -221,7 +221,7 @@ static int __access_remote_tags(struct task_struct *tsk, struct mm_struct *mm, void *maddr; struct page *page = NULL; - ret = get_user_pages_remote(tsk, mm, addr, 1, gup_flags, + ret = get_user_pages_remote(mm, addr, 1, gup_flags, &page, &vma, NULL); if (ret <= 0) break; Seems to be a new caller merged recently, so it got left behind during the rebases... Sorry for not noticing that. Thanks, -- Peter Xu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel