From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24040C433E6 for ; Fri, 10 Jul 2020 13:37:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4B1520720 for ; Fri, 10 Jul 2020 13:37:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dkXkWxBi"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="0hbWFLiy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4B1520720 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dTLNev/gEdCklSKF8qrf5xgob2bdhYBbeqK8J81hsxI=; b=dkXkWxBij2K4cUqWH8M5qQJ7j 2Kn7uF7Nsdcia/GPY1Lq971PiM4v6XpKXT33TVy/2XjiQxlUXLpZskjTW12GQNOUG8mnjb+BUY3Bp +X1O7rTYUy0R2MjWcYuPPG2zLHVmuJzNTbvzOn/bTqRtXmVkktYYITlpGRjoJsV1fkbqcRZNthsmi +lEUaF6VGjQ65LF25izVS/aevSEWjyu9ZcTCgH08B0IZsYe/TggyfAH+F31tc9r/iE3h9QXGK+9IG c7+W7S8ALJAJTCOGyvOUw8wmpkgVgYLSKw/7vZKgv9EP0gbbcf1Rl2nyaZ0QMn0GLry+fApf00hdL BgflQzqlg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jttBl-0006ya-QJ; Fri, 10 Jul 2020 13:35:41 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jttBj-0006xy-7I; Fri, 10 Jul 2020 13:35:40 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B33FC20578; Fri, 10 Jul 2020 13:35:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594388138; bh=GYwhfPPSSQUzVvWIRjqnThS7qq09fREoDCz/zT6/X4U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0hbWFLiy0OLeXTh9bRDrRI4QBAt4mQKefhx/GqoGNtBVHMLRGaDjOwoumerfgxGV9 g076xC+loOiEG0jCh1tuvKPQObWkHVHwS/vF67qYFFPwGa0ye+i6eMR2UoCpHdFQtn tCZpqOjNWfgUWCVBTe34HugJ/9/eNBcVpUsXdMWQ= Date: Fri, 10 Jul 2020 15:35:42 +0200 From: Greg Kroah-Hartman To: Cristian Ciocaltea Subject: Re: [PATCH 1/1] tty: serial: owl: Initialize lock before registering port Message-ID: <20200710133542.GA2172832@kroah.com> References: <89f6393934fc6d493f8b9e87c1a6e916642b6a18.1590749143.git.cristian.ciocaltea@gmail.com> <20200529113419.GA1631227@kroah.com> <20200710120549.GA11293@BV030612LT> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200710120549.GA11293@BV030612LT> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200710_093539_524019_C006911A X-CRM114-Status: GOOD ( 28.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Manivannan Sadhasivam , linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Jiri Slaby , Andy Shevchenko , Andreas =?iso-8859-1?Q?F=E4rber?= , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 10, 2020 at 03:05:49PM +0300, Cristian Ciocaltea wrote: > On Fri, May 29, 2020 at 01:34:19PM +0200, Greg Kroah-Hartman wrote: > > On Fri, May 29, 2020 at 02:06:47PM +0300, Cristian Ciocaltea wrote: > > > Running a lockdep-enabled kernel leads to the following splat when > > > probing the owl-uart driver: > > > > > > [ 1.271784] b0124000.serial: ttyOWL2 at MMIO 0xb0124000 (irq = 22, base_baud = 1500000) is a owl-uart > > > [ 1.281226] INFO: trying to register non-static key. > > > [ 1.286179] the code is fine but needs lockdep annotation. > > > [ 1.291648] turning off the locking correctness validator. > > > [ 1.297125] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.7.0-rc7+ #70 > > > [ 1.303462] Hardware name: Generic DT based system > > > [ 1.308268] [<80111d3c>] (unwind_backtrace) from [<8010c9b8>] (show_stack+0x10/0x14) > > > [ 1.316003] [<8010c9b8>] (show_stack) from [<805016b4>] (dump_stack+0xb4/0xe0) > > > [ 1.323218] [<805016b4>] (dump_stack) from [<80182dec>] (register_lock_class+0x25c/0x8f4) > > > [ 1.331391] [<80182dec>] (register_lock_class) from [<8017ee34>] (__lock_acquire+0xb4/0x2ee4) > > > [ 1.339901] [<8017ee34>] (__lock_acquire) from [<8018291c>] (lock_acquire+0x424/0x4c8) > > > [ 1.347813] [<8018291c>] (lock_acquire) from [<808597b0>] (_raw_spin_lock_irqsave+0x54/0x68) > > > [ 1.356242] [<808597b0>] (_raw_spin_lock_irqsave) from [<80582e94>] (uart_add_one_port+0x384/0x510) > > > [ 1.365276] [<80582e94>] (uart_add_one_port) from [<8058b4d0>] (owl_uart_probe+0x1bc/0x248) > > > [ 1.373621] [<8058b4d0>] (owl_uart_probe) from [<8059c0e4>] (platform_drv_probe+0x48/0x94) > > > [ 1.381874] [<8059c0e4>] (platform_drv_probe) from [<805997c4>] (really_probe+0x200/0x470) > > > [ 1.390123] [<805997c4>] (really_probe) from [<80599c80>] (driver_probe_device+0x16c/0x1bc) > > > [ 1.398461] [<80599c80>] (driver_probe_device) from [<80599f18>] (device_driver_attach+0x44/0x60) > > > [ 1.407317] [<80599f18>] (device_driver_attach) from [<8059a078>] (__driver_attach+0x144/0x14c) > > > [ 1.416000] [<8059a078>] (__driver_attach) from [<805978ac>] (bus_for_each_dev+0x5c/0xb4) > > > [ 1.424162] [<805978ac>] (bus_for_each_dev) from [<8059896c>] (bus_add_driver+0x118/0x204) > > > [ 1.432410] [<8059896c>] (bus_add_driver) from [<8059ae6c>] (driver_register+0xbc/0xf8) > > > [ 1.440405] [<8059ae6c>] (driver_register) from [<80c1fd24>] (owl_uart_init+0x20/0x40) > > > [ 1.448313] [<80c1fd24>] (owl_uart_init) from [<801021d8>] (do_one_initcall+0x184/0x3a4) > > > [ 1.456399] [<801021d8>] (do_one_initcall) from [<80c01100>] (kernel_init_freeable+0x264/0x2e4) > > > [ 1.465085] [<80c01100>] (kernel_init_freeable) from [<80850a88>] (kernel_init+0x8/0x110) > > > [ 1.473249] [<80850a88>] (kernel_init) from [<80100114>] (ret_from_fork+0x14/0x20) > > > [ 1.480800] Exception stack(0xee8bdfb0 to 0xee8bdff8) > > > [ 1.485841] dfa0: 00000000 00000000 00000000 00000000 > > > [ 1.494002] dfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 > > > [ 1.502162] dfe0: 00000000 00000000 00000000 00000000 00000013 00000000 > > > [ 1.508914] printk: console [ttyOWL2] enabled > > > > > > The locking issue occurs in uart_configure_port() when trying to > > > guard the call to set_mctrl(). > > > > > > uart_add_one_port() should normally initialize the spinlock via > > > uart_port_spin_lock_init(), but it never happens because the port is > > > detected as a console and, as a consequence, the spinlock is expected > > > to be already initialized. > > > > > > The commit a3cb39d258ef > > > ("serial: core: Allow detach and attach serial device for console") > > > changed the lock initialization logic to assume the spinlock is > > > initialized even if the console is not enabled. > > > > > > Therefore, initialize the lock explicitly in owl_uart_probe(), before > > > attempting to invoke uart_add_one_port(). > > > > > > Fixes: a3cb39d258ef ("serial: core: Allow detach and attach serial device for console") > > > Signed-off-by: Cristian Ciocaltea > > > --- > > > drivers/tty/serial/owl-uart.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/tty/serial/owl-uart.c b/drivers/tty/serial/owl-uart.c > > > index c149f8c30007..c2fa2f15d50a 100644 > > > --- a/drivers/tty/serial/owl-uart.c > > > +++ b/drivers/tty/serial/owl-uart.c > > > @@ -705,6 +705,8 @@ static int owl_uart_probe(struct platform_device *pdev) > > > owl_uart_ports[pdev->id] = owl_port; > > > platform_set_drvdata(pdev, owl_port); > > > > > > + spin_lock_init(&owl_port->port.lock); > > > + > > > ret = uart_add_one_port(&owl_uart_driver, &owl_port->port); > > > if (ret) > > > owl_uart_ports[pdev->id] = NULL; > > > > Ugh, another one :( > > > > Thanks for this, will queue this up now. > > > > greg k-h > > Hi Greg, > > I think this was mistakenly omitted from the inclusion in v5.8, or > has it been postponed for v5.9? I can't find it anywhere :( But I think we now have a core fix for this, no need to do this in any individual driver, right? Can you test my tty-linus branch to see if your change is still needed or not? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel