From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB189C433E6 for ; Mon, 13 Jul 2020 17:23:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A00C2075D for ; Mon, 13 Jul 2020 17:23:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="q0VPKlPh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A00C2075D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FkccsKD3qme/fstDJrBcl2gc4TTQs1q9B2m01dEe1PY=; b=q0VPKlPhIaUBTMxTDAm412bCf nQT6Nr2BsRlIMIV3K7PmpMTl14lgwa0Q2zrxho12ptsI+BUi+vpWuUeV7DSI5trn/yZqiXMXcLvI4 GMTTjIjsFLEtJgNTWbuoqrQjbd4xJs1QvbQ+JB5gIA/e60OSWDAXGuc++DBCRWtEkDe/ecVHKtdkE ZnShxR9utMZ4x22zhVkZhl0M/a/bFTebfE9od8CMBqmR86bWdHxf2g1GndDpy3cGovQ/2r48g8wHA MJ5XWRjHtTsy9Dz/0HCZE0ApdHYTy5FVNQc82lp1FErG1lrQ6Jc9LFa6jPmyE3iMN93/RWZ2HlgPS k9WUQYDrg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jv29Y-0007FE-EV; Mon, 13 Jul 2020 17:22:08 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jv29V-0007EG-2w for linux-arm-kernel@lists.infradead.org; Mon, 13 Jul 2020 17:22:05 +0000 Received: from gaia (unknown [95.146.230.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 96F82206F5; Mon, 13 Jul 2020 17:22:01 +0000 (UTC) Date: Mon, 13 Jul 2020 18:21:59 +0100 From: Catalin Marinas To: Jon Hunter Subject: Re: [PATCH v2 2/2] arm64: tlb: Use the TLBI RANGE feature in arm64 Message-ID: <20200713172158.GE15829@gaia> References: <20200710094420.517-1-yezhenyu2@huawei.com> <20200710094420.517-3-yezhenyu2@huawei.com> <4040f429-21c8-0825-2ad4-97786c3fe7c1@nvidia.com> <7237888d-2168-cd8b-c83d-c8e54871793d@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7237888d-2168-cd8b-c83d-c8e54871793d@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200713_132205_211493_D04EB60E X-CRM114-Status: GOOD ( 14.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, linux-tegra , suzuki.poulose@arm.com, maz@kernel.org, Zhenyu Ye , linux-kernel@vger.kernel.org, xiexiangyou@huawei.com, steven.price@arm.com, zhangshaokun@hisilicon.com, linux-mm@kvack.org, arm@kernel.org, prime.zeng@hisilicon.com, guohanjun@huawei.com, olof@lixom.net, kuhn.chenqun@huawei.com, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 13, 2020 at 03:44:16PM +0100, Jon Hunter wrote: > On 13/07/2020 15:39, Zhenyu Ye wrote: > > On 2020/7/13 22:27, Jon Hunter wrote: > >> After this change I am seeing the following build errors ... > >> > >> /tmp/cckzq3FT.s: Assembler messages: > >> /tmp/cckzq3FT.s:854: Error: unknown or missing operation name at operand 1 -- `tlbi rvae1is,x7' > >> /tmp/cckzq3FT.s:870: Error: unknown or missing operation name at operand 1 -- `tlbi rvae1is,x7' > >> /tmp/cckzq3FT.s:1095: Error: unknown or missing operation name at operand 1 -- `tlbi rvae1is,x7' > >> /tmp/cckzq3FT.s:1111: Error: unknown or missing operation name at operand 1 -- `tlbi rvae1is,x7' > >> /tmp/cckzq3FT.s:1964: Error: unknown or missing operation name at operand 1 -- `tlbi rvae1is,x7' > >> /tmp/cckzq3FT.s:1980: Error: unknown or missing operation name at operand 1 -- `tlbi rvae1is,x7' > >> /tmp/cckzq3FT.s:2286: Error: unknown or missing operation name at operand 1 -- `tlbi rvae1is,x7' > >> /tmp/cckzq3FT.s:2302: Error: unknown or missing operation name at operand 1 -- `tlbi rvae1is,x7' > >> /tmp/cckzq3FT.s:4833: Error: unknown or missing operation name at operand 1 -- `tlbi rvae1is,x6' > >> /tmp/cckzq3FT.s:4849: Error: unknown or missing operation name at operand 1 -- `tlbi rvae1is,x6' > >> /tmp/cckzq3FT.s:5090: Error: unknown or missing operation name at operand 1 -- `tlbi rvae1is,x6' > >> /tmp/cckzq3FT.s:5106: Error: unknown or missing operation name at operand 1 -- `tlbi rvae1is,x6' > >> /tmp/cckzq3FT.s:874: Error: attempt to move .org backwards > >> /tmp/cckzq3FT.s:1115: Error: attempt to move .org backwards > >> /tmp/cckzq3FT.s:1984: Error: attempt to move .org backwards > >> /tmp/cckzq3FT.s:2306: Error: attempt to move .org backwards > >> /tmp/cckzq3FT.s:4853: Error: attempt to move .org backwards > >> /tmp/cckzq3FT.s:5110: Error: attempt to move .org backwards > >> scripts/Makefile.build:280: recipe for target 'arch/arm64/mm/hugetlbpage.o' failed > >> make[3]: *** [arch/arm64/mm/hugetlbpage.o] Error 1 > >> scripts/Makefile.build:497: recipe for target 'arch/arm64/mm' failed > >> make[2]: *** [arch/arm64/mm] Error 2 > > > > The code must be built with binutils >= 2.30. > > Maybe I should add a check on whether binutils supports ARMv8.4-a instructions... > > Yes I believe so. The binutils guys in Arm confirmed that assembling "tlbi rvae1is" without -march=armv8.4-a is a bug. When it gets fixed, checking for the binutils version is not sufficient without passing -march. I think we are better off with a manual encoding of the instruction. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel