From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A0ACC433DF for ; Mon, 13 Jul 2020 23:03:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 163E82137B for ; Mon, 13 Jul 2020 23:03:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XFxUoVY2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 163E82137B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mH4RnFB5HAuA2Ap+IwCOb+MMBvATmIzrx78ggJSQ24c=; b=XFxUoVY2dr7znl15VRe5KH5oU TYb0CDqyeBphuRaMt2YlO+0yiI0+9SYoToYWGv1TS3+yl9H5BgfS5CtUJGkDJ/UINa7lmr/csn7x9 SnQjmg0qMYmtYtKSPDl2AjjAw4WTx/2AgA90SPrQcS8iPu4Z/oVFq5VWctujA3b24HIFpiht4gVqn L26zHZem0KVSa/QjDkNf9Q5I3eYiI5c0tW1z4NO0T15n1MFcOJnwLMLqk8f7w6byDYX/5sMMMBhE+ Rm5HMmpAKbgT6p5TPb1NTJZeiIe4ziYMLg/4LVoLSaScp+9rNCLbR3EevhdhwoFbzmUZf3qeZaC6B h8E3VyvGA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jv7S5-0004Xj-Dp; Mon, 13 Jul 2020 23:01:37 +0000 Received: from mail-io1-f68.google.com ([209.85.166.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jv7S2-0004X3-OW for linux-arm-kernel@lists.infradead.org; Mon, 13 Jul 2020 23:01:35 +0000 Received: by mail-io1-f68.google.com with SMTP id i4so15302394iov.11 for ; Mon, 13 Jul 2020 16:01:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rEM2k8uDu6wNpoJYOHurqvj/7if6gaGt94wx89r0Kh8=; b=NnpNvvLnyQ8VV1Nu8NC0UE3nc/mVXvc1DjMcJ/GXZ5vk6rzLtO2bEmjMhk3e/wFOMq 4C2SncuJIdJSitMcLJ6v00LMmz7RvwEZ1oWBwOg7e9SAqZ5/S7a9mxEDnn2pyhq2lN5V z+sepUorPTnfR3emKEu647bGouW0ZD8Jd5+omKdwq4z4Jjxhm8CzVWrzsW8EK1XS+4Xa UIWOlLLRCnn/ThF9k3JHuL+YS8KsfbxY3f5U8cHnYkE7kefKaGPiblRZ/+Z9pGkNVhA5 GWZO1GcPh7vHJyf3vzNBux4UC9Y/S1BxFiIoYR8P9/srWPU9/sBJhXMVxM8Xj/cxLxCV s+dw== X-Gm-Message-State: AOAM532lfROKEWi+M6QGE6XmXQK6ugRxBLz2p06beoESTGKjiykr7DRD Eq54VLTenviZQ4z8hFOwgA== X-Google-Smtp-Source: ABdhPJzitorPXcF0bFX7xRNpmgTS4ftYPc0PfK6f0HOeq7fu4Bmtfs4az6Nwch3uwiUL5xTcLGCWcA== X-Received: by 2002:a05:6602:2fd5:: with SMTP id v21mr2073969iow.41.1594681293949; Mon, 13 Jul 2020 16:01:33 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id t1sm8482566iob.16.2020.07.13.16.01.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 16:01:33 -0700 (PDT) Received: (nullmailer pid 883186 invoked by uid 1000); Mon, 13 Jul 2020 23:01:29 -0000 Date: Mon, 13 Jul 2020 17:01:29 -0600 From: Rob Herring To: Frank Lee Subject: Re: [PATCH v3 03/16] dt-bindings: pinctrl: sunxi: Add A100 pinctrl bindings Message-ID: <20200713230129.GA875173@bogus> References: <20200708071942.22595-1-frank@allwinnertech.com> <20200708071942.22595-4-frank@allwinnertech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200708071942.22595-4-frank@allwinnertech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200713_190134_804695_7818DD40 X-CRM114-Status: GOOD ( 17.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: megous@megous.com, liyong@allwinnertech.com, tiny.windzz@gmail.com, linus.walleij@linaro.org, srinivas.kandagatla@linaro.org, linux-i2c@vger.kernel.org, lee.jones@linaro.org, linux-clk@vger.kernel.org, amit.kucheria@verdurent.com, stefan@olimex.com, maz@kernel.org, gregory.clement@bootlin.com, daniel.lezcano@linaro.org, anarsoul@gmail.com, wens@csie.org, huangshuosheng@allwinnertech.com, clabbe@baylibre.com, rui.zhang@intel.com, mturquette@baylibre.com, icenowy@aosc.io, devicetree@vger.kernel.org, jason@lakedaemon.net, bage@linutronix.de, linux-pm@vger.kernel.org, mripard@kernel.org, linux-gpio@vger.kernel.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 08, 2020 at 03:19:29PM +0800, Frank Lee wrote: > Add device tree binding Documentation details for A100 pinctrl driver, > whic has an r pin controller and a pin controller with more irq lines. s/whic/which/ 'an r pin controller'? > > Signed-off-by: Frank Lee > --- > .../pinctrl/allwinner,sun4i-a10-pinctrl.yaml | 74 +++++++++++++--------- > 1 file changed, 44 insertions(+), 30 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > index bfefd09..226aba0 100644 > --- a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > @@ -48,6 +48,8 @@ properties: > - allwinner,sun9i-a80-r-pinctrl > - allwinner,sun50i-a64-pinctrl > - allwinner,sun50i-a64-r-pinctrl > + - allwinner,sun50i-a100-pinctrl > + - allwinner,sun50i-a100-r-pinctrl > - allwinner,sun50i-h5-pinctrl > - allwinner,sun50i-h6-pinctrl > - allwinner,sun50i-h6-r-pinctrl > @@ -59,7 +61,7 @@ properties: > > interrupts: > minItems: 1 > - maxItems: 5 > + maxItems: 7 > description: > One interrupt per external interrupt bank supported on the > controller, sorted by bank number ascending order. > @@ -144,75 +146,87 @@ allOf: > # FIXME: We should have the pin bank supplies here, but not a lot of > # boards are defining it at the moment so it would generate a lot of > # warnings. > - > - if: > properties: > compatible: > enum: > - - allwinner,sun9i-a80-pinctrl > + - allwinner,sun50i-a100-pinctrl > > then: > properties: > interrupts: > - minItems: 5 > - maxItems: 5 > + minItems: 7 > + maxItems: 7 > > else: > if: This diff is hard to follow. Rather than a continual nesting of 'else' clauses, just make each 'if' a new entry under 'allOf' and get rid of the else. Perhaps do that in a separate patch first, then this change will be easier to review. > properties: > compatible: > enum: > - - allwinner,sun6i-a31-pinctrl > - - allwinner,sun6i-a31s-pinctrl > - - allwinner,sun50i-h6-pinctrl > + - allwinner,sun9i-a80-pinctrl > > then: > properties: > interrupts: > - minItems: 4 > - maxItems: 4 > + minItems: 5 > + maxItems: 5 > > else: > if: > properties: > compatible: > enum: > - - allwinner,sun8i-a23-pinctrl > - - allwinner,sun8i-a83t-pinctrl > - - allwinner,sun50i-a64-pinctrl > - - allwinner,sun50i-h5-pinctrl > - - allwinner,suniv-f1c100s-pinctrl > + - allwinner,sun6i-a31-pinctrl > + - allwinner,sun6i-a31s-pinctrl > + - allwinner,sun50i-h6-pinctrl > > then: > properties: > interrupts: > - minItems: 3 > - maxItems: 3 > + minItems: 4 > + maxItems: 4 > > else: > if: > properties: > compatible: > enum: > - - allwinner,sun6i-a31-r-pinctrl > - - allwinner,sun8i-a33-pinctrl > - - allwinner,sun8i-h3-pinctrl > - - allwinner,sun8i-v3-pinctrl > - - allwinner,sun8i-v3s-pinctrl > - - allwinner,sun9i-a80-r-pinctrl > - - allwinner,sun50i-h6-r-pinctrl > + - allwinner,sun8i-a23-pinctrl > + - allwinner,sun8i-a83t-pinctrl > + - allwinner,sun50i-a64-pinctrl > + - allwinner,sun50i-h5-pinctrl > + - allwinner,suniv-f1c100s-pinctrl > > then: > properties: > interrupts: > - minItems: 2 > - maxItems: 2 > + minItems: 3 > + maxItems: 3 > > else: > - properties: > - interrupts: > - minItems: 1 > - maxItems: 1 > + if: > + properties: > + compatible: > + enum: > + - allwinner,sun6i-a31-r-pinctrl > + - allwinner,sun8i-a33-pinctrl > + - allwinner,sun8i-h3-pinctrl > + - allwinner,sun8i-v3-pinctrl > + - allwinner,sun8i-v3s-pinctrl > + - allwinner,sun9i-a80-r-pinctrl > + - allwinner,sun50i-h6-r-pinctrl > + > + then: > + properties: > + interrupts: > + minItems: 2 > + maxItems: 2 > + > + else: > + properties: > + interrupts: > + minItems: 1 > + maxItems: 1 > > additionalProperties: false > > -- > 1.9.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel