From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBC67C433E2 for ; Tue, 14 Jul 2020 02:32:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C585207D4 for ; Tue, 14 Jul 2020 02:32:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xxIbvOIw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C585207D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8qien96oEJ1RC+ed+g6GoyprIh90w504XLgsJnmnebU=; b=xxIbvOIwG7gN5UKboFb+FmfVB AY5KOAhZM0MUpU/N9jT/pHbNb8862eCypGYpqsx23HqH05YKOZJAwpvvTmZOYFIhz6duBLTvio5wg wU8flWy04iNpLgCdbTLBmRFLCNgWGayKqx52W93bFt1BCKCidZWrvdny2EkUSnHuGH13Yo+NMQMfK DBGglDMNqJRBTBStAi80eHEgwDQ/2k0Bg68lQPWVTrwFxOB90cKD0mN641orwg+6cG/BhO6vA6yrr O5KvPOnnZzLbPxS+XLAXVs8GsTHUoASEOlmBDNi7GyCZLXhMUoOFG7/8W6yV9mCBZZbN018qjUaGo kCIaSEIUQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvAic-0001jL-Io; Tue, 14 Jul 2020 02:30:54 +0000 Received: from mail-il1-f196.google.com ([209.85.166.196]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvAia-0001iv-By for linux-arm-kernel@lists.infradead.org; Tue, 14 Jul 2020 02:30:53 +0000 Received: by mail-il1-f196.google.com with SMTP id e18so12976972ilr.7 for ; Mon, 13 Jul 2020 19:30:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PIQmxPiwEmBfrqbUBFZETE9PAgGB7RmQQ0RmEk0XV2o=; b=E3doChlxZr7lsxuM2UChneBn9wXwz6ESMFDNBlJvFgSkO6z1rL/VXn/jg12qNBk62F TyUsS9UGza8GtQcVfJE8A1Q/lX4RKUvTTTGwQUPRNo9IfpeIiwuI/Sx1tVFpT2BFawAU QPOw1mCNv4+VqAeXGSzqoZ6VbnlYImpFMuAQiMCL6NOW7+8EJ3wvsOogsCcmo5RGzwoz NZ+tH43dB4PCxeSE8WnnmyWY/txTbuVaBL9HtI4Xa6NKkdbzX617E8lk9NEdZOppK2tp L1YRqH0fShJ72AA29jNqFEsL4lBvtXIykJKlqfQ++i7s54Ky+VsN6fWUWDxpOoRlgpUH bxdQ== X-Gm-Message-State: AOAM532uRSKrAzMaQMxTCwnxyEATzmjxYAesBh/83oYXnfz5JtnYIQPp UzpB94rAoC7XD2ecMnU97A== X-Google-Smtp-Source: ABdhPJxXsnuwtyRrz+snuTSfJAc/5Y1nlNxsR/FuJxzhcyWKWH7prPgt9D2+OmHoYyG5esy2UjixSg== X-Received: by 2002:a05:6e02:f85:: with SMTP id v5mr2688806ilo.31.1594693851894; Mon, 13 Jul 2020 19:30:51 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id b2sm9386188ilf.0.2020.07.13.19.30.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 19:30:51 -0700 (PDT) Received: (nullmailer pid 1161968 invoked by uid 1000); Tue, 14 Jul 2020 02:30:48 -0000 Date: Mon, 13 Jul 2020 20:30:48 -0600 From: Rob Herring To: Wolfram Sang Subject: Re: [PATCH v2 3/4] dt-bindings: i2c-stm32: add SMBus Alert bindings Message-ID: <20200714023048.GA1151665@bogus> References: <1593070769-9106-1-git-send-email-alain.volmat@st.com> <1593070769-9106-4-git-send-email-alain.volmat@st.com> <20200630194107.GA999@ninjato> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200630194107.GA999@ninjato> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200713_223052_448160_193F0600 X-CRM114-Status: GOOD ( 19.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alexandre.torgue@st.com, linux-kernel@vger.kernel.org, pierre-yves.mordret@st.com, Alain Volmat , linux-i2c@vger.kernel.org, mcoquelin.stm32@gmail.com, fabrice.gasnier@st.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 30, 2020 at 09:41:07PM +0200, Wolfram Sang wrote: > On Thu, Jun 25, 2020 at 09:39:28AM +0200, Alain Volmat wrote: > > Add a new binding of the i2c-stm32f7 driver to enable the handling > > of the SMBUS-Alert. > > > > The I2C/SMBUS framework already provides a mechanism to enable SMBus-Alert > > by naming an IRQ line "smbus_alert". However, on stm32, the SMBus-Alert is > > part of the i2c IRQ. Using the smbus_alert naming here would lead to having > > 2 handlers (the handler of the driver and the smbus_alert handler > > from I2C/SMBUS framework) on the unique i2c IRQ of the stm32. Meaning that > > the smbus_alert handler would get called for all IRQ generated by the stm32 > > I2C controller. > > > > For that reason, the smbus_alert IRQ naming cannot be used and a dedicated > > binding is introduced. > > What if we update the core to not register another irq handler if the > "smbus_alert" and main irq are the same? > > I think it could work. However, while trying to make a proof-of-concept, > I found that irq descriptions in the generic i2c binding document are > probably mixed up. And before fixing that, I'd like to get HostNotify > done first. Why does this even need to be in DT? Can't the driver just register that it supports SMBus alert or have some call to the core signaling an SMBus alert? Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel