From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2881C433E0 for ; Fri, 17 Jul 2020 08:37:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE00F20578 for ; Fri, 17 Jul 2020 08:37:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OtHKOaOz"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Jpru/62U" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE00F20578 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XS//+6GkM1SSHkAntaXw7DK34W3J0mDAhu44XfOwNi8=; b=OtHKOaOzS9YHBy7WJq5Pn2OY4 S1MfkH0KcP973+2mCxMXUDrZ2aml5oIoyRXCHRDPCSxiY3h4yvY3rG+C/vOM5DZRd10D468ZNSNp9 YdmSZirYwGBwV3mB7pETQy9oKDG5VIvx++Jqwq9qfj+/DWk4jR5aapJgpurZaagCD/P5DbTSPQK05 s8m8j5ZguRlAKndo02NwW5/dr2JfjpSqhT4g20b321lnsqqWYMrGlKcxBwTyL0aKIANVh1zBvhFc/ 5qTOG7OGP4uFq8N065xIenYrWiA2ht8FCN577PwISrTp7AcG6VLhgi4z7QnnkDMovsqGUzya8DrnV Yx555Rkdg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwLqx-0006u3-Kw; Fri, 17 Jul 2020 08:36:23 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwLqq-0006rg-Q9 for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 08:36:17 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ACE8820578; Fri, 17 Jul 2020 08:36:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594974975; bh=oZq7Fbz2TiMvKHe/JBvvtXTy/iMy1j03VTqamEx6+uY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Jpru/62UBNss/0vd6CA4dag6ysIfD42h6V8SYYF9qGsSWt2ofAx9oRkx4viT8yRYo Y6Um5luBQjY9SE4jYnOd+yPmK8iEGn/VZKctod7P9KE6WnlkhHxGkJzm26CIwve2+z T4CnhIma70WB23k2ovEQycWQ2dBwidbQqrHxmJiU= Date: Fri, 17 Jul 2020 09:36:09 +0100 From: Will Deacon To: Anshuman Khandual Subject: Re: [PATCH v3] mm/hugetlb: split hugetlb_cma in nodes with memory Message-ID: <20200717083608.GA8293@willie-the-truck> References: <20200710120950.37716-1-song.bao.hua@hisilicon.com> <359ea1d0-b1fd-d09f-d28a-a44655834277@oracle.com> <20200715081822.GA5683@willie-the-truck> <5724f1f8-63a6-ee0f-018c-06fb259b6290@oracle.com> <20200716081243.GA6561@willie-the-truck> <81103d30-f4fd-8807-03f9-d131da5097bd@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <81103d30-f4fd-8807-03f9-d131da5097bd@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_043617_002198_DA25A3FA X-CRM114-Status: GOOD ( 17.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Barry Song , "H.Peter Anvin" , akpm@linux-foundation.org, Catalin Marinas , x86@kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, linux-mm@kvack.org, Ingo Molnar , Borislav Petkov , Jonathan Cameron , Thomas Gleixner , Mike Rapoport , Roman Gushchin , linux-arm-kernel@lists.infradead.org, Mike Kravetz Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 17, 2020 at 10:32:53AM +0530, Anshuman Khandual wrote: > > > On 07/16/2020 11:55 PM, Mike Kravetz wrote: > >>From 17c8f37afbf42fe7412e6eebb3619c6e0b7e1c3c Mon Sep 17 00:00:00 2001 > > From: Mike Kravetz > > Date: Tue, 14 Jul 2020 15:54:46 -0700 > > Subject: [PATCH] hugetlb: move cma reservation to code setting up gigantic > > hstate > > > > Instead of calling hugetlb_cma_reserve() directly from arch specific > > code, call from hugetlb_add_hstate when adding a gigantic hstate. > > hugetlb_add_hstate is either called from arch specific huge page setup, > > or as the result of hugetlb command line processing. In either case, > > this is late enough in the init process that all numa memory information > > should be initialized. And, it is early enough to still use early > > memory allocator. > > This assumes that hugetlb_add_hstate() is called from the arch code at > the right point in time for the generic HugeTLB to do the required CMA > reservation which is not ideal. I guess it must have been a reason why > CMA reservation should always called by the platform code which knows > the boot sequence timing better. Ha, except we've moved it around two or three times already in the last month or so, so I'd say we don't have a clue when to call it in the arch code. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel