From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C417DC433E1 for ; Sat, 18 Jul 2020 15:42:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 92BC82073A for ; Sat, 18 Jul 2020 15:42:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bive8Mpn"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="vhDKfOeA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 92BC82073A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=v/8oj5JxRVihkcnatJP37eM/GIeCzWkejCsBbhVqIto=; b=bive8Mpn7VCiyCLApfg1GrY6F Xkoe4GstJmL+sIbCQyLutXh3FZqBvDpTh8oe3kYU2MqRS+hko0TU48w8oqep9pPIo3JmiRu/jW0OM HBbKye37fM45ZU0KEIAboScKumDSbq3KRllllZUgrnj1o1wqMbGUPt3g4c6IyR52KtV4poMoi/XcV ctwGi3kV5i/pln/5kC6l20RbyY8HppasIdd05O11BfSt9Vgqi9xVY+71DPHeYpSD5eMFUXHeoyphq 2UVLWvLu9C7ioi+tfdj5/U6ge2rgbhrt7hlp3y4MWU8POU7+kaqIHzVVB+G9NARXVsEmHTFf83H30 oA0ELur6Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwoxd-0006hx-G3; Sat, 18 Jul 2020 15:41:13 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwoxb-0006hG-Ol for linux-arm-kernel@lists.infradead.org; Sat, 18 Jul 2020 15:41:12 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5658920734; Sat, 18 Jul 2020 15:41:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595086871; bh=gRMgGwf57TpWPzv7Fbg6pSq51jgQkkjsG4BSEsJTtiY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vhDKfOeAWLe7UDWWcA5aD5lJ/VBnc9BydNt3VYm9OIhzCnGxATwCWVwx8aYxE37X3 CatwSYJfcNL2pmKQtMJTftAS+nrL6BurvAaApoKVF6oXL/ZndRLeCU/i0Czf6m0wIt ++w4xCYAHFneoj3m0+gONsZfOlTTd9vJ+1Wrq7lg= Date: Sat, 18 Jul 2020 16:41:06 +0100 From: Jonathan Cameron To: Lee Jones Subject: Re: [PATCH 08/30] iio: resolver: ad2s1200: Change ordering of compiler attribute macro Message-ID: <20200718164106.5e57f276@archlinux> In-Reply-To: <20200717165538.3275050-9-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> <20200717165538.3275050-9-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200718_114111_884599_7095357F X-CRM114-Status: GOOD ( 15.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Graff Yang , lars@metafoo.de, Michael Hennerich , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org, David Veenstra Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 17 Jul 2020 17:55:16 +0100 Lee Jones wrote: > Kerneldoc gets confused if the variable does not follow the > type/attribute definitions. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/resolver/ad2s1200.c:44: warning: Function parameter or member '____cacheline_aligned' not described in 'ad2s1200_state' > > Cc: Michael Hennerich > Cc: David Veenstra > Cc: Graff Yang > Signed-off-by: Lee Jones Holding this for now whilst we discuss whether to just fix it in the kernel-doc script. J > --- > drivers/iio/resolver/ad2s1200.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/resolver/ad2s1200.c b/drivers/iio/resolver/ad2s1200.c > index a391f46ee06b7..29cfd57eff9e7 100644 > --- a/drivers/iio/resolver/ad2s1200.c > +++ b/drivers/iio/resolver/ad2s1200.c > @@ -40,7 +40,7 @@ struct ad2s1200_state { > struct spi_device *sdev; > struct gpio_desc *sample; > struct gpio_desc *rdvel; > - __be16 rx ____cacheline_aligned; > + __be16 ____cacheline_aligned rx; > }; > > static int ad2s1200_read_raw(struct iio_dev *indio_dev, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel