From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C0C8C433E1 for ; Sat, 18 Jul 2020 15:53:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5741E2076A for ; Sat, 18 Jul 2020 15:53:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aw1SDCar"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="otYoOccU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5741E2076A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zh0kpfGhE4jvg4kgqUx503HGU/wgC8aBMlzMfLozYsc=; b=aw1SDCarYSlW0mpO909q72Cap Hx36sG5ezu9AGtz/bUfHB40VswK/ergtRDcsSli9PyWwtx1501nvK17kvOfe07cfIedich4zQt2B/ /AFSH8GJm2b4SL5ltKQ35SNFCOoZoa2Sjp6YW5T+0T6hPh46AE3cXXU0w5KXui5FliuGuZWBtNYgZ a1utGKq6iU+krNQ/xxCM64YMGATjksOjLcYlu6Dkr8CrODPy6Au67+Wurknk1rEbMJ+p0uZQkaoUe wjTgPNRNFzDQ4yVmkISArgw64g5ypXtiySojzlMOysRbPSdcvS4qNPXWQNGZk3Yltc5gZoP4o6nsS uLfW2ewoQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwp8V-0000WT-92; Sat, 18 Jul 2020 15:52:27 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwp8T-0000VU-3w for linux-arm-kernel@lists.infradead.org; Sat, 18 Jul 2020 15:52:25 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E79C72076A; Sat, 18 Jul 2020 15:52:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595087544; bh=ig+qNnytQc4w1Ina0WQwcxtbbNuRzlveqifsUneeQDo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=otYoOccUuPJLWT/gIXQIoXlmVD8BJDcd5WrUYtF6n1uUOiC+Dmjbp31ySO/rWuOzz +UisCM8f9d7rjIMuyWj1CWyGc7pQ4EckOhDKZcq5ox8M0koUBLgXr+ZIZb6D5Vzi1s VLlD3u9lhpcmwk8HIbnLJYOOQQ5uw0LPqk6VFQkU= Date: Sat, 18 Jul 2020 16:52:19 +0100 From: Jonathan Cameron To: Lee Jones Subject: Re: [PATCH 17/30] iio: gyro: adxrs450: Change ordering of compiler attribute macro Message-ID: <20200718165219.318398a1@archlinux> In-Reply-To: <20200717165538.3275050-18-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> <20200717165538.3275050-18-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200718_115225_283279_8F686106 X-CRM114-Status: GOOD ( 16.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lars@metafoo.de, Michael Hennerich , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 17 Jul 2020 17:55:25 +0100 Lee Jones wrote: > Kerneldoc gets confused if the variable does not follow the > type/attribute definitions. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/gyro/adxrs450.c:79: warning: Function parameter or member '____cacheline_aligned' not described in 'adxrs450_state' > > Cc: Michael Hennerich > Signed-off-by: Lee Jones Holding this one for the conversation about whether we should be fixing the code or the tool. Thanks, Jonathan > --- > drivers/iio/gyro/adxrs450.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/gyro/adxrs450.c b/drivers/iio/gyro/adxrs450.c > index b00c0eb442493..e00b97e30cf9d 100644 > --- a/drivers/iio/gyro/adxrs450.c > +++ b/drivers/iio/gyro/adxrs450.c > @@ -73,7 +73,7 @@ enum { > struct adxrs450_state { > struct spi_device *us; > struct mutex buf_lock; > - __be32 tx ____cacheline_aligned; > + __be32 ____cacheline_aligned tx; > __be32 rx; > > }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel