From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AFEAC433E1 for ; Sat, 18 Jul 2020 15:57:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CAC5B2076A for ; Sat, 18 Jul 2020 15:57:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V1++mSvB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="lsA3oc2W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAC5B2076A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=02VBG46BKHjKSigR5L7RgpUM2H1VG+bUOHR624qR+uA=; b=V1++mSvBfiB0th04sh4XzM0MR Kh6lmiEgyy5aN8Anb/V3Sx6BOgOg3UPy6yvlQPtmEQr+Gin0eDMk6hG1Gxwq77FhPw9WpuuuTniJ3 8EP3t3316CxztSbKCcQHfBuJbJO41zdEMMFh+0LvQZdhArmtqs5cVhaBwuG1sp6RaOZA6jPvpUoAy rNpzVT6bbnF4eGwfVGkd9OVfhUw2yk8Hrnpf/gTKoCkjw4YSkraVMck26/th5xSYM9kNxfnyko3S2 i83KOsV5BEbmDZP4+3nUeMrpEZEjHmDEQRrHUkC7Gt1GiJEyLV7bbkwV/F3LdPf5cXccjtRWC2WVS 9HrZLgqYA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwpC8-0001Kx-QI; Sat, 18 Jul 2020 15:56:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwpC5-0001Jp-92 for linux-arm-kernel@lists.infradead.org; Sat, 18 Jul 2020 15:56:10 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CEF032076A; Sat, 18 Jul 2020 15:56:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595087768; bh=aNUn0ufeItAoFwIvQWSUKYizVdAeSsHrPyXQ2ezbtSg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lsA3oc2Wrq8Xq4ncIYgzaipHTuM3059XTdvvBIEWOekAmag1fCP7pJGoY2P2eGLwT eAfO1sV2YMWGUjTHcx/7Fs9QJ4Nm5VLKmQG0eEoBJXE72GEwarjhq59sy7tYjP9UFH JU/YUwi858YYmVM2FaDmkfZ+EQyTylQ1n1Y4hGho= Date: Sat, 18 Jul 2020 16:56:04 +0100 From: Jonathan Cameron To: Lee Jones Subject: Re: [PATCH 20/30] iio: adc: max1363: Fix kerneldoc attribute formatting for 'lock' Message-ID: <20200718165604.4f7f8feb@archlinux> In-Reply-To: <20200717165538.3275050-21-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> <20200717165538.3275050-21-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200718_115609_393712_20F8D05B X-CRM114-Status: GOOD ( 16.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lars@metafoo.de, Rohit Sarkar , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Liam Girdwood , Mark Brown , pmeerw@pmeerw.net, knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 17 Jul 2020 17:55:28 +0100 Lee Jones wrote: > Kerneldoc expects attributes/parameters to be in '@*.: ' format. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/adc/max1363.c:190: warning: Function parameter or member 'lock' not described in 'max1363_state' > > Cc: Liam Girdwood > Cc: Mark Brown > Cc: Rohit Sarkar > Signed-off-by: Lee Jones Given the age of this driver, I suspect that this is the source of all the cut and paste. Oops. Applied, Jonathan > --- > drivers/iio/adc/max1363.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c > index 9d92017c79b2d..0fe348a47fe01 100644 > --- a/drivers/iio/adc/max1363.c > +++ b/drivers/iio/adc/max1363.c > @@ -150,7 +150,7 @@ struct max1363_chip_info { > * @current_mode: the scan mode of this chip > * @requestedmask: a valid requested set of channels > * @reg: supply regulator > - * @lock lock to ensure state is consistent > + * @lock: lock to ensure state is consistent > * @monitor_on: whether monitor mode is enabled > * @monitor_speed: parameter corresponding to device monitor speed setting > * @mask_high: bitmask for enabled high thresholds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel