From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18F48C433E1 for ; Sat, 18 Jul 2020 16:01:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC6D62070E for ; Sat, 18 Jul 2020 16:01:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="itWLuTHL"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="vr9spAtT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC6D62070E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2J6oIfxh/Zks3nvFHb5DkXdYfKsScqlzI3T1gNn+UWo=; b=itWLuTHLeV8dHh+icAHCcHMWF eyAa6m1pgUnIGLHKUNhVdPPyQYA4baW02oyKwza5OQgAXCIpYuoo8UAFejkdAo4fPH7Ov/AyZDKHo tGZSCkWQORffnXha1e/2z8Iiku+0ci3AuV6j8jyhRYht5I53Sb3gPpJXe3vGWWB2XiPatWqwPgaRD GqyU6rBdgAGcIeB8EFoN2uusRyLgQbQn1MqOWxijMz4lD+CrhJTOssaeEskz4M96l5UBp1A+3q43h a+2xrUfV2gpuHktxpQNEJwzcGHwvtTWQ4Q/FZQVaCeKYYkXG594iFD46yjg4qkALRf/7kreDHATOe ZI9fN/Y7A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwpGT-0002E5-5Z; Sat, 18 Jul 2020 16:00:41 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwpGQ-0002Cu-HI for linux-arm-kernel@lists.infradead.org; Sat, 18 Jul 2020 16:00:39 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2641D2070E; Sat, 18 Jul 2020 16:00:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595088037; bh=QRRTW3VgCAydzJZpqZ+JaipKjgR0sd4k2PtilOz4w6s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vr9spAtTKWdT+ZRAGLTXtyMB8Ml5JO/jhsNtgRmxYTUyiUZN7jz3foqXiTfhvPhCX 7SK2vFzAsFavHzgviFEpld7UwzJqa/Ge3N1zxw5BhPQieFUSEu/GDB7G1/o2g1CBc+ KS9c4kkdEVwGR/PxyCWH2ShdFHo/kGZI0xI//ptM= Date: Sat, 18 Jul 2020 17:00:33 +0100 From: Jonathan Cameron To: Lee Jones Subject: Re: [PATCH 22/30] iio: adc: mcp320x: Change ordering of compiler attribute macro Message-ID: <20200718170033.751130a7@archlinux> In-Reply-To: <20200717165538.3275050-23-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> <20200717165538.3275050-23-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200718_120038_652218_DB093A1C X-CRM114-Status: GOOD ( 14.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Oskar Andero , lars@metafoo.de, Bendorff Jensen , Soren Andersen , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 17 Jul 2020 17:55:30 +0100 Lee Jones wrote: > Kerneldoc gets confused if the variable does not follow th > type/attribute definitions. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/adc/mcp320x.c:96: warning: Function parameter or member '____cacheline_aligned' not described in 'mcp320x' > > Cc: Oskar Andero > Cc: Bendorff Jensen > Cc: Soren Andersen > Signed-off-by: Lee Jones Holding this one whilst we discuss the right fix for this sort of issue. J > --- > drivers/iio/adc/mcp320x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/mcp320x.c b/drivers/iio/adc/mcp320x.c > index 2c0eb5de110ca..191a8f644ffe7 100644 > --- a/drivers/iio/adc/mcp320x.c > +++ b/drivers/iio/adc/mcp320x.c > @@ -91,7 +91,7 @@ struct mcp320x { > struct mutex lock; > const struct mcp320x_chip_info *chip_info; > > - u8 tx_buf ____cacheline_aligned; > + u8 ____cacheline_aligned tx_buf; > u8 rx_buf[4]; > }; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel