From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C941DC433F4 for ; Mon, 20 Jul 2020 15:40:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 989E320773 for ; Mon, 20 Jul 2020 15:40:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oWxEKdXk"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gTsf2Eu9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 989E320773 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sZlUNnQnNa0qjQ9e52h2z5IjB+jEp385sjo66jCM7bg=; b=oWxEKdXkrijXp1nUXdOPh5ByT ibghmw7VJ9dY7CWWHDBl8f8V9XXSdHmGGkRknT5dTU5wIxNMadfL6nWhrnoDdZRnmfczv1unyTLeT 6uEfb+19nTNJ/JbS3NySi63HW2p+szuQInaNl5p8ijL1UIMdIsbZgWLLlop0p5GaNxKhmPvcxb5QU 9R7K8aNKzEDwct6vgn5drVaeZxXLDWex/GE1usZXtnRnoxAxlcAwo+UCnE8VJ2C40W4WfwKH2EzSd WigAoD1nctt/IuRbxOIkf+qhUvu7Zu0kAvgVNuSG0rifvMdoCMhPSPZQwrNI3WVq/7A8Nwiht3evn eggukKL2g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxXsw-0002EX-N2; Mon, 20 Jul 2020 15:39:22 +0000 Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxXsu-0002Db-1E for linux-arm-kernel@lists.infradead.org; Mon, 20 Jul 2020 15:39:20 +0000 Received: by mail-ed1-x543.google.com with SMTP id dm19so13088294edb.13 for ; Mon, 20 Jul 2020 08:39:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=O1m2EB0FT01ShtO2OJYn83yl6fCn52T14VBuz91LAgY=; b=gTsf2Eu9v/AafVNzi8ISPXGS0FQo13KbdhYVlAJnIirPGLFMl1wNXN7duONqOpEnuO gC8PikvMwSRdHZ3vjv6yjp2OXj5qXh+QQeht092lrBxZnf3Zue4XKi4/9OXtgTak601Q EHbsYozyYp6MgFlFZ2NplcgmGvsJSrTfqeioTi87P40imTRwdBB5+EZ9+HFQgCTZP+TK 8z9JL0GLMRIuFioi/oYqFiuLmqSsGKLIXUUvtGIRTVvM0bINkFuNBLSrtw5JPk2YH0DK X0lJwvz9AqruBCURNDeSl+f3hY0ODUbghng3qJXPq5XHKxWqTLmBn1J16hd1QiI/l9vM Zk+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=O1m2EB0FT01ShtO2OJYn83yl6fCn52T14VBuz91LAgY=; b=CPONxBVK83o4YDhAzH58AW4PYVYux/2jMh0vLnJYeGtHV1D/PamHqAu0TzJ965NJEr kJaKxbvB5jBi/HyMoWNTXc6VNvIH4FDWjy9pz9XQLaPEFbtaYMN/8/2REFkv2pVyfULk hsW+yGxg/Nnh782ZBT+p0j+XnjncRI/uLfFlOmNG1ZAe6XJoHlZBT+T3X5YvkUq/US8i uKI4HjJ/nnhAL56BaxbFeJNSndEHu8kiA77LMxX+W+HO9VI3IqhAx6ZdIM1WaXT6gX72 +VSqvcTklMvs9y30IcBMgLR1JS47fbzl+b9qh8dlvPUv2j3GuTpZYEKQUuFjQiwqoNyu jCfQ== X-Gm-Message-State: AOAM531PPE5BrE/7YzBbQ9BWFUfx0DElnmkwGuMiVxfC23fWm1ie/KAn A9+iK/uKDV+e2SUxMk2MtCtj0g== X-Google-Smtp-Source: ABdhPJzlqzOX/v1sKgRJpL3kwuSO3RJqWfM8YDYvHQ2Ix65qY4Cg2pVEcPglA2Qw4qvDhW3c/p8OzA== X-Received: by 2002:a50:e047:: with SMTP id g7mr21320084edl.290.1595259557047; Mon, 20 Jul 2020 08:39:17 -0700 (PDT) Received: from myrica ([2001:1715:4e26:a7e0:116c:c27a:3e7f:5eaf]) by smtp.gmail.com with ESMTPSA id j21sm15654882edq.20.2020.07.20.08.39.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2020 08:39:16 -0700 (PDT) Date: Mon, 20 Jul 2020 17:39:03 +0200 From: Jean-Philippe Brucker To: Will Deacon Subject: Re: [PATCH v8 00/12] iommu: Shared Virtual Addressing for SMMUv3 (PT sharing part) Message-ID: <20200720153903.GA328334@myrica> References: <20200618155125.1548969-1-jean-philippe@linaro.org> <20200720111116.GE11516@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200720111116.GE11516@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200720_113920_135796_C542ED67 X-CRM114-Status: GOOD ( 23.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fenghua.yu@intel.com, jacob.jun.pan@linux.intel.com, catalin.marinas@arm.com, joro@8bytes.org, zhengxiang9@huawei.com, hch@infradead.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Jonathan.Cameron@huawei.com, zhangfei.gao@linaro.org, robin.murphy@arm.com, xuzaibo@huawei.com, linux-arm-kernel@lists.infradead.org, baolu.lu@linux.intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 20, 2020 at 12:11:17PM +0100, Will Deacon wrote: > On Thu, Jun 18, 2020 at 05:51:13PM +0200, Jean-Philippe Brucker wrote: > > Since v7 [1], I split the series into three parts to ease review. This > > first one adds page table sharing to the SMMUv3 driver. The second one > > adds support for I/O page faults through PRI and Stall, and the last one > > adds additional and optional features (DVM, VHE and HTTU). SVA needs the > > three parts to work. No significant change apart from that, I just > > addressed the previous comments. > > > > I'd rather everything went through the IOMMU tree but I'm assuming patch > > 1 will also go through the x86 tree as part of [2]. It is definitely > > required by patch 3 which is required by patch 11. I don't know how this > > kind of conflict is usually resolved, but if it's a problem I could > > further shrink the series to only patches 4-10 this cycle. > > Modulo my review comments, I think most of this looks alright from the SMMU > side. However, I would really like it if the SVA driver parts could be moved > into a separate file (e.g. arm-smmu-v3-sva.c), with a separate config option > (dependent on the current one, so you can easily build a driver without SVA > support). Does that sound remotely feasible? Yes it makes sense. It requires moving some definitions from arm-smmu-v3.c to a .h but should be straightforward, I'll give it a try. Thanks, Jean > If so, I think it would really > help in terms of maintainability, since the SVA model is really all about > the mm, whereas the driver model is all about the device. This makes it > really hard to read when you have to keep working out whether the current > 'handle' is an mm_struct or an arm_smmu_device. > > Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel