From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04B74C433E1 for ; Wed, 22 Jul 2020 18:05:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C8749207DD for ; Wed, 22 Jul 2020 18:05:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IO6wu3mf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XMpS/yfU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8749207DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sHrYyKberc3hh4p4gz70KFEiNxo8u5NPnkQ0kMTHJiw=; b=IO6wu3mfhDsz7BShQMMIBFmam Z+ZLw3xS60Q0jJSC8b8TTBoGBPYs9mQD5L8qxefT1dLq1v6j4UUMUUVcp6gZLOVDoMXzvh5ZgwwjO 1nK8bbkHOQHDaTMIKjPh+VEI2P8vk+vrZc39Ob9tegT7p7Tux6wu76dzcTYbd6VgN+/hXvWqVTcvn avHRJS+bKzGQzUuUu0/28nzdHzMw1ze9BwcwBc4dlFx8NSf8cXcP4nnTaNyEPsh58M77M1JjexdJv EtwnNxn0g8linEij8EvLJU67mrcPHiKrsc4NTNjmrHhTdk/E7oTfQpLIH4LV6b6mGcEEN9xxxzhgO 1EU5dQDBw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyJ5g-0005V8-Iv; Wed, 22 Jul 2020 18:03:40 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyJ5d-0005UD-A4 for linux-arm-kernel@lists.infradead.org; Wed, 22 Jul 2020 18:03:38 +0000 Received: by mail-pg1-x541.google.com with SMTP id m22so1699146pgv.9 for ; Wed, 22 Jul 2020 11:03:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yWcfktADb3uPJbFkIiNC/fq9uZOsRANKyg7Yhrbd3tg=; b=XMpS/yfUE5QvKTqgqHXr498QBJt1LtXUBTlBwABMTYg0Endz9kTZGsNVoItzCCJ8JZ kBCM5saOtYxBLzG65jr1vE+X4/UzMu73f/A1NH+keySUjedHG6c6BI2LlBufsNrhATxN bVH3baDqsU8Nh8OwoeDBGNIQ54aggROKqB9px+29u7Cy+lea4Oy56Z/axz1FhQ42Fgvq +7ca24D4Qcfr83XGHgalFULZ9om5Fbfwf3QHAIAJB1cGJtn2M8oicM3DTaYflPkkDvWA ClceWQu4Ql4Ons+Ct9bcqc602uKrNDtogEo0tlJaIvxjU9ZCUCDBz6Fkpmw0a+exYJUm FN7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yWcfktADb3uPJbFkIiNC/fq9uZOsRANKyg7Yhrbd3tg=; b=aijPXFuzv4C0rEVqXZZ8XaS6tLYWbFIhrFJPPPyF+UpEYL7yxw0clSrBGV59b8AO9o ey1fXHeconU74828AoUKLF9wx2GDp2YArgPmUdKUrC4UiSLDg4Wq+7N4KSbhhkxanzPB qSq9LW4zUVQbZyuLGAlQZBUbNgzIF+Z4ERPqbFDHGKrpQl654aV6SlOryUa/PYM6plxS cqtthUD1diRSO1LjbSNZizZlz5gsua24+z1c88X6u2dNOlRXKjOxFTxXMwLr4FgmSdNR kbXM5ibGVvb0nGHgiJwmxswkkcB+4xrqQd5dj8SqVmzoYQgsCVUIQqnzypIjNnW/EBuF uwUQ== X-Gm-Message-State: AOAM530iTeyGHEpDN9+mGWTO/fUqhS92tUO2g+Mmp4aGp10P5wQV9y9I 1RzaQOwai3tBMOJvQzUunUR0uA== X-Google-Smtp-Source: ABdhPJw4CCh/JqUryfanhVXNO34PrKWEi7bBLUJ8EKXba3fX0MsU9Wcj2adh+VkHowSyvD3Dk78D3Q== X-Received: by 2002:a63:c509:: with SMTP id f9mr920841pgd.144.1595441012822; Wed, 22 Jul 2020 11:03:32 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id w9sm341994pja.39.2020.07.22.11.03.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2020 11:03:32 -0700 (PDT) Date: Wed, 22 Jul 2020 11:01:39 -0700 From: Bjorn Andersson To: Mathieu Poirier Subject: Re: [PATCH v4 1/2] remoteproc: Add remoteproc character device interface Message-ID: <20200722180139.GA3700915@builder.lan> References: <1594148870-27276-1-git-send-email-sidgup@codeaurora.org> <1594148870-27276-2-git-send-email-sidgup@codeaurora.org> <20200715201839.GA3204081@xps15> <20200715215149.GA3267350@xps15> <81d7514c-727e-b4dc-e4ac-74a25966ccaf@codeaurora.org> <20200721205635.GM2922385@builder.lan> <20200722171841.GA1268891@xps15> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200722171841.GA1268891@xps15> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200722_140337_364920_343F62C6 X-CRM114-Status: GOOD ( 38.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ohad@wizery.com, tsoni@codeaurora.org, corbet@lwn.net, linux-arm-msm@vger.kernel.org, linux-doc@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, agross@kernel.org, rishabhb@codeaurora.org, Siddharth Gupta , psodagud@codeaurora.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed 22 Jul 10:18 PDT 2020, Mathieu Poirier wrote: > On Tue, Jul 21, 2020 at 01:56:35PM -0700, Bjorn Andersson wrote: > > On Tue 21 Jul 12:16 PDT 2020, Siddharth Gupta wrote: > > > On 7/15/2020 2:51 PM, Mathieu Poirier wrote: > > > > On Wed, Jul 15, 2020 at 02:18:39PM -0600, Mathieu Poirier wrote: > > > > > On Tue, Jul 07, 2020 at 12:07:49PM -0700, Siddharth Gupta wrote: > > [..] > > > > > > diff --git a/drivers/remoteproc/remoteproc_cdev.c b/drivers/remoteproc/remoteproc_cdev.c > > [..] > > > > > > +int rproc_char_device_add(struct rproc *rproc) > > > > > > +{ > > > > > > + int ret; > > > > > > + dev_t cdevt; > > > > > > + > > > > > > + cdev_init(&rproc->char_dev, &rproc_fops); > > > > > > + rproc->char_dev.owner = THIS_MODULE; > > > > > > + > > > > > > + cdevt = MKDEV(rproc_major, rproc->index); > > > > > > + ret = cdev_add(&rproc->char_dev, cdevt, 1); > > > > Trying this patchset on my side gave me the following splat[1]. After finding > > > > the root case I can't understand how you haven't see it on your side when you > > > > tested the feature. > > > > > > > > [1]. https://pastebin.com/aYTUUCdQ > > > > Mathieu, I've looked at this back and forth. Afaict this implies that > > rproc_major is still 0. Could it be that either alloc_chrdev_region() > > failed or somehow has yet to be called when you hit this point? > > That is exacly what I thought when I first stumbled on this but instrumenting > the code showed otherwise. > > After function rproc_init_cdev() has been called @rproc_major contains the > dynamically allocated major number in the upper 12 bits and the base minor > number in the lower 20 bits. > Ahh, alloc_chrdev_region() actually returns the dev_t, not the major. Too bad that we all name this variable "major" to maximize the confusion. > In rproc_char_device_add() we find this line: > > cdevt = MKDEV(rproc_major, rproc->index); > > Macro MKDEV() builds a device number by shifting @rproc_major by 20 bits to the > left and OR'ing that with @rproc->index. But the device's major number is > already occupying the upper 12bits, so shifthing another 20 bits to the left > makes the major portion of the device number '0'. That is causing cdev_add() to > complain bitterly. > > The right way to do this is: > > cdevt = MKDEV(MAJOR(rproc_major), rproc->index); > Agreed (and let's continue naming it rproc_major, in line with all other drivers - now I know better). Thanks, Bjorn > Once I found the problem I thought about 32/64 bit issues. Since Siddharth is > using a 64bit application processor shifting another 20 bits would still have > yielded a non-zero value. But that can't be since dev_t is a u32 in > linux/types.h. > > As such I can't see how it is possible to not hit that problem on a 64bit > platform. > > > > > > Hey Mathieu, > > > > > > We aren't able to reproduce the error that you are seeing, the splat is > > > coming > > > from the check for whiteout device[1] - which shouldn't happen because of > > > the > > > find_dynamic_major call[2], right? > > > > > > We are successfully seeing all our character device files and able to > > > successfully boot remoteprocs. From what I read and understood about > > > whiteout > > > devices they will be hidden in the fs. > > > > > > Could you provide more details about your configuration and testing? > > > > > > [1]: https://github.com/torvalds/linux/blob/master/fs/char_dev.c#L486 > > > > > > [2]: https://github.com/torvalds/linux/blob/master/fs/char_dev.c#L123 > > > > > > > > > > > > + if (ret < 0) > > > > > > + goto out; > > > > > > + > > > > > > + rproc->dev.devt = cdevt; > > > > > > +out: > > > > > > + return ret; > > > > > > +} > > > > > > + > > > > > > +void rproc_char_device_remove(struct rproc *rproc) > > > > > > +{ > > > > > > + __unregister_chrdev(rproc_major, rproc->index, 1, "remoteproc"); > > > > > > +} > > > > > > + > > > > > > +void __init rproc_init_cdev(void) > > > > > > +{ > > > > > > + int ret; > > > > > > + > > > > > > + ret = alloc_chrdev_region(&rproc_major, 0, NUM_RPROC_DEVICES, "remoteproc"); > > > > > > + if (ret < 0) > > > > > > + pr_err("Failed to alloc rproc_cdev region, err %d\n", ret); > > > > > > +} > > > > > > + > > > > > > +void __exit rproc_exit_cdev(void) > > > > > > +{ > > > > > > + unregister_chrdev_region(MKDEV(rproc_major, 0), NUM_RPROC_DEVICES); > > > > > Please go back to the comment I made on this during my last review and respin. > > > > After digging in the code while debugging the above problem, I don't see how > > > > unregistering the chrdev region the way it is done here would have worked. > > > Since this is compiled statically and not built as a module, we will never > > > exercise the code path, so I will remove it in the next patchset. > > > > > > > You're right Siddharth, since we changed CONFIG_REMOTEPROC to bool it's no longer > > possible to hit remoteproc_exit(), so you can omit this function > > entirely. (And we should clean up the rest of that as well) > > > > [..] > > > > > > diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h > > [..] > > > > > > @@ -488,6 +489,8 @@ struct rproc_dump_segment { > > > > > > * @auto_boot: flag to indicate if remote processor should be auto-started > > > > > > * @dump_segments: list of segments in the firmware > > > > > > * @nb_vdev: number of vdev currently handled by rproc > > > > > > + * @char_dev: character device of the rproc > > > > > > + * @cdev_put_on_release: flag to indicate if remoteproc should be shutdown on @char_dev release > > > > > > */ > > > > > > struct rproc { > > > > > > struct list_head node; > > > > > > @@ -523,6 +526,8 @@ struct rproc { > > > > > > int nb_vdev; > > > > > > u8 elf_class; > > > > > > u16 elf_machine; > > > > > > + struct cdev char_dev; > > > > As stated privately, I assumed based on this name that this is a struct > > device related to that character device. So please rename this cdev to > > save me from doing this mistake again. > > > > Thanks, > > Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel