From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30F4FC433DF for ; Thu, 23 Jul 2020 08:57:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF3792071A for ; Thu, 23 Jul 2020 08:57:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XhXI9Kk6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF3792071A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+rEzqiU7BSTONJCOoprxuoflfr7Uy2GxOZJm+DlXal0=; b=XhXI9Kk6fdXK9jWNURZqZUr9h gHs4OuZH/EgVRCjFhftKvz/xQF0I7QU/Vg0b9+ztSV+JoevcEcvZE5lEqCwSzFSM3QJ3psgpCCIy2 qXRrlu9srHRI//80DXrDcFSC0cz+cQ83H6lOUs3Bo/E3B7h+POGSRZMDBausNUDXi7sbhR6xzIHjt LfA/jDKUMcrTPg4Lvs37/Q4uDymuSd/kr4SOK14FdyUXuZMFh+VWbNrw+w6JD5qLna9pNMYG08YZn efSfaK7nZwqOjkvugfMazJdQaeiQxNn/bsv6SGeWyzGjGUVp86OGjmYeUxqaOurtsmE5lEO0HxOt3 1TA88EAAg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyX0v-0008WI-Qf; Thu, 23 Jul 2020 08:55:41 +0000 Received: from mail-ej1-f65.google.com ([209.85.218.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyX0t-0008Vm-Sn; Thu, 23 Jul 2020 08:55:40 +0000 Received: by mail-ej1-f65.google.com with SMTP id l4so5490413ejd.13; Thu, 23 Jul 2020 01:55:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Xt5+vxpGC9nM/ZHsj3r5gI/nmTDmk9F2oBeOZtyGPQM=; b=DoSzAvcVTFWMPkR/JxHdLpoY1zj4J+N+W7xgbIYxRK6c2qanRGlgTMFqwGpj8d4k75 nfDnBpOEj5zdra/+Vr0gu8LMpRIrQvynBwexX4TJ/FZ0q7jD1okemKyWaMKJE8/Dft5x anBaR9iP80em+N8ZnB3tyQi+btIZLZKQnzJ7ngP/60XdeR2vKhowMpQuMuDSOx/sw5tQ dzhw4sYcXr/aE1jqiZocHcf4irOtn/EpRH7UaPH87ph+FYR8o2A25g/EvNUHb8EysX00 i5mvSjSa+IzaM6IkviWvZPv9Tz62+05lvz1BeF51PzrSWSckrdhc3PLugUJK5bFMXXnl 2qTg== X-Gm-Message-State: AOAM530+sr2ZukCKb5WJOZlBOz6r6EGPXYFWPCwznX59NVelYqb+hQ+d k+uPqDJsecaBbh+sDW0vVmU= X-Google-Smtp-Source: ABdhPJwRP+wjzC0Ys2mHygLb4mxZAtf0iTg0JkShIGi/qXx7US6BV7vrg2I5N8csKyuByvVrRm5SwQ== X-Received: by 2002:a17:906:414c:: with SMTP id l12mr3469617ejk.417.1595494536809; Thu, 23 Jul 2020 01:55:36 -0700 (PDT) Received: from kozik-lap ([194.230.155.213]) by smtp.googlemail.com with ESMTPSA id jo25sm1541668ejb.116.2020.07.23.01.55.34 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Jul 2020 01:55:36 -0700 (PDT) Date: Thu, 23 Jul 2020 10:55:33 +0200 From: Krzysztof Kozlowski To: Arnd Bergmann Subject: Re: [PATCH 18/23] memory: mtk-smi: Add argument to function definition Message-ID: <20200723085533.GA25935@kozik-lap> References: <20200723073744.13400-1-krzk@kernel.org> <20200723073744.13400-19-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200723_045539_941340_3D198CF9 X-CRM114-Status: GOOD ( 16.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , List-Id: Cc: Florian Fainelli , "open list:TEGRA ARCHITECTURE SUPPORT" , linux-omap , Tony Lindgren , Greg Kroah-Hartman , "moderated list:ARM/Mediatek SoC..." , "linux-kernel@vger.kernel.org" , Vladimir Zapolskiy , Matthias Brugger , SoC Team , arm-soc , bcm-kernel-feedback-list , Markus Mayer , Santosh Shilimkar , Olof Johansson , Thierry Reding , Andrew Morton , Jonathan Hunter , Linus Torvalds , Linux ARM , Roger Quadros Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 23, 2020 at 10:50:08AM +0200, Arnd Bergmann wrote: > On Thu, Jul 23, 2020 at 9:39 AM Krzysztof Kozlowski wrote: > > > > Fix checkpatch warning: > > WARNING: function definition argument 'struct device *' should also have an identifier name > > > > Signed-off-by: Krzysztof Kozlowski > > Is this a bug in checkpatch? I don't see why it should warn about this, > as there is no function definition here. > > Your change is clearly harmless, but I wonder if we should fix > checkpatch instead. Good point. If this were not a warning, I would ignore it. However still the common practice is to add arguments to such type definitions as it helps to describe the type. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel