From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A79DC433DF for ; Thu, 23 Jul 2020 14:30:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E766C20771 for ; Thu, 23 Jul 2020 14:30:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dnJ/+GuK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="NXnhLWyz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E766C20771 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cgP2UvVYo0c2AhLZxadZ68aR1wUIeel+o1N7pztA0oA=; b=dnJ/+GuK97WNLH1bqSIrs2v+E aMOSaxnu8okomWKcTJtrv2c+pTWmVw8Os58dQFJn8B2K601ZEmCpUQemev/CtvvkJdD48kg0zttF0 Soie2C9OY0a03OYEeHW5F2nnOnP0QIMaTFR0/8Zmp8PlPXPtKq7b2ARLwdPw0PhSyM3UF6oQb9vej KdSwqLzSHPyW4P1+LEbv4g6DSrkY9qZIDodBXWe+BTGVak4hXZIZt1YRcZTkwaPqmlPieX9eo8swn SCjGUCDkNZtEbc8EGas/JCliw02XxtTVSGSzyePDgH2DEF1aO3lZU8yuXxBOTHHyHd97CKfWp13Qn J7pDP90vg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jycDf-0006qP-Fa; Thu, 23 Jul 2020 14:29:11 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jycDe-0006qF-6H for linux-arm-kernel@merlin.infradead.org; Thu, 23 Jul 2020 14:29:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=upOiIS7dMuAye0nblqH4s7ijqqWrvcTJhfr37DrOQV4=; b=NXnhLWyzLS186oz1sFOcrgLsjP wqswZUN8nPVkVOwndoUqsF7gfC2ZxKdZQCwGixtBlpofMFffF/EjHEPBljpMLAh8NEIb+GWShTLxE qSNjgEb8x5KIxJyWKY+I1Wy3wsvp+yPXIv3dACcd0VqcZlI/7eoC5IRec+tZVNCRZe184WGpSozhk CvN5XmIyHTaRw44j/WGYE+N6OLt25YAvJyVdEHG5nt1uNTZYubIMudeszyZkroKmGPNLmWm8fq7Cm GpFfjYgDqTZB6cKPZMF8/YFlhLIN8uceUVDtQTVDRnXEgTmQCUgX5H8Any/+y/RIVCID1b84LZb/Y Sghus1pw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jycDX-0006yA-8C; Thu, 23 Jul 2020 14:29:03 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 64E5F983422; Thu, 23 Jul 2020 16:29:02 +0200 (CEST) Date: Thu, 23 Jul 2020 16:29:02 +0200 From: Peter Zijlstra To: Thomas Gleixner Subject: Re: [PATCH v4 00/13] "Task_isolation" mode Message-ID: <20200723142902.GT5523@worktop.programming.kicks-ass.net> References: <04be044c1bcd76b7438b7563edc35383417f12c8.camel@marvell.com> <87imeextf3.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87imeextf3.fsf@nanos.tec.linutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-arch@vger.kernel.org" , "catalin.marinas@arm.com" , Alex Belits , "frederic@kernel.org" , "linux-kernel@vger.kernel.org" , "rostedt@goodmis.org" , "mingo@kernel.org" , "netdev@vger.kernel.org" , Prasun Kapoor , "linux-api@vger.kernel.org" , "will@kernel.org" , "davem@davemloft.net" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 23, 2020 at 03:17:04PM +0200, Thomas Gleixner wrote: > 8) Changelogs > > Most of the changelogs have something along the lines: > > 'task isolation does not want X, so do Y to make it not do X' > > without any single line of explanation why this approach was chosen > and why it is correct under all circumstances and cannot have nasty > side effects. > > It's not the job of the reviewers/maintainers to figure this out. > > Please come up with a coherent design first and then address the > identified issues one by one in a way which is palatable and reviewable. > > Throwing a big pile of completely undocumented 'works for me' mess over > the fence does not get you anywhere, not even to the point that people > are willing to review it in detail. This.. as presented it is an absolutely unreviewable pile of junk. It presents code witout any coherent problem description and analysis. And the patches are not split sanely either. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel