From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9D0FC433EB for ; Fri, 24 Jul 2020 13:12:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B69242065F for ; Fri, 24 Jul 2020 13:12:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NMQ+C6YS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B69242065F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Cc1XSEvfgl94rCjr4ypLVeebXFOonWyY9yNpatjggrQ=; b=NMQ+C6YS5ue8zAeohvEkCXR6e w0o+RAKDaiz065MEDT+JwzMX2+VBPKxDvC2t6Vu/4/IJ+jLBmwzzZoAHfXmVDGbqlULXl6e/1R/I6 0e9MDtjI4Zu05FoG0pqkIBnxBIi00hIUlMKW3I+wvvbK2qPlp/+9/9UJ/hr21ctGNHS2Uo1i8rVDp mxS71TbPTqyTVG+U9/6jqcWYY5BNlg8cqCRnjMLA/DC/yjPd9WkhamtA6w6WLkQ7RGBBN3Cxw4TSt XdCcYGiOboHDy45C3XGvlFlHm27vKRe8XA590lqDU9AHbswAN2Sg3O7B8ZoKCEdvIgUTCqDk/c1nl rxdPlKB8Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyxTl-00082e-VG; Fri, 24 Jul 2020 13:11:14 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyxTj-00082J-9a for linux-arm-kernel@lists.infradead.org; Fri, 24 Jul 2020 13:11:12 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A52BAD6E; Fri, 24 Jul 2020 06:11:04 -0700 (PDT) Received: from bogus (unknown [10.37.12.41]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 174233F66F; Fri, 24 Jul 2020 06:11:01 -0700 (PDT) Date: Fri, 24 Jul 2020 14:10:59 +0100 From: Sudeep Holla To: Kefeng Wang Subject: Re: [PATCH -next] arm64: Export __cpu_logical_map Message-ID: <20200724131059.GB6521@bogus> References: <20200724030433.22287-1-wangkefeng.wang@huawei.com> <82f750c4-d423-1ed8-a158-e75153745e07@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <82f750c4-d423-1ed8-a158-e75153745e07@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200724_091111_389041_1B64ECFC X-CRM114-Status: GOOD ( 10.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , "linux-kernel@vger.kernel.org List" , Mikko Perttunen , Hulk Robot , Viresh Kumar , Sudeep Holla , Sumit Gupta , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 24, 2020 at 11:08:03AM +0800, Kefeng Wang wrote: > +maillist > > On 2020/7/24 11:04, Kefeng Wang wrote: > > ERROR: modpost: "__cpu_logical_map" [drivers/cpufreq/tegra194-cpufreq.ko] undefined! > > > > ARM64 tegra194-cpufreq driver use cpu_logical_map, export > > __cpu_logical_map to fix build issue. > > I wonder why like other instances in the drivers, the mpidr is not get directly from the cpu. The cpufreq_driver->init call happens when the cpu is being brought online and is executed on the required cpu IIUC. read_cpuid_mpidr() is inline and avoids having to export the logical_cpu_map. Though we may not add physical hotplug anytime soon, less dependency on this cpu_logical_map is better given that we can resolve this without the need to access the map. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel