From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F461C433E0 for ; Mon, 27 Jul 2020 06:25:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1994520714 for ; Mon, 27 Jul 2020 06:25:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="n/+jUOYM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1994520714 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zg64VLUPwGSr7kGAn7oAi45Lt/+UWowdeZfsbn4HTGg=; b=n/+jUOYMPB31hLJqdSytk68R7 p1Vv+oC/HRIbGVPQETsyzaAGTTYMzFFLTNy/oVvN6VoisRxVf2hxbiQxfVQxxMoOGPs5vtdy849MA pnlCvLb6zgLumUT4duqsS1qopy3/V7mo7SjtXNwZdgINHnNWyfN8sPGEs1nwKewyBePnCkOPzT3Hs F0hIVvCrsuwV6dvup3yfPbkKuuQ7VBWDL6dAzviGF0G0ZSAa5N2oR9wRY/qtslXMe7Mi0/noP2u5j mkzspFoyeelc9Gof/lsxlCBzlAVdlOamruWV2iPohu1m7pBTzT1d6DZlnwrQzNYLdWU3B3daWiJsq +oGWY1HtA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jzwY4-0000et-VY; Mon, 27 Jul 2020 06:23:45 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jzwY1-0000eU-Mf for linux-arm-kernel@lists.infradead.org; Mon, 27 Jul 2020 06:23:42 +0000 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jzwXw-0002of-IK; Mon, 27 Jul 2020 08:23:36 +0200 Received: from ore by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1jzwXv-0003o8-V4; Mon, 27 Jul 2020 08:23:35 +0200 Date: Mon, 27 Jul 2020 08:23:35 +0200 From: Oleksij Rempel To: Peng Fan Subject: Re: [PATCH 03/10] remoteproc: imx: use devm_ioremap Message-ID: <20200727062335.v2pxgu6kr6ao2qmh@pengutronix.de> References: <20200724080813.24884-1-peng.fan@nxp.com> <20200724080813.24884-4-peng.fan@nxp.com> MIME-Version: 1.0 In-Reply-To: <20200724080813.24884-4-peng.fan@nxp.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:19:20 up 254 days, 21:37, 239 users, load average: 0.12, 0.04, 0.01 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200727_022341_917389_A043BA42 X-CRM114-Status: GOOD ( 18.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, mathieu.poirier@linaro.org, festevam@gmail.com, s.hauer@pengutronix.de, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============5412567900889263911==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5412567900889263911== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6tzlik4lnidne2ag" Content-Disposition: inline --6tzlik4lnidne2ag Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 24, 2020 at 04:08:06PM +0800, Peng Fan wrote: > We might need to map an region multiple times, becaue the region might > be shared between remote processors, such i.MX8QM with dual M4 cores. > So use devm_ioremap, not devm_ioremap_resource. Can you please give an example of this kind of shared resources and how they should be handled by two separate devices? > Reviewed-by: Richard Zhu > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rpro= c.c > index 3b3904ebac75..82594a800a1b 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -296,9 +296,10 @@ static int imx_rproc_addr_init(struct imx_rproc *pri= v, > if (b >=3D IMX7D_RPROC_MEM_MAX) > break; > =20 > - priv->mem[b].cpu_addr =3D devm_ioremap_resource(&pdev->dev, &res); > + /* Not use resource version, because we might share region*/ > + priv->mem[b].cpu_addr =3D devm_ioremap(&pdev->dev, res.start, resource= _size(&res)); > if (IS_ERR(priv->mem[b].cpu_addr)) { > - dev_err(dev, "devm_ioremap_resource failed\n"); > + dev_err(dev, "devm_ioremap %pR failed\n", &res); > err =3D PTR_ERR(priv->mem[b].cpu_addr); > return err; > } > --=20 > 2.16.4 >=20 >=20 --=20 Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --6tzlik4lnidne2ag Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEERBNZvwSgvmcMY/T74omh9DUaUbMFAl8ectMACgkQ4omh9DUa UbMnEw//ZgH40i5qUwwFDcMh8LHIrxrRN0O+VsFoBQ1duEG9Q84k0FJNjigGtOUJ G7y0Dw8/ar+figjxswgcs/YpcQuR246wnR4eb8LLXKV3bvJ4mNdPjEbzzOnd6nMo RMho0UsR8L2gryGDGHv1xn5eRN7xZiXwjw01bSDlJavcSIY6g6341RFRlNMLOs7d z+2NnQGcGy6PVc/CFcR33+1HW10N6eGtbPthYVZIhQaDoA/imBgqXkUTxWoJJzi8 Ke3jbRP3XoDreV0+1NrK+7otk6JtXXWQQDnUtDhqZh+/iqJNoMcCkwYFORNqCCym GQuhLHEnrACRXACj/QMZ2P7Jquh7e4YlDTafMtZCzqSMhRa5LDTF6M/NoInZPW+P i8eZqtpNfqAIDehNJ1rXJOQ8q5Sb5JuhtuEUPz9yJ6huou6ArsyuRSY10rGm7S1B WSmmpoXaPkj4qspjo0CJlajzojiVucyE1ta05xlmmMHw5dvo+Mr+LOFDQaHWYfip 8wNFRybYIZxlEsHX7Vwepxis5XUATKm7GEsApr/vaQTAaufO1FmZfgNa0VjfzPi1 ks6mi6HdCbzOl5n0ODyGuwO8FxJRSML7KJZlSWI878Bi8Es4UpOHoBNWb6UfMwYh 4h9kEgxFjcWK0Th5q6jpBtUSIGmAdjB+xsLwoonUz/r4Tcw1yIg= =yeys -----END PGP SIGNATURE----- --6tzlik4lnidne2ag-- --===============5412567900889263911== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5412567900889263911==--