From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E320C433E3 for ; Mon, 27 Jul 2020 16:07:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 087722073E for ; Mon, 27 Jul 2020 16:07:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kMKE12su" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 087722073E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qhzRAzMTwd1ZRkHehTUW6xb6x6YL9bnw0uSMtCKW1KQ=; b=kMKE12suxSWy8Nq+qFt0bsaRV JcQiS3sZkeuQxGV/NWS3nYXUovp1o9cAbOV5JzPMAs1Z0rxJR7m9qEOdOaPK7DGUT05GFCHy5heg7 hj+fvmLhVpwR8ncBbOCF2Qfe2gyntCJ4Ar0gzwgzMgVPkapiF6jnmCq+u0LdnBTArbHZkkQQ7NVFW V4XoQ48R0CRdAaatihvwdSdZqOdox0fot4xigv4zQjVvxeLmbWvq8Cr1VnkAG3fG7nkgFD89X3gie cuovA1qsZgk8omOGnkhM1MFKwmovzGp3OC00+KlKk3bbcq7qU+wHzfDG6F/wWLoW8ouI0El/RGKe/ NRHdgVQ5A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k05d6-0004Nd-2U; Mon, 27 Jul 2020 16:05:32 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k05d3-0004N8-Op for linux-arm-kernel@lists.infradead.org; Mon, 27 Jul 2020 16:05:30 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6F1CCD6E; Mon, 27 Jul 2020 09:05:25 -0700 (PDT) Received: from bogus (unknown [10.37.12.41]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 851B23F718; Mon, 27 Jul 2020 09:05:22 -0700 (PDT) Date: Mon, 27 Jul 2020 17:05:15 +0100 From: Sudeep Holla To: Sumit Gupta Subject: Re: [PATCH -next] arm64: Export __cpu_logical_map Message-ID: <20200727160515.GA8003@bogus> References: <20200724030433.22287-1-wangkefeng.wang@huawei.com> <82f750c4-d423-1ed8-a158-e75153745e07@huawei.com> <20200724131059.GB6521@bogus> <00cf6e67-16ed-872d-2c16-0ceea6b6f514@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <00cf6e67-16ed-872d-2c16-0ceea6b6f514@nvidia.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200727_120529_866252_627C2C09 X-CRM114-Status: GOOD ( 21.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kefeng Wang , Catalin Marinas , Sudeep Holla , "linux-kernel@vger.kernel.org List" , Mikko Perttunen , Hulk Robot , Bibek Basu , Viresh Kumar , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jul 26, 2020 at 05:16:27PM +0530, Sumit Gupta wrote: > > > > ERROR: modpost: "__cpu_logical_map" [drivers/cpufreq/tegra194-cpufreq.ko] undefined! > > > > > > > > ARM64 tegra194-cpufreq driver use cpu_logical_map, export > > > > __cpu_logical_map to fix build issue. > > > > > > > > I wonder why like other instances in the drivers, the mpidr is not get > > directly from the cpu. The cpufreq_driver->init call happens when the cpu > > is being brought online and is executed on the required cpu IIUC. > > > Yes, this occurs during hotplug case. > But in the case of system boot, 'cpufreq_driver->init' is called later > during cpufreq platform driver's probe. The value of CPU in 'policy->cpu' > can be different from the current CPU. That's why read_cpuid_mpidr() can't > be used. > Fair enough, why not do cross call like in set_target ? Since it is one-off in init, I don't see any issue when you are doing it runtime for set_target. > > read_cpuid_mpidr() is inline and avoids having to export the logical_cpu_map. > > Though we may not add physical hotplug anytime soon, less dependency > > on this cpu_logical_map is better given that we can resolve this without > > the need to access the map. > > To be honest, we have tried to remove all the dependency on cluster id in generic code as it is not well defined. This one is tegra specific driver so should be fine. But I am still bit nervous to export cpu_logical_map as we have no clue what that would mean for physical hotplug. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel