linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Pingfan Liu <kernelfans@gmail.com>
Cc: Will Deacon <will@kernel.org>, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64/fixmap: make notes of fixed_addresses more precisely
Date: Thu, 30 Jul 2020 12:09:38 +0100	[thread overview]
Message-ID: <20200730110937.GH25149@gaia> (raw)
In-Reply-To: <1594388602-17790-1-git-send-email-kernelfans@gmail.com>

On Fri, Jul 10, 2020 at 09:43:22PM +0800, Pingfan Liu wrote:
> These 'compile-time allocated' memory buffers can occupy more than one
> page. So improve the note about it.
> 
> Signed-off-by: Pingfan Liu <kernelfans@gmail.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> To: linux-arm-kernel@lists.infradead.org
> ---
>  arch/arm64/include/asm/fixmap.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/include/asm/fixmap.h b/arch/arm64/include/asm/fixmap.h
> index f987b8a..318aee1 100644
> --- a/arch/arm64/include/asm/fixmap.h
> +++ b/arch/arm64/include/asm/fixmap.h
> @@ -29,7 +29,8 @@
>   * in the boot process.
>   *
>   * These 'compile-time allocated' memory buffers are
> - * page-sized. Use set_fixmap(idx,phys) to associate
> + * page-sized (or larger if used with an increment
> + * higher than 1). Use set_fixmap(idx,phys) to associate
>   * physical memory with fixmap indices.

I don't get this. set_fixmap() only maps a page. Also, what's
"increment" in this context?

-- 
Catalin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-07-30 11:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-10 13:43 [PATCH] arm64/fixmap: make notes of fixed_addresses more precisely Pingfan Liu
2020-07-30 11:09 ` Catalin Marinas [this message]
2020-07-31  2:47   ` Pingfan Liu
2020-07-31 12:13     ` Catalin Marinas
2020-08-03  2:07       ` Pingfan Liu
2020-08-03 11:53         ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200730110937.GH25149@gaia \
    --to=catalin.marinas@arm.com \
    --cc=kernelfans@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).