From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Dongchun Zhu <dongchun.zhu@mediatek.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"drinkcat@chromium.org" <drinkcat@chromium.org>,
srv_heupstream <srv_heupstream@mediatek.com>,
"Shengnan Wang (王圣男)" <shengnan.wang@mediatek.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"tfiga@chromium.org" <tfiga@chromium.org>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
"Sj Huang (黃信璋)" <sj.huang@mediatek.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"Louis Kuo (郭德寧)" <louis.kuo@mediatek.com>,
"bingbu.cao@intel.com" <bingbu.cao@intel.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"Erin Lo (羅雅齡)" <erin.lo@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH V9 0/2] media: i2c: Add support for DW9768 VCM
Date: Thu, 30 Jul 2020 19:39:30 +0300 [thread overview]
Message-ID: <20200730163930.GI13316@paasikivi.fi.intel.com> (raw)
In-Reply-To: <1593687965.17166.73.camel@mhfsdcap03>
Dongchun,
On Thu, Jul 02, 2020 at 07:06:05PM +0800, Dongchun Zhu wrote:
> Hi Sakari,
>
> Sorry I just sent email using outlook where default format is HTML, now
> I use evolution, one Linux mail client that I used to send upstream
> patch previously.
>
> On Thu, 2020-07-02 at 08:34 +0300, Sakari Ailus wrote:
> > Dongchun,
> >
> > Please don't send HTML e-mail to Linux kernel related mailing lists.
> >
> > On Thu, Jul 02, 2020 at 03:48:56AM +0000, Dongchun Zhu (朱东春) wrote:
> > > Hi Sakari,
> > >
> > > Sorry to bother you again, but I am so confused about the questions you raised.
> > > I just synced mainline: 5.8-rc3 tarball from https://www.kernel.org/, on which I ran the git am <patch> command.
> > > The patch-applying process shows no error.
> > > -----------------8<-------------------
> > > [mtk15013@mtkslt307 linux]$git apply --check media-i2c-Add-support-for-DW9768-VCM.patch
> > > [mtk15013@mtkslt307 linux]$git am media-i2c-Add-support-for-DW9768-VCM.patch
> > > Applying: media: dt-bindings: media: i2c: Document DW9768 bindings
> > > Applying: media: i2c: dw9768: Add DW9768 VCM driver
> > > -----------------8<-------------------
> > >
> > > On the other hand, I also compared dongwoon,dw9768.yaml file with other media device dt-bindings(like imx219.yaml and ov8856.yaml).
> > > It seems there are no apparent differences between them.
> > > Especially, the sentence '# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)' shall be common.
> > > I dunno why here dongwoon,dw9768.yaml reports trailing whitespace warnings while ov8856.yaml is silent.
> > >
> > > For the patch failed on MAINTAINERS, I am still curious what's wrong.
> > > In fact, I locally have run parse-maintainers.pl script to check MAINTAINERS file before submitting patch.
> > > The result also reports no errors.
> > > -----------------8<-------------------
> > > [mtk15013@mtkslt307 linux]$perl scripts/parse-maintainers.pl
> > > [mtk15013@mtkslt307 linux]$ls
> > > -----------------8<-------------------
> > >
> > > As to Base64 encoding, I checked each patch file again. They are all encoded in UTF-8.
> > > As https://www.base64encode.org/ says, for an example, '77' in ASCII format would be changed to 'T' in Based64-encoded format.
> > > This means there shall be messy code if we adpoting Based64-encoded format.
> > > But I cannot see garbled messages in the current patches.
> > >
> > > The DW9768 serials-patch is attached.
> > > @Tomasz @Andy @Rob could anyone help try to see whether the patch can be cherry-picked on Linux master branch or not?
> > > Patchwork link:
> > > https://patchwork.kernel.org/cover/11633291/
> >
> > Both of the patches appear to contain only ASCII characters.
> >
> > I did some research on this. It seems that the base64 encoded message body
> > does have carriage returns, in both cases. Git am does not attempt to
> > remove them in that case, but Patchwork does. Hence the files are fine if
> > you download them from Patchwork --- where the mbox files have neither
> > carriage returns nor base64 encoding.
> >
> > What does the file command say about the patch files produced by git
> > format-patch? My guess is that something in between your local computer and
> > LMML (and other mail servers) base64 encodes the message body. But where
> > are the carriage returns added? Nevertheless they seem to be added before
> > the base64 conversion.
> >
>
> Hm... I used the file command to check the diff patch generated from git
> format-patch and that downloaded from Patchwork, they are both ASCII
> text.
That's because Patchwork appears to be removing the carriage returns. git
does not if the content is base64 encoded.
Your e-mail setup simply appears to be broken. I'd suggest trying to send
the patches encoded in base64 as a workaround. git send-email uses
sendemail.transferEncoding configuration option for this.
--
Sakari Ailus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-30 16:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 6:22 [PATCH V9 0/2] media: i2c: Add support for DW9768 VCM Dongchun Zhu
2020-06-30 6:22 ` [PATCH V9 1/2] media: dt-bindings: media: i2c: Document DW9768 bindings Dongchun Zhu
2020-06-30 6:22 ` [PATCH V9 2/2] media: i2c: dw9768: Add DW9768 VCM driver Dongchun Zhu
2020-06-30 16:57 ` Tomasz Figa
2020-07-01 9:16 ` [PATCH V9 0/2] media: i2c: Add support for DW9768 VCM Sakari Ailus
[not found] ` <bf610d1b13c74656b2ffeeb9cc2a96ac@MTKMBS31N1.mediatek.inc>
[not found] ` <20200701134416.GQ16711@paasikivi.fi.intel.com>
[not found] ` <e55e7b405a084a0298cd839c05b52c79@MTKMBS31N1.mediatek.inc>
2020-07-02 5:10 ` Cao, Bingbu
2020-07-02 5:34 ` Sakari Ailus
2020-07-02 11:06 ` Dongchun Zhu
2020-07-30 16:39 ` Sakari Ailus [this message]
2020-07-31 2:44 ` [SPAM]Re: " Dongchun Zhu
2020-07-31 13:04 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730163930.GI13316@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=bingbu.cao@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dongchun.zhu@mediatek.com \
--cc=drinkcat@chromium.org \
--cc=erin.lo@mediatek.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=louis.kuo@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=shengnan.wang@mediatek.com \
--cc=sj.huang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).