From: Valentin Schneider <valentin.schneider@arm.com>
To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Marc Zyngier <maz@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
Jason Cooper <jason@lakedaemon.net>
Subject: [PATCH v2 0/2] irqchip/gic-v2, v3: Enforce ACK/EOI pairing on IRQ retrigger
Date: Thu, 30 Jul 2020 18:03:19 +0100 [thread overview]
Message-ID: <20200730170321.31228-1-valentin.schneider@arm.com> (raw)
Hi,
This is v2 of:
https://lkml.kernel.org/r/20200710145642.28978-1-valentin.schneider@arm.com
the TL;DR being: retriggering of IRQs marked with IRQS_PENDING breaks the
ACK/EOI pairing the GIC spec requires, and this is an attempt to clean it
up; details are in the changelogs.
Testing
=======
I briefly tested this on my Juno r0 by hackishly configuring the RTC
interrupt as edge-sensitive (level interrupts don't get retriggered) and
triggering a wakeup interrupt via
$ rtcwake -d /dev/rtc0 -s 1 -m mem
along with sprinkling a few printks to make sure things go down the right
way. Note that wakeup from RTC is currently broken on Juno and requires
this patch from Sudeep:
4df2ef85f0ef ("rtc: pl031: fix set_alarm by adding back call to alarm_irq_enable")
The RTC on my eMAG can't be set up as a wakeup alarm, so I didn't get to
test the retriggering side of things on GICv3 - the rest does seem to still
behave correctly.
Revisions
=========
v1 -> v2
--------
o Trimmed the changelog
o Fixed gic_retrigger() return value (Marc)
o (new patch) Added IRQD_HANDLE_ENFORCE_IRQCTX to all GIC IRQs
Valentin Schneider (2):
irqchip/gic-v2, v3: Implement irq_chip->irq_retrigger()
irqchip/gic-v2, v3: Prevent SW resends entirely
drivers/irqchip/irq-gic-v3.c | 12 +++++++++++-
drivers/irqchip/irq-gic.c | 12 +++++++++++-
2 files changed, 22 insertions(+), 2 deletions(-)
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2020-07-30 17:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 17:03 Valentin Schneider [this message]
2020-07-30 17:03 ` [PATCH v2 1/2] irqchip/gic-v2, v3: Implement irq_chip->irq_retrigger() Valentin Schneider
2020-07-30 17:03 ` [PATCH v2 2/2] irqchip/gic-v2, v3: Prevent SW resends entirely Valentin Schneider
2020-07-30 18:10 ` Marc Zyngier
2020-07-31 0:08 ` Valentin Schneider
2020-07-31 8:08 ` Marc Zyngier
2020-07-31 11:27 ` Marc Zyngier
2020-07-31 12:11 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730170321.31228-1-valentin.schneider@arm.com \
--to=valentin.schneider@arm.com \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).