From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA0AFC433DF for ; Fri, 31 Jul 2020 12:15:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90FF2206FA for ; Fri, 31 Jul 2020 12:15:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WS/YP3XX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90FF2206FA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Yes1cabkwBV2nHY1u1IMU30ybWzLukS2ekWvbwJDUgs=; b=WS/YP3XXCdER7vumkl2vOPMoQ 1iDXbjAUefrwEfaUfyHT7wA/1Ns1sRDq1SQ7iSL/+EhOBRuzL/PBr8dTz3ljvb8kxAO4H5u4DK5ps 9u+JM5bFOUDH5XfpJmuHkVDzL0jsEDwoX4HAnMegk1R65oBrgNblcYurXIZ6evDmvXPikX2Tc9TXU cmKv9I/I+nL/Wgoh2/IRKOfUeBm5h1Vn6hx6KkmaY9KWjiGhaz5KokMJopc8yLBEPImxjfhVSG43s +vlPM5ssQX0sg+pMd7IVGGyUcK1SWOzdnLSctgOkx5r2k++XYN78Z4VL16ofs/jjQFmOT/Q7F+zuk gi8znBBBg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1Tuw-0002pj-SU; Fri, 31 Jul 2020 12:13:42 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1Tut-0002od-Jg for linux-arm-kernel@lists.infradead.org; Fri, 31 Jul 2020 12:13:40 +0000 Received: from gaia (unknown [95.146.230.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 879FC208E4; Fri, 31 Jul 2020 12:13:37 +0000 (UTC) Date: Fri, 31 Jul 2020 13:13:35 +0100 From: Catalin Marinas To: Pingfan Liu Subject: Re: [PATCH] arm64/fixmap: make notes of fixed_addresses more precisely Message-ID: <20200731121334.GC29569@gaia> References: <1594388602-17790-1-git-send-email-kernelfans@gmail.com> <20200730110937.GH25149@gaia> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200731_081339_718472_BC29AD9D X-CRM114-Status: GOOD ( 23.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 31, 2020 at 10:47:13AM +0800, Pingfan Liu wrote: > On Thu, Jul 30, 2020 at 7:09 PM Catalin Marinas wrote: > > On Fri, Jul 10, 2020 at 09:43:22PM +0800, Pingfan Liu wrote: > > > These 'compile-time allocated' memory buffers can occupy more than one > > > page. So improve the note about it. > > > > > > Signed-off-by: Pingfan Liu > > > Cc: Catalin Marinas > > > Cc: Will Deacon > > > To: linux-arm-kernel@lists.infradead.org > > > --- > > > arch/arm64/include/asm/fixmap.h | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/arch/arm64/include/asm/fixmap.h b/arch/arm64/include/asm/fixmap.h > > > index f987b8a..318aee1 100644 > > > --- a/arch/arm64/include/asm/fixmap.h > > > +++ b/arch/arm64/include/asm/fixmap.h > > > @@ -29,7 +29,8 @@ > > > * in the boot process. > > > * > > > * These 'compile-time allocated' memory buffers are > > > - * page-sized. Use set_fixmap(idx,phys) to associate > > > + * page-sized (or larger if used with an increment > > > + * higher than 1). Use set_fixmap(idx,phys) to associate > > > * physical memory with fixmap indices. > > > > I don't get this. set_fixmap() only maps a page. Also, what's > > "increment" in this context? > > I refer to the notes in the counterpart in x86. And for the time > being, it is the case for the ranges (FIX_FDT, FIX_FDT_END), which may > cost more than one page size. OK, so increment refers to the enum increment. But if we update this, we also need to state that set_fixmap() only maps page-size buffers, otherwise one may think that set_fixmap(FIX_FDT, phys) maps the whole FDT. We could say that each enum increment represents a page-sized buffer. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel