From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA6EAC433DF for ; Fri, 31 Jul 2020 12:23:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7B142087C for ; Fri, 31 Jul 2020 12:23:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N/bCOHeF"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q0ZzbSWp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7B142087C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9zv4ADYLruXxq+jmvfo8HCkPlfBs8VwnBRgx1PjeyqM=; b=N/bCOHeFWAf251DbEMRo5fHME kyY49f3wQgXIH7WHPNXL/aToTqA9383l/dxe58XsDfaPgACOTM///0GvwKCbQ9Z57hlzfU+HdfYWK pMCDkc5sqUHWzMeQyCXitTvWtaw4iVc9CNFczre58BQQe1eIb5k4STJNXdN30ShpZX0fFG9NUbxIZ VSgmJ6+g41EXI+g+iTUWByEt80/Yrsjx6XndyJ8YX3EAFx3J9I5avMA5JnQqOf9Jg2K4nk4nXx0Y9 Rg9ac3p9lcsPE3IRl5GnRTv9LrJO44vFEfKLC+Ll1K2eLMXlNe/Ju8p+rwWs78hrQCgaSzn1epFJ5 PwduSlJtA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1U2x-0003oU-To; Fri, 31 Jul 2020 12:21:59 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1U2u-0003nD-KT for linux-arm-kernel@lists.infradead.org; Fri, 31 Jul 2020 12:21:57 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3ED962087C; Fri, 31 Jul 2020 12:21:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596198115; bh=vc1ImGY9ezu14UINAtGXOIexIbmqRuCAwzBXUxT5boc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q0ZzbSWppvmJ/MYB/pGXagBhhSQ9bD7LpZWL9SUT/EWIUBPoOQr5eTL4uUSZ/pdJR 9UHrnarPMOXE5IZHt/MrDEU3vCVTAhUxjfIp98aFDkGyi+1sT70yxUHjCKH8VO1K79 NA1fpY7BIdD7et8Xpc9izT6LlrujDEsyimhPF2qA= Date: Fri, 31 Jul 2020 13:21:50 +0100 From: Will Deacon To: "Song Bao Hua (Barry Song)" Subject: Re: [PATCH v2] iommu/arm-smmu-v3: disable MSI polling if SEV polling is faster Message-ID: <20200731122149.GA26817@willie-the-truck> References: <20200731083343.18152-1-song.bao.hua@hisilicon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200731_082156_876509_9C02A8D9 X-CRM114-Status: GOOD ( 24.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "joro@8bytes.org" , John Garry , Linuxarm , "iommu@lists.linux-foundation.org" , "Zengtao \(B\)" , "robin.murphy@arm.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 31, 2020 at 10:48:33AM +0000, Song Bao Hua (Barry Song) wrote: > > -----Original Message----- > > From: John Garry > > Sent: Friday, July 31, 2020 10:21 PM > > To: Song Bao Hua (Barry Song) ; will@kernel.org; > > robin.murphy@arm.com; joro@8bytes.org; iommu@lists.linux-foundation.org > > Cc: Zengtao (B) ; Linuxarm > > ; linux-arm-kernel@lists.infradead.org > > Subject: Re: [PATCH v2] iommu/arm-smmu-v3: disable MSI polling if SEV > > polling is faster > > > > On 31/07/2020 09:33, Barry Song wrote: > > > Different implementations may show different performance by using SEV > > > polling or MSI polling. > > > On the implementation of hi1620, tests show disabling MSI polling can > > > bring performance improvement. > > > Using 16 threads to run netperf on hns3 100G NIC with UDP packet size > > > in 32768bytes and set iommu to strict, TX throughput can improve from > > > 25Gbps to 27Gbps by this patch. > > > This patch adds a generic function to support implementation options > > > based on IIDR and disables MSI polling if IIDR matches the specific > > > implementation tested. > > Not sure if we should do checks like this on an implementation basis. > > I'm sure maintainers will decide. > > Yes, maintainers will decide. I guess Will won't object to IIDR-based solution according to > previous discussion threads: > https://lore.kernel.org/patchwork/patch/783718/ > > Am I right, Will? Honestly, I object to the whole idea that we should turn off optional hardware features just because they're slow. Did nobody take time to look at the design and check that it offered some benefit, or where they in too much of a hurry to tick the checkbox to say they had the new feature? I really dislike the pick and mix nature that some of this IP is heading in, where the marketing folks want a slice of everything for the branding, instead of doing a few useful things well. Anyway, that's not your fault, so I'll stop moaning. *sigh* Given that you've baked this thing now, then if we have to support it I would prefer the command-line option. At least that means that people can compare the performance with it on and off (and hopefully make sure the hardware doesn't suck). It also means it's not specific to ACPI. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel