From: <wsa@kernel.org>
To: <Codrin.Ciubotariu@microchip.com>
Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com,
kamel.bouhara@bootlin.com, linux-kernel@vger.kernel.org,
Ludovic.Desroches@microchip.com, robh+dt@kernel.org,
linux-i2c@vger.kernel.org, linux@armlinux.org.uk,
linux-arm-kernel@lists.infradead.org
Subject: Re: Re: [RFC PATCH 3/4] i2c: core: treat EPROBE_DEFER when acquiring SCL/SDA GPIOs
Date: Mon, 3 Aug 2020 18:59:14 +0200 [thread overview]
Message-ID: <20200803165914.GB1094@kunai> (raw)
In-Reply-To: <15a449fa-d649-846a-e6f2-1540f9581846@microchip.com>
[-- Attachment #1.1: Type: text/plain, Size: 1115 bytes --]
> > This is correct but I think the code flow is/was confusing. Can you drop
> > this 'return' and use 'else if' for the next code block? I think this is
> > more readable.
>
> Ok, it makes sense. Should I make a separate patch for this only?
I am fine if this is included in this change.
> One more question, should we keep:
> if (!bri->set_sda && !bri->get_sda) {
> err_str = "either get_sda() or set_sda() needed";
> goto err;
> }
> ?
> Without {get/set}_sda we won't be able to generate stop commands and
> possibly check if the bus is free, but we can still generate the SCL
> clock pulses.
My gut feeling says we need to keep it. I can't recall the reason now
and want to send out this answer ASAP. Anyhow, this definately would be
a seperate patch. If you really want to, send a patch, and then I have
to think why we still need it ;)
> Ok. Perhaps I should also move the debug print with the registered
> adapter after calling i2c_init_recovery().
Yes, makes sense.
> Do you want me to integrate this patch in the previous one?
Nope, please keep it seperate.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-03 17:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 14:19 [RFC PATCH 0/4] i2c: core: add generic GPIO bus recovery Codrin Ciubotariu
2020-06-19 14:19 ` [RFC PATCH 1/4] dt-binding: i2c: add generic properties for " Codrin Ciubotariu
2020-07-05 21:19 ` Wolfram Sang
2020-07-24 19:39 ` Wolfram Sang
2020-07-24 20:52 ` Russell King - ARM Linux admin
2020-07-27 10:44 ` Codrin.Ciubotariu
2020-07-27 10:50 ` Russell King - ARM Linux admin
2020-07-30 9:00 ` Codrin.Ciubotariu
2020-08-03 14:16 ` Russell King - ARM Linux admin
2020-08-03 16:42 ` Codrin.Ciubotariu
2020-07-15 19:21 ` Rob Herring
2020-06-19 14:19 ` [RFC PATCH 2/4] i2c: core: add generic I2C GPIO recovery Codrin Ciubotariu
2020-08-02 16:54 ` Wolfram Sang
2020-08-03 13:27 ` Codrin.Ciubotariu
2020-08-03 16:49 ` wsa
2020-06-19 14:19 ` [RFC PATCH 3/4] i2c: core: treat EPROBE_DEFER when acquiring SCL/SDA GPIOs Codrin Ciubotariu
2020-08-02 17:05 ` Wolfram Sang
2020-08-03 15:33 ` Codrin.Ciubotariu
2020-08-03 16:59 ` wsa [this message]
2020-06-19 14:19 ` [RFC PATCH 4/4] i2c: at91: Move to generic GPIO bus recovery Codrin Ciubotariu
2020-08-02 17:08 ` Wolfram Sang
2020-08-03 15:42 ` Codrin.Ciubotariu
2020-08-03 16:59 ` wsa
2020-08-26 6:14 ` Wolfram Sang
2020-09-04 8:55 ` Codrin.Ciubotariu
2020-09-04 9:20 ` Wolfram Sang
2020-07-05 21:09 ` [RFC PATCH 0/4] i2c: core: add " Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200803165914.GB1094@kunai \
--to=wsa@kernel.org \
--cc=Codrin.Ciubotariu@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=kamel.bouhara@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).