From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E176C433E0 for ; Tue, 4 Aug 2020 06:27:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7445D20722 for ; Tue, 4 Aug 2020 06:27:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fTGJg+3W"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zxYJy5St" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7445D20722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lIQeqVHqf/ztAWcwGBA4iXnA1X3XICmNYOu/1gdDC1s=; b=fTGJg+3WOven8fJX6dYDqP4rL ozDiGwAsunuWOle740Ip8lcQMJDY9hAJlxCOiMibYv2o/EPD//qs/LrePd6ZnFtKxwB6DJmSsoEZH RkP3uAjFcNwfvFpBabHH4jQMhbOYgohppSwsxe8gQDYzrlb7WBT49F1U0+4oaNruX5Z+89LhfGK2M wpGq979tWU2Up/H3/IW9UCxi/E6W0EgYB1ATgYCG6vYlWvnuyrIS1CjNIaeWFYEk8QMWR2iDofH+x X+fVanNHARy7/tvZfBU3i1+mQkvAENvZvfCCgscvejflI2l5jQVfFHiBXk0Ho4djVXpmeIFA30g7i /s2JlHPqQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2qP0-00005e-FY; Tue, 04 Aug 2020 06:26:22 +0000 Received: from mail-pj1-x1044.google.com ([2607:f8b0:4864:20::1044]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2qOw-0008WI-I9 for linux-arm-kernel@lists.infradead.org; Tue, 04 Aug 2020 06:26:19 +0000 Received: by mail-pj1-x1044.google.com with SMTP id e4so1431608pjd.0 for ; Mon, 03 Aug 2020 23:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=A9XNvvJrivb8JTq4QeaRMps6wdVFfMtg1N723IohrT8=; b=zxYJy5Stx156yltLhRTP9GhksOd2MBnMjQpwNHIWQHQ+Bp0htv+64wpe8tUrSf0uZs hVkgWk9tJ4efrQQwpZQYthBB3iRztK6b2ZapTTKQO4YHrYqaEeyEKFB5uy06yJtm+8+o fqvcdq+db54bYb0vstHJl+Sc//Nqkzq6bskXZ1FO8n70gd3tlL/HzOh2fOFycF4zjNEN e1EgUUW9riQTWujTLwvwcmPSzDqntaiYxvyDIpaB0Z2tm789PN2WgcLE1j1ussb/jF1T Ck0QfuEI3IVeM9jBBUAD3THtIPMYfKdzdHjs1MSuZxzPQ4Dj0T7+SgJVNOy3UYtYY5En uw/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=A9XNvvJrivb8JTq4QeaRMps6wdVFfMtg1N723IohrT8=; b=XIJ/tFukd1Y8j88BR+vJX2PXqE/b8v8oPdhKshhT9B91AnzIVlyuIrXT/w/dd/ePUe 2C2HL1MX2gG/VCNl5yGKA4jCo7ER2T04m5d3cxz9nX7km7AITP1JT33CXEFCw5FpZSJI m75JDluXpfbrp/x8xcojsYmdKDxHysD6Cd0m7hzl3uuVPynAZIl7eM72WLQ4eOUn02Kj 6zTHNhnGEyeSEJ7dhUzZ3wyaarYZJtYCtlKw9n8YuRc3G8UCBQ5nv+uZXjCQdmCxGl1q v8rIEd73s94Rntgm+dasVRMRnWWDs15SEpB5PeCGE/zj5J4qssSL1j6QvwPjotLMluZ0 KoJg== X-Gm-Message-State: AOAM530UWX0vG2M8sNVNTHkjtz+G60xWhum9LsZYaCJFpp0VWTcd61Lj Pj5oFjJfjeIPj8E+6Ul6Ba1RvQ== X-Google-Smtp-Source: ABdhPJwuBFWBOL0wZlYQZdtR9A7iPgxvlw2yl0HtQ9dIfmTb4jJy6WHJGuE2cnhX9J0PSHYJUr+dPw== X-Received: by 2002:a17:90a:bc04:: with SMTP id w4mr2645937pjr.99.1596522376172; Mon, 03 Aug 2020 23:26:16 -0700 (PDT) Received: from localhost ([122.162.244.227]) by smtp.gmail.com with ESMTPSA id z29sm6992161pfj.182.2020.08.03.23.26.14 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Aug 2020 23:26:15 -0700 (PDT) Date: Tue, 4 Aug 2020 11:56:11 +0530 From: Viresh Kumar To: Ionela Voinescu Subject: Re: [PATCH v2 2/7] cpufreq: set invariance scale factor on transition end Message-ID: <20200804062611.6jpra73hmhybdw3i@vireshk-mac-ubuntu> References: <20200722093732.14297-1-ionela.voinescu@arm.com> <20200722093732.14297-3-ionela.voinescu@arm.com> <20200730041334.cjg5mc5xpopd2lst@vireshk-mac-ubuntu> <20200803135838.GB9512@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200803135838.GB9512@arm.com> User-Agent: NeoMutt/20170609 (1.8.3) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200804_022618_774719_2767F53D X-CRM114-Status: GOOD ( 28.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, peterz@infradead.org, catalin.marinas@arm.com, rjw@rjwysocki.net, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, mingo@redhat.com, sudeep.holla@arm.com, will@kernel.org, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03-08-20, 14:58, Ionela Voinescu wrote: > Hi Viresh, > > On Thursday 30 Jul 2020 at 09:43:34 (+0530), Viresh Kumar wrote: > > On 22-07-20, 10:37, Ionela Voinescu wrote: > > > While the move of the invariance setter calls (arch_set_freq_scale()) > > > from cpufreq drivers to cpufreq core maintained the previous > > > functionality for existing drivers that use target_index() and > > > fast_switch() for frequency switching, it also gives the possibility > > > of adding support for users of the target() callback, which is exploited > > > here. > > > > > > To be noted that the target() callback has been flagged as deprecated > > > since: > > > > > > commit 9c0ebcf78fde ("cpufreq: Implement light weight ->target_index() routine") > > > > > > It also doesn't have that many users: > > > > > > cpufreq-nforce2.c:371:2: .target = nforce2_target, > > > cppc_cpufreq.c:416:2: .target = cppc_cpufreq_set_target, > > > gx-suspmod.c:439:2: .target = cpufreq_gx_target, > > > pcc-cpufreq.c:573:2: .target = pcc_cpufreq_target, > > > > > > Similarly to the path taken for target_index() calls in the cpufreq core > > > during a frequency change, all of the drivers above will mark the end of a > > > frequency change by a call to cpufreq_freq_transition_end(). > > > > > > Therefore, cpufreq_freq_transition_end() can be used as the location for > > > the arch_set_freq_scale() call to potentially inform the scheduler of the > > > frequency change. > > > > > > This change maintains the previous functionality for the drivers that > > > implement the target_index() callback, while also adding support for the > > > few drivers that implement the deprecated target() callback. > > > > > > Two notes are worthwhile here: > > > - In __target_index(), cpufreq_freq_transition_end() is called only for > > > drivers that have synchronous notifications enabled. There is only one > > > driver that disables them, > > > > > > drivers/cpufreq/powernow-k8.c:1142: .flags = CPUFREQ_ASYNC_NOTIFICATION, > > > > > > which is deprecated. > > > > I don't think this is deprecated. Heh, maybe I misunderstood. I thought you are talking about the flag, while you were talking about the driver. > Sorry, possibly 'deprecated' is a strong word. > > As far as I knew acpi_cpufreq was recommended more recently for K8/K10 > CPUs so that's why I decided not to create a special case for it, also > considering that it was not supporting cpufreq-based frequency > invariance to begin with. > > We could support this as well by having a call to arch_set_freq_scale() > on the else path in __target_index(). But given that there was only this > one user of CPUFREQ_ASYNC_NOTIFICATION, I thought I'd propose this simpler > version first. > > Let me know if my reasoning is wrong. Nevertheless, I don't think you need to mention this detail in changelog for powernow-k8 as cpufreq_freq_transition_end() does get called for it as well, by the driver instead of the core. -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel