From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DD8FC433E0 for ; Tue, 4 Aug 2020 06:48:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 62AE220781 for ; Tue, 4 Aug 2020 06:48:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MPpte6zk"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UueG+3z1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62AE220781 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=B0V9cEf1T6etSkHGiGpqslf6DFbILi+6tHYSAZpV5jE=; b=MPpte6zkNpQhKkwcripTg0s7s 77cKwBptZDtZUmTFgv6Zc4cJ34m0hd7J+juDObwC5r5VSVo+V2hzgTVHzvSWLINy8J40kD4RxwzGo Ew6VkNC6pW6+YkBBNGXC1hxu11QizWSwmWg6FRgpocb7rAztTKaD9bv6XODT3H11aODEPA6ETnUfX rW7KMHlbANOl55oIyqFUfKRqFJxgP+ufA3IQ6HBMwhYKN8OvO8lHb7AynB7CbMsr9m9tf5otCIG0/ 0Y+I/XJNB51gfnA6UqJFxx/knPoIVtxqQdl2WM7PK+051qibjqBwrk5QWCof4DdLhiIc0KQBLoXqi aGYAGgVGg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2qj3-00036m-A3; Tue, 04 Aug 2020 06:47:05 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2qiz-00035B-TJ for linux-arm-kernel@lists.infradead.org; Tue, 04 Aug 2020 06:47:03 +0000 Received: by mail-pl1-x642.google.com with SMTP id bh1so9204676plb.12 for ; Mon, 03 Aug 2020 23:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=DnhGljgxfzJeLlq9y9e/7VwoaSWViejckL3W26FCQPY=; b=UueG+3z15qVK2BxckVCRjepMJOMHSHdHWYx8MT/s56DT3z3RtFe/nSLY6u9tf2ZzJ8 eMXgwJqof8xUczI7iHjHGThgYrEfWavNmoupNofQO6/R2wsJm1NzglZgMAwhp+yknPDK wXa2CW0UqNzxav/1My/2A6rIXJ5YKQXFsJsuko0rDuZ26pwovnAbcbt36OQOSjbSt8LR aCN8S7hG5dMZHcRB84/FG46LoCP6ZDI525Awim5YurR0M1wKIXOen6IsIg7ArGlt0LBm 5KuKYW03vVO0btus6/4Yg3chKAwddsyu2AFaisM3kjURSRe048PgLImAUFCF8knh+LE1 H01Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=DnhGljgxfzJeLlq9y9e/7VwoaSWViejckL3W26FCQPY=; b=kCcFigIDitMVFlK9+jiYcSALqFs0tGgjiGM4+KTWlHSVVw1xO+FaNZetA6DMDuk0BP 9UNslrKwy4btH2s6HKClEU36zI9KlamBll13r5azvh8pFWEDSpkOb/aj59nD0GYBwlQ1 njDdzrgFdxRjRksBd6AKHmGzDZ7mJh9UkIG0uAkJgeGudJAwHfP0woZNjh+xemB0Yaza v5fhVrkQE3m+xPtXJAWirEK5zNY5enj+ekzwsYo4FbMStHIVXPR/Ah7YNe6jFV6eODVq GppdN+nsQ7b/YWiLqovP4wzNvC3IxJ+b+S+Rz4E7VU5q/j2+M9hRvRnTU9Xa6d54knPZ wPSw== X-Gm-Message-State: AOAM531/sqRtn0oSR6xXLUd+eReE52GnAf1QVP0g7cfiUd2FQerPfm9n i1Muj6A6g6atul93OFH1kP6N0g== X-Google-Smtp-Source: ABdhPJwJkKqdgXZJK1wqpAHnVHCHlWOIav+LLGoSZfd5dZ34R0P644MLXYy4TL5d6mUKKMaqtgjCVQ== X-Received: by 2002:a17:902:6bc2:: with SMTP id m2mr18395916plt.158.1596523619660; Mon, 03 Aug 2020 23:46:59 -0700 (PDT) Received: from localhost ([122.162.244.227]) by smtp.gmail.com with ESMTPSA id u26sm20550893pgo.71.2020.08.03.23.46.58 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Aug 2020 23:46:58 -0700 (PDT) Date: Tue, 4 Aug 2020 12:16:56 +0530 From: Viresh Kumar To: Ionela Voinescu Subject: Re: [PATCH v2 4/7] cpufreq: report whether cpufreq supports Frequency Invariance (FI) Message-ID: <20200804064656.h25yapthuumdxjw7@vireshk-mac-ubuntu> References: <20200722093732.14297-1-ionela.voinescu@arm.com> <20200722093732.14297-5-ionela.voinescu@arm.com> <20200730044346.rgtaikotkgwdpc3m@vireshk-mac-ubuntu> <20200803152400.GB20312@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200803152400.GB20312@arm.com> User-Agent: NeoMutt/20170609 (1.8.3) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200804_024701_981803_E1535D25 X-CRM114-Status: GOOD ( 14.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, peterz@infradead.org, catalin.marinas@arm.com, rjw@rjwysocki.net, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, mingo@redhat.com, sudeep.holla@arm.com, will@kernel.org, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03-08-20, 16:24, Ionela Voinescu wrote: > Right, cpufreq_register_driver() should check that at least one of them > is present > (although currently cpufreq_register_driver() will return > -EINVAL if .fast_switch() alone is present - something to be fixed). I think it is fine as there is no guarantee from cpufreq core if .fast_switch() will get called and so target/target_index must be present. We can't do fast-switch today without schedutil (as only that enables it) and if a notifier gets registered before the driver, then we are gone again. > Will do, on both accounts. > > > > > + static_branch_enable_cpuslocked(&cpufreq_set_freq_scale); > > > + pr_debug("%s: Driver %s can provide frequency invariance.", > > > + __func__, driver->name); > > > > I think a simpler print will work well too. > > > > pr_debug("Freq invariance enabled"); > > > > I think the right way of reporting this support is important here. Yeah, we can't say it is enabled as you explained, though I meant something else here then, i.e. getting rid of driver name and unimportant stuff. What about this now: pr_debug("supports frequency invariance"); This shall get printed as this finally: cpufreq: supports frequency invariance -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel