From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD418C433DF for ; Wed, 5 Aug 2020 12:38:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6CF4E206D7 for ; Wed, 5 Aug 2020 12:38:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FvKR71oc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6CF4E206D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eXl1ICyyjl94Q7uwhRz7geNQWrG7n4XRvWtkl4tsAbY=; b=FvKR71ocETz4eq6YEkHrmVqrs hIMv7nm3rK6s4dfl0NEuDvVpw+q9oFvxg4z2W3DErJbTol7lbYlIKkc9vVlfPabmF78q4UURWhera +p3m3sUMo3cHWUSb5Y/nmZdG4s6JI6xLIQGLb2NOlg0XQoC0DJ4QcJsRMR4C47VtfU5wFlzNSfODN ZY32nZMk4xarxIW8axTMVSCYrbueJ7A2QpS49YnLLZDL1+Cpsjh1c8yw2+a9RBMpqfkgqSSwNJY01 3r2SfcmYTqzyeGcwnckj0bTLSNdD+hSYs0yNqX2XZjkgfQF9XrfIJE3HATPb3MSfsO7MXCeqF8Y7g s8wT+Gdzg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3IfA-0007W5-Pw; Wed, 05 Aug 2020 12:36:56 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3If7-0007Vg-L2 for linux-arm-kernel@lists.infradead.org; Wed, 05 Aug 2020 12:36:54 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F37F230E; Wed, 5 Aug 2020 05:36:48 -0700 (PDT) Received: from bogus (unknown [10.37.12.53]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E18173FA1C; Wed, 5 Aug 2020 05:36:46 -0700 (PDT) Date: Wed, 5 Aug 2020 13:36:43 +0100 From: Sudeep Holla To: Florian Fainelli Subject: Re: [PATCH 0/4] CPUFreq statistics retrieved by drivers Message-ID: <20200805123643.GB4818@bogus> References: <20200729151208.27737-1-lukasz.luba@arm.com> <20200730085333.qubrsv7ufqninihd@vireshk-mac-ubuntu> <20200730091014.GA13158@bogus> <3b3a56e9-29ec-958f-fb3b-c689a9389d2f@arm.com> <20200731155650.GC14529@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200805_083653_762925_86F8E233 X-CRM114-Status: GOOD ( 24.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, Viresh Kumar , rjw@rjwysocki.net, linux-kernel@vger.kernel.org, cristian.marussi@arm.com, Sudeep Holla , Lukasz Luba , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 04, 2020 at 10:19:23AM -0700, Florian Fainelli wrote: > > > On 7/31/2020 8:56 AM, Sudeep Holla wrote: > > On Thu, Jul 30, 2020 at 10:36:51AM +0100, Lukasz Luba wrote: > >> > >> In this case I think we would have to create debugfs. > >> Sudeep do you think these debugfs should be exposed from the protocol > >> layer: > >> drivers/firmware/arm_scmi/perf.c > > > > I prefer above over cpufreq as we can support for all the devices not > > just cpus which avoids adding similar support elsewhere(mostly devfreq) > > > >> or maybe from the cpufreq scmi driver? I would probably be safer to have > >> it in the cpufreq driver because we have scmi_handle there. > >> > > > > Cristian was thinking if we can consolidate all such debugfs under one > > device may be and that should eliminate your handle restriction. I would > > like to see how that works out in implementation but I don't have any > > better suggestion ATM. > > debugfs is not enabled in production kernels, and especially not with > Android kernels, so sticking those in sysfs like the existing cpufreq > subsystem statistics may be a better choice. Fair enough. I was suggesting that only if we can't push this into existing sysfs support. If we can, then we need not worry about it. If not, I don't want a user ABI just for SCMI for this firmware stats, I would rather keep it in debugfs for debug purposes. This will be useless once we start seeing AMU in the hardware and hence I was pushing for debugfs. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel