From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: frederic.chen@mediatek.com
Cc: Sean.Cheng@mediatek.com,
laurent.pinchart+renesas@ideasonboard.com,
christie.yu@mediatek.com, srv_heupstream@mediatek.com,
tfiga@chromium.org, sj.huang@mediatek.com, yuzhao@chromium.org,
hans.verkuil@cisco.com, zwisler@chromium.org,
matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org,
mchehab@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH V2,1/1] media: mc-device.c: change media_device_request_alloc to match media_ioctl_info
Date: Sun, 9 Aug 2020 01:04:19 +0300 [thread overview]
Message-ID: <20200808220419.GY6186@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200806155822.3772-2-frederic.chen@mediatek.com>
Hi Frederic,
Thank you for the patch.
On Thu, Aug 06, 2020 at 11:58:22PM +0800, frederic.chen@mediatek.com wrote:
> From: Frederic Chen <frederic.chen@mediatek.com>
>
> We modified the type of media_device_request_alloc()'s second
> parameter from int* to void* so that it can match the interface
> defined in struct media_ioctl_info.
>
> Signed-off-by: Frederic Chen <frederic.chen@mediatek.com>
This looks fine to me.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/mc/mc-device.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/mc/mc-device.c b/drivers/media/mc/mc-device.c
> index da8088351135..6b66c2091bae 100644
> --- a/drivers/media/mc/mc-device.c
> +++ b/drivers/media/mc/mc-device.c
> @@ -370,9 +370,10 @@ static long media_device_get_topology(struct media_device *mdev, void *arg)
> return ret;
> }
>
> -static long media_device_request_alloc(struct media_device *mdev,
> - int *alloc_fd)
> +static long media_device_request_alloc(struct media_device *mdev, void *arg)
> {
> + int *alloc_fd = arg;
> +
> #ifdef CONFIG_MEDIA_CONTROLLER_REQUEST_API
> if (!mdev->ops || !mdev->ops->req_validate || !mdev->ops->req_queue)
> return -ENOTTY;
> @@ -407,7 +408,7 @@ static long copy_arg_to_user(void __user *uarg, void *karg, unsigned int cmd)
> #define MEDIA_IOC_ARG(__cmd, func, fl, from_user, to_user) \
> [_IOC_NR(MEDIA_IOC_##__cmd)] = { \
> .cmd = MEDIA_IOC_##__cmd, \
> - .fn = (long (*)(struct media_device *, void *))func, \
> + .fn = func, \
> .flags = fl, \
> .arg_from_user = from_user, \
> .arg_to_user = to_user, \
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-08-08 22:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 15:58 [PATCH V2, 0/1] media: change media_device_request_alloc to match media_ioctl_info frederic.chen
2020-08-06 15:58 ` [PATCH V2, 1/1] media: mc-device.c: " frederic.chen
2020-08-08 22:04 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200808220419.GY6186@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=Sean.Cheng@mediatek.com \
--cc=christie.yu@mediatek.com \
--cc=frederic.chen@mediatek.com \
--cc=hans.verkuil@cisco.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=sj.huang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
--cc=yuzhao@chromium.org \
--cc=zwisler@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).