From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A481C433DF for ; Mon, 10 Aug 2020 14:16:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1CED42076B for ; Mon, 10 Aug 2020 14:16:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hy1ZblpR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CED42076B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5DkOwVpgiMNjN4LYlgLxPnQVfwq9L6jAxfMawd/1dR8=; b=hy1ZblpR9OTPvF5rv3kqM6GwS Vc8fZyjlLTnr1Mdpvh5L9+PiQfOgy+qfkEHBMaTNxPIsiS02zEH3WN4jMij50h1xM+cSqGyYs0M+Y 0c4QRYMSPJlZIrs0xRG55h4ucWG70NX0wMWDThIEFrSitH7TUnrsorNme3Rz70SOFjCgGuOVm0ISW VRZDr+VZ1mHJyCmQB0OyPFi8+Iua2Dw92x1VaCkV0fOLbfaLZBj3xt1QSLp2vBm2N6b0700CF85iy lnAYgt1OCGZAfbPyj+6td+lOkoiyxZqcqHZhGWTFiKDzgHfrRwrnEmTIaLZmGMN9yiWb9xeo00f8k bi5t8H09w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k58aN-0005Yr-AE; Mon, 10 Aug 2020 14:15:35 +0000 Received: from mail-ed1-f68.google.com ([209.85.208.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k58aJ-0005Y8-GG for linux-arm-kernel@lists.infradead.org; Mon, 10 Aug 2020 14:15:32 +0000 Received: by mail-ed1-f68.google.com with SMTP id bs17so6513825edb.1 for ; Mon, 10 Aug 2020 07:15:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/9w3jeHQu0tGGSbBjCL27CGFJj/E1cqCv8uax1z96uE=; b=Om8e21qCngtCt3oaYxxTqVuonK9NOt8Kdk4wYm3mP1M91/0STXrwJ6umiFeArDku76 IxMZKkV0fkFN7W5YdaLTFMWA0IoNMcdsaLsDOecwZ+uL4KTYWztPdtzBybO9R0kLlf6H 9XXpaXEwE0e2nIuf6oW62HjijrREPNaOjmBK+jWajjKQFJ4Np8Fl06snHxytu11GRv/4 Mkrfa9kv4fGmixJWydUwOE8lxqtV7b8YtwTEh1GWaHSFlfhCup2zwieU78M02VqVlK2d KFiJ8RH1qIK/OSh/1dWdW6h3VlQ7hD40Gf95vdyGFvQlLYI42yI/rPQCgQlb2wI7KeXM ljzw== X-Gm-Message-State: AOAM530Us4ZZQhXPaKJ9xE5GY5+o/0dv1zLlxBOghNsDFtfJ06UxFaT+ dW+0wW9SL3ITXaC5LY4Japw= X-Google-Smtp-Source: ABdhPJwln4xOfhbOSKOZ+8uP/TEgLEw/XTopL0JiulzbP60CYhCX+ZiXbmfrXBY/H9XrTHJk0GskSg== X-Received: by 2002:a05:6402:1504:: with SMTP id f4mr21756997edw.163.1597068929268; Mon, 10 Aug 2020 07:15:29 -0700 (PDT) Received: from pi3 ([194.230.155.117]) by smtp.googlemail.com with ESMTPSA id t18sm13397113ejf.38.2020.08.10.07.15.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2020 07:15:28 -0700 (PDT) Date: Mon, 10 Aug 2020 16:15:26 +0200 From: Krzysztof Kozlowski To: Tamseel Shams Subject: Re: [RFT PATCH v5] serial: samsung: Removes the IRQ not found warning Message-ID: <20200810141526.GA12448@pi3> References: <20200810030021.45348-1-m.shams@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200810030021.45348-1-m.shams@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200810_101531_550782_F563642F X-CRM114-Status: GOOD ( 16.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, kgene@kernel.org, linux-serial@vger.kernel.org, jslaby@suse.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 10, 2020 at 08:30:21AM +0530, Tamseel Shams wrote: > In few older Samsung SoCs like s3c2410, s3c2412 > and s3c2440, UART IP is having 2 interrupt lines. > However, in other SoCs like s3c6400, s5pv210, > exynos5433, and exynos4210 UART is having only 1 > interrupt line. Due to this, "platform_get_irq(platdev, 1)" > call in the driver gives the following false-positive error: > "IRQ index 1 not found" on newer SoC's. > > This patch adds the condition to check for Tx interrupt > only for the those SoC's which have 2 interrupt lines. > > Signed-off-by: Tamseel Shams > --- > Commit message is changed. > > Added RFT, for older platform. > > Addressed Krzysztof's review comments [1] > [1] -> https://lkml.org/lkml/2020/7/21/150 > > drivers/tty/serial/samsung_tty.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel