From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03781C433E0 for ; Tue, 11 Aug 2020 22:41:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1B4B2076C for ; Tue, 11 Aug 2020 22:41:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nL4Dyd2h"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Q+Mr4NjN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1B4B2076C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bazjy+XcFremw1GSrxI+4HlN/VXau4kXYqnEbA4nxu4=; b=nL4Dyd2hntNj6m7sxTWM82dQ9 pYvlAjkX7QU9PkhRp971PgDVfSwuj3irhwcoUg3DF8HI8rO8sfbBetwpgT4rfBw/ALwtjga1RZ2PL n7dvlCayIt6mYPAkSZThPh5hmr1DnRh5onaCzTFzyDH/6TOaQxvA2Ei2AAi/coXZHi3P5fPJTjN52 ocbq+6XM5Foy1D2y/uF6aGHcAYL90Qd6oasrztWlvhXQjXhxHgVZu8fKeXTkh1goRkpz5AWtOzZgk 9IvndaBtsmNlSLN1kEmcgmB+WPU7jAuMSxYpJUa//2oFwX5OLsHHS70OzdfO0mv3EcUJ3N/Hzv37e V7LlgEMuw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5cwf-0006za-At; Tue, 11 Aug 2020 22:40:37 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5cwc-0006yq-LL for linux-arm-kernel@lists.infradead.org; Tue, 11 Aug 2020 22:40:36 +0000 Received: by mail-pf1-x442.google.com with SMTP id m71so19285pfd.1 for ; Tue, 11 Aug 2020 15:40:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oHyQTUvTUFNtPnfXB354eAFfqwmcdKEgh8qUciOM6ac=; b=Q+Mr4NjN6PyImpPTNKKWFG/Z5AoMhj9JWM8jtgqV/wwe3AMGAtvjfyZBX6qbvMR4gS jEE2gjM7SLo/oV7nYKYoE7s3SXRHNKUYSy71EhTAdC4vlNHYTXhjzxm8D16lKWy/9VP0 6GxhrytItisbuM1vsjS+C6vACracgq2Lu0gS5ePRWJayQXP8eBWqh4JOwgm/HnHHIoZs adEqh/yuqxIdRaMkkMYVlk26ATTJQogmOkk3f2Jo0i+1j/1ewgf1n84x6ace81t5P2ks D1v20OwnPrvV+L/Yunwv3j/HGI1tXyUYeNGTmircrYjn6G3f0UI70CIc57DEjbCFxUHL YJdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oHyQTUvTUFNtPnfXB354eAFfqwmcdKEgh8qUciOM6ac=; b=ma1l3xX6a2skRSB8lw+jWZ1OQf/hF9ja6c1Onx0FjiZjnzzssnCjddIv9RKEwrkt+h Ln5RkhU23B3pmHk8/nAEmtCjy8Epz+Df/ifvbFQeWBPvPxTmz2HFFMrXPoh2Im3KuY3Q wHMysC1XtSyh2qjX5KDuKCfn0XIl1JRzT6sR61gfReVQGfHIQJO4osoJl/eWJnOuJagJ EzonaD8IjkKvCNWQc7B3dJGepJcyS7VjZQrlH32nZ3s+1N4RuVE0ZXwY8Q+caWqAhSye kwhEAVItgJAbGSbZfmoQiS8+NOnF4nQQtbTShkJTLs6jf3ifM/WRlvnEE9BD6pDV7Dfg 4t8g== X-Gm-Message-State: AOAM5301ot/xPbXWjgi5AOxf3GyXvm4ym8YFmISu3Q9ZoRLOlm5337dB +XRHsA3/WXM671Qe0BsA45fKfA== X-Google-Smtp-Source: ABdhPJxZbnhyHXEuAi6bn+/WtHF0uq2xziDKvJZWF/LkfqD8tkRi5PWfAoTWSGeKiZbvWFHQfirOrA== X-Received: by 2002:a62:6186:: with SMTP id v128mr8416919pfb.211.1597185632526; Tue, 11 Aug 2020 15:40:32 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id x136sm115500pfc.28.2020.08.11.15.40.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2020 15:40:31 -0700 (PDT) Date: Tue, 11 Aug 2020 16:40:29 -0600 From: Mathieu Poirier To: Peng Fan Subject: Re: [PATCH 04/10] remoteproc: imx_rproc: make syscon optional Message-ID: <20200811224029.GE3370567@xps15> References: <20200724080813.24884-1-peng.fan@nxp.com> <20200724080813.24884-5-peng.fan@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200724080813.24884-5-peng.fan@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200811_184035_564747_12A458F8 X-CRM114-Status: GOOD ( 20.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, festevam@gmail.com, s.hauer@pengutronix.de, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, o.rempel@pengutronix.de, robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 24, 2020 at 04:08:07PM +0800, Peng Fan wrote: > Make syscon optional, since i.MX8QM/QXP/7ULP not have SRC to control M4. > But currently i.MX8QM/QXP/7ULP not added, so still check regmap > when start/stop to avoid unhappy things. > > Reviewed-by: Richard Zhu > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 82594a800a1b..4fad5c0b1c05 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -162,6 +162,9 @@ static int imx_rproc_start(struct rproc *rproc) > struct device *dev = priv->dev; > int ret; > > + if (!priv->regmap) > + return -EOPNOTSUPP; Proceeding this way is hard to maintain. I would perfer to add specific operations based on the scenario or coprocessor we are working with. > + > ret = regmap_update_bits(priv->regmap, dcfg->src_reg, > dcfg->src_mask, dcfg->src_start); > if (ret) > @@ -177,6 +180,9 @@ static int imx_rproc_stop(struct rproc *rproc) > struct device *dev = priv->dev; > int ret; > > + if (!priv->regmap) > + return -EOPNOTSUPP; > + > ret = regmap_update_bits(priv->regmap, dcfg->src_reg, > dcfg->src_mask, dcfg->src_stop); > if (ret) > @@ -325,9 +331,10 @@ static int imx_rproc_probe(struct platform_device *pdev) > regmap = syscon_regmap_lookup_by_phandle(np, "syscon"); > if (IS_ERR(regmap)) { > dev_err(dev, "failed to find syscon\n"); > - return PTR_ERR(regmap); > + regmap = NULL; > + } else { > + regmap_attach_dev(dev, regmap, &config); Here you are altering how all the existing implemenation are currently working. Add a new field to imx_rproc_dcfg and based on that, determine if a regmap is mandatory or not. > } > - regmap_attach_dev(dev, regmap, &config); > > /* set some other name then imx */ > rproc = rproc_alloc(dev, "imx-rproc", &imx_rproc_ops, > -- > 2.16.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel