From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33D70C433E0 for ; Wed, 12 Aug 2020 20:49:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EEEF62076C for ; Wed, 12 Aug 2020 20:49:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hUb4uaCg"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bJdkwAsh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEEF62076C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VG6KqHlCRvYZLCO2/HcmOYY+KN4tKRsUWwRjinfoCAk=; b=hUb4uaCgPjrG8BLl95D8nf5Br x5UnP2axv9U5UQqNyzLuTRT4aVT0xNlSv8Pf77m+3VlpFuG3gjc/gtG6iy7VdEt7pPYwWtI2Ud5zZ f1QFl5Kg5MKl7stEDC/8V/x3nOIt21lPJiHdx3Z6koxUOfdQ/1F08q7w+/Ns/XT8Nw7juZlxCc4ey WfuuZo78gNs+qfxwvBbtsMEraToJMOyRMrKGO7aV5j4/kiC/QMtMWNHO5+jh8AdwxHowUNvANNWNz Jl+LTQIIxq+Vjt3FT1xDIc2W4gWYulztqoU9h8IGKfoOm7qtrDdmppfMH2jHnn6rcP8zqyWc2SvCO tITbXY6Hg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5xf6-0006ct-18; Wed, 12 Aug 2020 20:47:52 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5xf2-0006bm-RK for linux-arm-kernel@lists.infradead.org; Wed, 12 Aug 2020 20:47:50 +0000 Received: by mail-pf1-x441.google.com with SMTP id k18so1615134pfp.7 for ; Wed, 12 Aug 2020 13:47:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iGjIpq1FcK1cN8wFYgVYraDDmbXg+MvL4hi+CFoQSeY=; b=bJdkwAshEe5TVIHgUS1RXxRh427RrOxRBDteWU0iBbO5gcjmSZ72pvrgo92MBlV1zP +pmSb9UkHQQlswu4/EFrzxkozCjmh4lau1eEPAu8hmlYM8uMRE9Agp5MyzxsoT+c5Nx7 vKx45iWBpXDIRTNAj78K5fJFdd4sXN/8Lq4pm0+eUieLhTEhlTJypkYlQ3OREfLkGb41 rqp8lsws2pb8erHFKoSiYqKPOaFGMrepiKCp8eufm8lpz0iuSXDCLJxw9/af0G++ld9L CFpnHTBvfBywsAPU7SoOeZUn9fvg2kNlKHuYQDweFlsw83HnbnVjbm9Gj9+/gHO+PBzX pjLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iGjIpq1FcK1cN8wFYgVYraDDmbXg+MvL4hi+CFoQSeY=; b=m4Al91ZRNuSe6QTPMvY9c4vuhFgS6RZVsA38neKEQ9JzfC84s4IPEXvOtWE7Zf6x+Z SiROud0Cz9syzWxLrJ6WxPlLsL/ddF82YeEFqni+hef0QBOu5wvtIzpBn+41/CAfhj+C MgM8Gl1xkKcpyYfdyxKWww5SYDA2s/2cZCfaF+gpC577i81uPtheTWv9ryUJRJKxT8f+ J6BxktiW7mOfm+jrxE8ukfR6B+fUAbc7DZPMwFisiZmN42iea9hczTy6RZJZMp7Cg3zT Jybz2o8oBRbwGT9R1W1c7gZl1+78zZfNmoj+j6IlGyj5P/cZCKuBv6nn47qUV5EFJW9l Xrrg== X-Gm-Message-State: AOAM532xLEcK10NdebVjhiZDTRaZcGmsit1+gIZQMcqxASxPi8JuiWnC Plv6QB71/+Y6ZmfDTrNBoojbxQ== X-Google-Smtp-Source: ABdhPJz3Fpeg5FrtuJxmODXcOImWSF/rGEP7HEpb7rUOBs+TzH5zB3Wno9dkIkj/edU9SAsSzBQw7g== X-Received: by 2002:a05:6a00:15cb:: with SMTP id o11mr1234384pfu.263.1597265264390; Wed, 12 Aug 2020 13:47:44 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id q13sm3070919pjj.36.2020.08.12.13.47.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2020 13:47:43 -0700 (PDT) Date: Wed, 12 Aug 2020 14:47:41 -0600 From: Mathieu Poirier To: Tingwei Zhang Subject: Re: [PATCH v8 09/24] coresight: etm3x: allow etm3x to be built as a module Message-ID: <20200812204741.GF3393195@xps15> References: <20200807111153.7784-1-tingwei@codeaurora.org> <20200807111153.7784-10-tingwei@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200807111153.7784-10-tingwei@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200812_164749_118826_7E234D9A X-CRM114-Status: GOOD ( 29.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, Sai Prakash Ranjan , Kim Phillips , Mao Jinlong , Suzuki K Poulose , Alexander Shishkin , Greg Kroah-Hartman , coresight@lists.linaro.org, Randy Dunlap , Mian Yousaf Kaukab , Russell King , Leo Yan , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 07, 2020 at 07:11:38PM +0800, Tingwei Zhang wrote: > From: Kim Phillips > > Allow to build coresight-etm3x as a module, for ease of development. > > - Kconfig becomes a tristate, to allow =m > - append -core to source file name to allow module to > be called coresight-etm3x by the Makefile > - add an etm_remove function, for module unload > - add a MODULE_DEVICE_TABLE for autoloading on boot > > Cc: Mathieu Poirier > Cc: Leo Yan > Cc: Alexander Shishkin > Cc: Randy Dunlap > Cc: Suzuki K Poulose > Cc: Greg Kroah-Hartman > Cc: Russell King > Signed-off-by: Kim Phillips > Signed-off-by: Tingwei Zhang > Reviewed-by: Mike Leach > --- > drivers/hwtracing/coresight/Kconfig | 5 +++- > drivers/hwtracing/coresight/Makefile | 3 ++- > ...resight-etm3x.c => coresight-etm3x-core.c} | 27 ++++++++++++++++++- > 3 files changed, 32 insertions(+), 3 deletions(-) > rename drivers/hwtracing/coresight/{coresight-etm3x.c => coresight-etm3x-core.c} (97%) > > diff --git a/drivers/hwtracing/coresight/Kconfig b/drivers/hwtracing/coresight/Kconfig > index 6433f835fc97..8fd9fd139cf3 100644 > --- a/drivers/hwtracing/coresight/Kconfig > +++ b/drivers/hwtracing/coresight/Kconfig > @@ -65,7 +65,7 @@ config CORESIGHT_SINK_ETBV10 > special enhancement or added features. > > config CORESIGHT_SOURCE_ETM3X > - bool "CoreSight Embedded Trace Macrocell 3.x driver" > + tristate "CoreSight Embedded Trace Macrocell 3.x driver" > depends on !ARM64 > select CORESIGHT_LINKS_AND_SINKS > help > @@ -74,6 +74,9 @@ config CORESIGHT_SOURCE_ETM3X > This is primarily useful for instruction level tracing. Depending > the ETM version data tracing may also be available. > > + To compile this driver as a module, choose M here: the > + module will be called coresight-etm3x. > + > config CORESIGHT_SOURCE_ETM4X > bool "CoreSight Embedded Trace Macrocell 4.x driver" > depends on ARM64 > diff --git a/drivers/hwtracing/coresight/Makefile b/drivers/hwtracing/coresight/Makefile > index 19497d1d92bf..d619cfd0abd8 100644 > --- a/drivers/hwtracing/coresight/Makefile > +++ b/drivers/hwtracing/coresight/Makefile > @@ -11,7 +11,8 @@ obj-$(CONFIG_CORESIGHT_SINK_TPIU) += coresight-tpiu.o > obj-$(CONFIG_CORESIGHT_SINK_ETBV10) += coresight-etb10.o > obj-$(CONFIG_CORESIGHT_LINKS_AND_SINKS) += coresight-funnel.o \ > coresight-replicator.o > -obj-$(CONFIG_CORESIGHT_SOURCE_ETM3X) += coresight-etm3x.o coresight-etm-cp14.o \ > +obj-$(CONFIG_CORESIGHT_SOURCE_ETM3X) += coresight-etm3x.o > +coresight-etm3x-y := coresight-etm3x-core.o coresight-etm-cp14.o \ > coresight-etm3x-sysfs.o > obj-$(CONFIG_CORESIGHT_SOURCE_ETM4X) += coresight-etm4x.o \ > coresight-etm4x-sysfs.o > diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c b/drivers/hwtracing/coresight/coresight-etm3x-core.c > similarity index 97% > rename from drivers/hwtracing/coresight/coresight-etm3x.c > rename to drivers/hwtracing/coresight/coresight-etm3x-core.c > index bf22dcfd3327..82b333c40006 100644 > --- a/drivers/hwtracing/coresight/coresight-etm3x.c > +++ b/drivers/hwtracing/coresight/coresight-etm3x-core.c > @@ -895,6 +895,23 @@ static int etm_probe(struct amba_device *adev, const struct amba_id *id) > return ret; > } > > +static int __exit etm_remove(struct amba_device *adev) > +{ Not sure adding __exit does anything special here since all the code is removed by the kernel anyway. The same comment goes for the other drivers in this set. > + struct etm_drvdata *drvdata = dev_get_drvdata(&adev->dev); > + > + etm_perf_symlink(drvdata->csdev, false); > + > + if (--etm_count == 0) { > + cpuhp_remove_state_nocalls(CPUHP_AP_ARM_CORESIGHT_STARTING); > + if (hp_online) > + cpuhp_remove_state_nocalls(hp_online); > + } > + > + coresight_unregister(drvdata->csdev); > + > + return 0; > +} > + > #ifdef CONFIG_PM > static int etm_runtime_suspend(struct device *dev) > { > @@ -937,6 +954,8 @@ static const struct amba_id etm_ids[] = { > { 0, 0}, > }; > > +MODULE_DEVICE_TABLE(amba, etm_ids); > + > static struct amba_driver etm_driver = { > .drv = { > .name = "coresight-etm3x", > @@ -945,6 +964,12 @@ static struct amba_driver etm_driver = { > .suppress_bind_attrs = true, > }, > .probe = etm_probe, > + .remove = etm_remove, > .id_table = etm_ids, > }; > -builtin_amba_driver(etm_driver); > +module_amba_driver(etm_driver); > + > +MODULE_AUTHOR("Pratik Patel "); > +MODULE_AUTHOR("Mathieu Poirier "); > +MODULE_DESCRIPTION("Arm CoreSight Program Flow Trace driver"); That should be "Arm CoreSight Embedded Trace Macrocell 3.x driver" With the above: Reviewed-by: Mathieu Poirier > +MODULE_LICENSE("GPL v2"); > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel