From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9630BC433E0 for ; Wed, 12 Aug 2020 20:49:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5DA5E2076C for ; Wed, 12 Aug 2020 20:49:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="m8slJp0+"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="moZAWXox" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5DA5E2076C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ub8d2w8yhbzVDtRzXPDSZhR/TGnGfvgNaVuHXdjOf/0=; b=m8slJp0+VPz/dHJqZIfLplS6g 8H/DId0DhYvwyc3ZoCcGbh3GaoY4ipeKmzPQH9Nvw2EIonIS3p4vuOv2HaBH5flsnaQ4zjv5PAMaY QYlLV1K0T3shAWVkXvNuOIJh4OVFW+rvbhtKDHmso0lP+WsVTWHyhjDFl8a6tMtgsWy3/ZvuiiMm2 JnP51p4360y0LYrD/QNDTAXOlU650u3z/OJINx/KXsRgOFbJESnuxetURHTySUYVmOtYixPRhD5q/ SQGaqrp1b2dSx7JonLg1l6/2+VJye4reLZ6+u2aX+gYIY8IavGx8XPRhLHstT9Wuk5rGdXzBfY93P 9ypL0gozA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5xfe-0006hq-3f; Wed, 12 Aug 2020 20:48:26 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5xfc-0006gz-8G for linux-arm-kernel@lists.infradead.org; Wed, 12 Aug 2020 20:48:25 +0000 Received: by mail-pl1-x641.google.com with SMTP id t10so1625652plz.10 for ; Wed, 12 Aug 2020 13:48:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ifoQDAQDRJj/KpEiiiICSfnuG2JjpOqK6d1q9nZC2/o=; b=moZAWXox8xitKVm/XizQJ3+Jm1McbUgftg6JeammRmKyrmQDgBgsz7fOd1hmLPNu9e mDBn8bLCgFa0hjwhVmh/A+d4XLHdC6zwIUG3t/NZjrCu24LmGEQqtMxVPtGnbIVhP2DW 9TMVU5hb3AwCh0mfsrs/PLYZotgtD4PpWZIP5k+ZhaH1mNwKH4ovsx3U+pxtXkEVZ9vy jRyHT/gETbCR9tiHLn2c3G04XWdWo71M8lYdn9ze5mMAb0Eexlbwri+4pp7M8OfW1+2L 9OhLxPxjYL+3w4yXKW8j5mVlkYBNEeChhlrlzY2LfWH3EdflCSSWp+UPJsMKqE3hZgSg Av4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ifoQDAQDRJj/KpEiiiICSfnuG2JjpOqK6d1q9nZC2/o=; b=NF4QLPccJpzO/tjviCMfn6rA0f0cqrfkxbrArjLhWaqHMyBTeUXbD/S0Uk9jWHTCux nFx+YvK+AvSUosySn2yaLSPNkUnpETc1iFChzA7yDOoXKmtaaYq0B9gp1kAkbbTG1OYI QXPq+Us2wGCWfSqeQvGBJSsE/H+6JuYl/VzjrCP3GhefBDnXVPGJENDVPsolVvUC99/S Ro4kgca9c0NaIcmAgjlnolt1RSsrpMGuu2gJ4wY1+ZKrbxI2FGHXpa9bvBJudLPpvqX5 h7ftaXzIV24v9w9YZDEqLO8seZtgv78avDVNpLRJFTFiQWpwWLXWUt7S/7kulKoqOA/B KoOQ== X-Gm-Message-State: AOAM532GyHKTv5ejiINwnasrVklFknrxyKH4GVj5Oekvw1gRp8uHYzY3 trapO3pSOEFNRIWqHr621rhdPQ== X-Google-Smtp-Source: ABdhPJzMmvOaAHp9H+DV0kxItQbWMBOdV3GrqSSAFpW+UezKdQ7g4WTtzJK2nRzZWV+5rhTYYWPheQ== X-Received: by 2002:a17:90a:fc98:: with SMTP id ci24mr1872799pjb.101.1597265302253; Wed, 12 Aug 2020 13:48:22 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id m23sm2969147pgv.43.2020.08.12.13.48.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2020 13:48:21 -0700 (PDT) Date: Wed, 12 Aug 2020 14:48:19 -0600 From: Mathieu Poirier To: Tingwei Zhang Subject: Re: [PATCH v8 08/24] coresight: etm: perf: Fix warning caused by etm_setup_aux failure Message-ID: <20200812204819.GG3393195@xps15> References: <20200807111153.7784-1-tingwei@codeaurora.org> <20200807111153.7784-9-tingwei@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200807111153.7784-9-tingwei@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200812_164824_331843_6BB50D52 X-CRM114-Status: GOOD ( 19.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, Sai Prakash Ranjan , Kim Phillips , Mao Jinlong , Suzuki K Poulose , Alexander Shishkin , Greg Kroah-Hartman , coresight@lists.linaro.org, Randy Dunlap , Mian Yousaf Kaukab , Russell King , Leo Yan , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 07, 2020 at 07:11:37PM +0800, Tingwei Zhang wrote: > When coresight_build_path() fails on all the cpus, etm_setup_aux > calls etm_free_aux() to free allocated event_data. > WARN_ON(cpumask_empty(mask) will be triggered since cpu mask is empty. > Check event_data->snk_config is not NULL first to avoid this > warning. > > Fixes: f5200aa9831f38 ("coresight: perf: Refactor function free_event_data()") > Signed-off-by: Tingwei Zhang > Reviewed-by: Mike Leach > Reviewed-by: Suzuki K Poulose For patches 07 and 08: Reviewed-by: Mathieu Poirier > --- > drivers/hwtracing/coresight/coresight-etm-perf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c > index dcb0592418ae..3728c44e5763 100644 > --- a/drivers/hwtracing/coresight/coresight-etm-perf.c > +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c > @@ -126,10 +126,10 @@ static void free_sink_buffer(struct etm_event_data *event_data) > cpumask_t *mask = &event_data->mask; > struct coresight_device *sink; > > - if (WARN_ON(cpumask_empty(mask))) > + if (!event_data->snk_config) > return; > > - if (!event_data->snk_config) > + if (WARN_ON(cpumask_empty(mask))) > return; > > cpu = cpumask_first(mask); > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel