From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Yingjoe Chen <yingjoe.chen@mediatek.com>
Cc: devicetree@vger.kernel.org,
Fengping Yu <fengping.yu@mediatek.com>,
Marco Felsch <m.felsch@pengutronix.de>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org, linux-input@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v17 1/3] dt-bindings: Add bindings for Mediatek matrix keypad
Date: Wed, 12 Aug 2020 15:13:57 -0700 [thread overview]
Message-ID: <20200812221357.GS1665100@dtor-ws> (raw)
In-Reply-To: <1597110443.22273.5.camel@mtksdaap41>
Hi,
On Tue, Aug 11, 2020 at 09:47:23AM +0800, Yingjoe Chen wrote:
> Hi,
>
>
> On Mon, 2020-08-10 at 14:40 +0800, Fengping Yu wrote:
> > From: "fengping.yu" <fengping.yu@mediatek.com>
> >
> > This patch add devicetree bindings for Mediatek matrix keypad driver.
> >
> > Signed-off-by: fengping.yu <fengping.yu@mediatek.com>
> > ---
> > .../devicetree/bindings/input/mtk-kpd.yaml | 87 +++++++++++++++++++
> > 1 file changed, 87 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/input/mtk-kpd.yaml b/Documentation/devicetree/bindings/input/mtk-kpd.yaml
> > new file mode 100644
> > index 000000000000..d74dd8a6fbde
>
> <...>
>
>
> > + keypad,num-columns:
> > + description: Number of column lines connected to the keypad controller,
> > + it is not equal to PCB columns number, instead you should add required value
> > + for each IC. If not specified, the default value is 1.
> > +
> > + keypad,num-rows:
> > + description: Number of row lines connected to the keypad controller, it is
> > + not equal to PCB rows number, instead you should add required value for each IC.
> > + If not specified, the default value is 1.
>
> Your source code can't really handle dts without rows/columns
> properties. Also, the default value doesn't make any sense. No IC will
> have rows or columns set to 1.
>
> Since these are IC specified, not board specified, I think you should
> just have the correct numbers in driver.
It is actually property of board to decide how many keys it wants to
wire up. In extreme case it will be a single key, i.e. number of rows
and columns will indeed be 1.
Thanks.
--
Dmitry
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-12 22:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 6:40 [PATCH v17] Add matrix keypad driver support for Mediatek SoCs Fengping Yu
2020-08-10 6:40 ` [PATCH v17 1/3] dt-bindings: Add bindings for Mediatek matrix keypad Fengping Yu
2020-08-11 1:47 ` Yingjoe Chen
2020-08-12 22:13 ` Dmitry Torokhov [this message]
2020-08-13 5:02 ` Yingjoe Chen
2020-08-12 22:37 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200812221357.GS1665100@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=fengping.yu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=m.felsch@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).