From: Mark Brown <broonie@kernel.org>
To: Jiaxin Yu <jiaxin.yu@mediatek.com>
Cc: alsa-devel@alsa-project.org, shane.chien@mediatek.com,
howie.huang@mediatek.com, tiwai@suse.com,
linux-kernel@vger.kernel.org, tzungbi@google.com,
robh+dt@kernel.org, linux-mediatek@lists.infradead.org,
eason.yen@mediatek.com, matthias.bgg@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] ASoC: mediatek: mt6359: add codec driver
Date: Thu, 13 Aug 2020 16:44:23 +0100 [thread overview]
Message-ID: <20200813154423.GC5541@sirena.org.uk> (raw)
In-Reply-To: <1597333200.23246.68.camel@mhfsdcap03>
[-- Attachment #1.1: Type: text/plain, Size: 1165 bytes --]
On Thu, Aug 13, 2020 at 11:40:00PM +0800, Jiaxin Yu wrote:
> On Wed, 2020-08-12 at 13:05 +0100, Mark Brown wrote:
> > These functions are exported for other drivers to use rather than
> > something done internally by the driver - if this were internal to the
> > driver it'd not be a big deal but when it's for use by another driver
> > it'd be better to go through standard interfaces.
> Can we move this part of the operation to the codec dai driver ops, such
> as .startup and .shutdown? Because originally these functions are
> exported to machine driver's dai_link .startup and .shutdown ops.
If it's internal to the driver sure.
> > So this needs the SoC to do something as part of callibration?
> Yes, the side of MTKAIF in SoC part named adda, we need config it before
> calibration. We will also upstream machine/platform driver that use this
> codec driver later.
It would probably be better to just leave this out for now then add the
required bits to the CODEC driver as part of a patch series that also
adds the machine driver that uses it so it's clear how it all fits
together. It sounds like it should be fine but this'd be easier to
review.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-13 15:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 3:05 [PATCH v2 0/2] Add mediatek codec mt6359 driver Jiaxin Yu
2020-08-10 3:05 ` [PATCH v2 2/2] dt-bindings: mediatek: mt6359: add codec document Jiaxin Yu
[not found] ` <1597028754-7732-2-git-send-email-jiaxin.yu@mediatek.com>
2020-08-10 8:13 ` [PATCH v2 1/2] ASoC: mediatek: mt6359: add codec driver Tzung-Bi Shih
2020-08-10 18:59 ` Mark Brown
2020-08-12 7:29 ` Jiaxin Yu
2020-08-12 12:05 ` Mark Brown
2020-08-13 15:40 ` Jiaxin Yu
2020-08-13 15:44 ` Mark Brown [this message]
2020-08-14 10:27 ` Jiaxin Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813154423.GC5541@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=eason.yen@mediatek.com \
--cc=howie.huang@mediatek.com \
--cc=jiaxin.yu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=shane.chien@mediatek.com \
--cc=tiwai@suse.com \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).