From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78B86C433E1 for ; Mon, 17 Aug 2020 00:05:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 450A920708 for ; Mon, 17 Aug 2020 00:05:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KJehjwSl"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="CL5AvQ5M" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 450A920708 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=G5JFKRVQTeYA85Kp/AzHyGHnfy9BgWvVE61j47PNe4c=; b=KJehjwSlNIJ87tRhlMedHcaxB 1gRlDik5eGNwNP3LGJnXDOQQq4YOoHMsYUbk9PWHA9qEnE2H8+nlf08uDkJUF5Jr1KtNVaUME0hvx 01TbZdF3H5z8zn++fuKMgpFsRH40v7xE8mmE76vXStTyA8Vk258LgcdvXTi/fH4qQ6Yp31D4L/n2e J8vhITj2McOMtFqJjh+AXUaHDHfjMIyjZpmpd9DgzpALDRFEU2TJrL/4J3JAYvaJBzNXqmdPwav4t Vsq1R4Hlf4EAAdLj0yC3w1OSAjD89oJ2h8JsV9FdphlchxcXiBPz2A0BcXCrUKvr/ZTV1vOo//bbP 2wX0ocmfQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7SdX-0008OV-4f; Mon, 17 Aug 2020 00:04:27 +0000 Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7SdT-0008O5-MH for linux-arm-kernel@lists.infradead.org; Mon, 17 Aug 2020 00:04:24 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7990AF9; Mon, 17 Aug 2020 02:04:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1597622662; bh=Osusw+izUNrAmOEtzq1RB1qpF6rnUbzPz1Lw1TxdgP4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CL5AvQ5MvcT0iFtM5YiYFaU6cp5mQ0E1EJTV8BK7qo5iOV0lMYhqLJxBsxe/a52uD 4feOIqe2/bEhkkootjhvJsS52eL9tCa9J/jeL1SMUG+px7lW7WWzSy70r/GDLhHj02 NwmNWw1l+Kem06si58mXYjoeyb3SZJlaVMdoLLao= Date: Mon, 17 Aug 2020 03:04:06 +0300 From: Laurent Pinchart To: Sam Ravnborg Subject: Re: [PATCH 2/8] dt-bindings: display: mxsfb: Add and fix compatible strings Message-ID: <20200817000406.GC7729@pendragon.ideasonboard.com> References: <20200813012910.13576-1-laurent.pinchart@ideasonboard.com> <20200813012910.13576-3-laurent.pinchart@ideasonboard.com> <20200816063933.GC1201814@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200816063933.GC1201814@ravnborg.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200816_200423_880257_122F483E X-CRM114-Status: GOOD ( 22.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , devicetree@vger.kernel.org, Guido =?utf-8?Q?G=C3=BCnther?= , dri-devel@lists.freedesktop.org, Rob Herring , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sam, On Sun, Aug 16, 2020 at 08:39:33AM +0200, Sam Ravnborg wrote: > On Thu, Aug 13, 2020 at 04:29:04AM +0300, Laurent Pinchart wrote: > > Additional compatible strings have been added in DT source for the > > i.MX6SL, i.MX6SLL, i.MX6UL and i.MX7D without updating the bindings. > > Most of the upstream DT sources use the fsl,imx28-lcdif compatible > > string, which mostly predates the realization that the LCDIF in the > > i.MX6 and newer SoCs have extra features compared to the i.MX28. > > > > Update the bindings to add the missing compatible strings, with the > > correct fallback values. This fails to validate some of the upstream DT > > sources. Instead of adding the incorrect compatible fallback to the > > binding, the sources should be updated separately. > > > > Signed-off-by: Laurent Pinchart > > --- > > .../devicetree/bindings/display/mxsfb.yaml | 18 +++++++++++++----- > > 1 file changed, 13 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/mxsfb.yaml b/Documentation/devicetree/bindings/display/mxsfb.yaml > > index 202381ec5bb7..ec6533b1d4a3 100644 > > --- a/Documentation/devicetree/bindings/display/mxsfb.yaml > > +++ b/Documentation/devicetree/bindings/display/mxsfb.yaml > > @@ -15,11 +15,19 @@ description: | > > > > properties: > > compatible: > > - enum: > > - - fsl,imx23-lcdif > > - - fsl,imx28-lcdif > > - - fsl,imx6sx-lcdif > > - - fsl,imx8mq-lcdif > > + oneOf: > > + - enum: > > + - fsl,imx23-lcdif > > + - fsl,imx28-lcdif > > + - fsl,imx6sx-lcdif > > Indent correct. > > > + - items: > > + - enum: > > + - fsl,imx6sl-lcdif > > + - fsl,imx6sll-lcdif > > + - fsl,imx6ul-lcdif > > + - fsl,imx7d-lcdif > > + - fsl,imx8mq-lcdif > > Indent shall be two more spaces like above. > (This is at least my best uderstanding) I think you're right. I wonder why dt_binding_check doesn't complain. I'll fix it anyway. > > + - const: fsl,imx6sx-lcdif > > With the above the following compatibles are supported: > > "fsl,imx23-lcdif" > "fsl,imx28-lcdif" > "fsl,imx6sx-lcdif" > "fsl,imx8mq-lcdif" > > "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif" > "fsl,imx6sll-lcdif", "fsl,imx6sx-lcdif" > "fsl,imx6ul-lcdif", "fsl,imx6sx-lcdif" > "fsl,imx7d-lcdif", "fsl,imx6sx-lcdif" > "fsl,imx8mq-lcdif", "fsl,imx6sx-lcdif" > > So the fallback value is the later "fsl,imx6sx-lcdif" which looks ok. > > With indent fixed (or explained why I am wrong): > Reviewed-by: Sam Ravnborg > > > > > reg: > > maxItems: 1 -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel