From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7936C433DF for ; Wed, 19 Aug 2020 12:05:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59E5D205CB for ; Wed, 19 Aug 2020 12:05:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="STwBa1M4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IHH9++nB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59E5D205CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ebi7pp43gXiBQ62dXL+9EqW+GOVoImnr6tS+64WMyYE=; b=STwBa1M4Jkirih0vf0RV8Bemc lDTp1lVAa+JmCtQMAl8qZt5vQNYLn4YEFQxTKtFK/WK5dUUc0YCjT9S+q5U6JXLMPqnMRwBgviPvi MA2gE0qi9MeZbhKMtmWzvb/PMLaiB+s2jjM1d+AiWnSktWSTdE52pVwoJ/Opeg6p+/RLlkq40EyOE u/1zynm/I82lDtvic++k8cqTYxWTtUBOckINmMhavyX+0382A4o0LVB1wFq2ZZ2ULt2tLbw0LPDxo bUJwnXxRBSgHbtbs1n3VCnXTNmMT39PgwuPt2SNsKCouRJOdQuhXX4TTKMe+l5qNgaCkkDNqvw45V oAYkjR85Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8Moh-0000qJ-Tf; Wed, 19 Aug 2020 12:03:43 +0000 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120] helo=us-smtp-1.mimecast.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8Moe-0000p7-Cd for linux-arm-kernel@lists.infradead.org; Wed, 19 Aug 2020 12:03:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597838619; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m9+0bAxLuUQbDhStzV9Q7LQwgzKpdo+DUCTWFOEtQPc=; b=IHH9++nBhApZGCnjGMghkh9VtW+hfQGXgCH4wCn9SftC9XYfooUQhbg6rONQRHcpRGAkl1 8TAyQNJS76Xmcnlvv+oJaCtUzU4M8Zcgi4SZbj83mI8W3DhRjRRRjhFHQPwYaWv34Gtt17 ayUNVR0oALNs88t2vroX84wXI7YWQBw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-569-9z5gyIZuP6iSl37NVFxRVQ-1; Wed, 19 Aug 2020 08:03:16 -0400 X-MC-Unique: 9z5gyIZuP6iSl37NVFxRVQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E754A801AE5; Wed, 19 Aug 2020 12:03:12 +0000 (UTC) Received: from dhcp-128-65.nay.redhat.com (ovpn-13-194.pek2.redhat.com [10.72.13.194]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D5C947A421; Wed, 19 Aug 2020 12:03:04 +0000 (UTC) Date: Wed, 19 Aug 2020 20:03:01 +0800 From: Dave Young To: chenzhou Subject: Re: [PATCH v11 5/5] kdump: update Documentation about crashkernel Message-ID: <20200819120301.GA13727@dhcp-128-65.nay.redhat.com> References: <20200801130856.86625-1-chenzhou10@huawei.com> <20200801130856.86625-6-chenzhou10@huawei.com> <20200808100239.GB60590@dhcp-128-65.nay.redhat.com> <96d0da23-d484-7f66-1680-07b4b5984831@huawei.com> <20200810060355.GB6988@dhcp-128-65.nay.redhat.com> <2e6aebf9-3765-5d8c-933c-698442db1d52@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2e6aebf9-3765-5d8c-933c-698442db1d52@huawei.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200819_080340_456590_6851787F X-CRM114-Status: GOOD ( 23.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wangkefeng.wang@huawei.com, linux-doc@vger.kernel.org, catalin.marinas@arm.com, bhsharma@redhat.com, huawei.libin@huawei.com, guohanjun@huawei.com, will@kernel.org, bhe@redhat.com, corbet@lwn.net, mingo@redhat.com, John.P.donnelly@oracle.com, arnd@arndb.de, xiexiuqi@huawei.com, horms@verge.net.au, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, james.morse@arm.com, prabhakar.pkin@gmail.com, nsaenzjulienne@suse.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/18/20 at 03:07pm, chenzhou wrote: > > > On 2020/8/10 14:03, Dave Young wrote: > > Hi, > > > >>> Previously I remember we talked about to use similar logic as X86, but I > >>> remember you mentioned on some arm64 platform there could be no low > >>> memory at all. Is this not a problem now for the fallback? Just be > >>> curious, thanks for the update, for the common part looks good. > >> Hi Dave, > >> > >> Did you mean this discuss: https://lkml.org/lkml/2019/12/27/122? > > I meant about this reply instead :) > > https://lkml.org/lkml/2020/1/16/616 > Hi Dave, > > Sorry for not repley in time, I was on holiday last week. Hi, no problem, thanks for following up. > > The platform James mentioned may exist for which have no devices and need no low memory. > For our arm64 server platform, there are some devices and need low memory. > > I got it. For the platform with no low memory, reserving crashkernel will always fail. > How about like this: I think the question should leave to Catalin or James, I have no suggestion about this:) > > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c > index a8e34d97a894..4df18c7ea438 100644 > --- a/arch/arm64/mm/init.c > +++ b/arch/arm64/mm/init.c > @@ -147,7 +147,7 @@ static void __init reserve_crashkernel(void) > } > memblock_reserve(crash_base, crash_size); > > - if (crash_base >= CRASH_ADDR_LOW_MAX) { > + if (memstart_addr < CRASH_ADDR_LOW_MAX && crash_base >= CRASH_ADDR_LOW_MAX) { > const char *rename = "Crash kernel (low)"; > > if (reserve_crashkernel_low()) { > > > Thanks, > Chen Zhou > > > > > Thanks > > Dave > > > > > > . > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel