From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D93DC433DF for ; Fri, 21 Aug 2020 16:04:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47AE6207BB for ; Fri, 21 Aug 2020 16:04:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uNgiN867"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="rUqMkCwq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47AE6207BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jg/uL3qJxdxeUegf/Wm/sGiwMowomKPUlaK8fWDUlhg=; b=uNgiN8677kMr92em0oxV1mPnZ vLohGodXbUhFelmvQr3cuZgnLDkUrHcngF1amAJztKn4m4DHLf2Yg79FRfQrPEAZQdBiNzYfBO5oh i9ZVHnz++ZwnEZCjDAtS8E2e/5hvnYUBKh4QGcBumUWGYlSzjAceq6CSa85WrdjHynZ0SmFDc+C6G RF7rw4GDO/6KW9IzLB/kXUxHuz6uiAm9o7JjI89jfjfbYswWWRdRUpSAMK1vO7eFAsV5hBjSsu1wi VeXEfr7LaHOM/N5ASPJrARyIABGgLCm8cv60OpAHemk8PuYn7XE2sITAaEtepgqFozNGF0TuKSCz0 DdJN8KbAA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k99Vn-000850-NT; Fri, 21 Aug 2020 16:03:27 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k99Vj-00083O-9s for linux-arm-kernel@lists.infradead.org; Fri, 21 Aug 2020 16:03:24 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 925FE207BB; Fri, 21 Aug 2020 16:03:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598025802; bh=s7k7WVoMuW3YOq62B9s+ZiSRUJCQ9bWnTQTRHx+L47U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rUqMkCwqrjDQLVFDCML+UPPcErgSGgrMWu/c98cem9NQGN6T+mOGaXb0ioOHagXdG 5y0iD5+V2N72brnN7NCXB43WQZhiDtmc9Me9xJT3z6dHpaKZXFDH8Y0r3F3qw/daXe xtT46gOoAtOT09c9Q1JHr9geLPFmMtNd8KKu0lt0= Date: Fri, 21 Aug 2020 17:03:16 +0100 From: Will Deacon To: Greg KH Subject: Re: [PATCH stable v4.9 v2] arm64: entry: Place an SB sequence following an ERET instruction Message-ID: <20200821160316.GE21517@willie-the-truck> References: <20200709195034.15185-1-f.fainelli@gmail.com> <20200720130411.GB494210@kroah.com> <9c29080e-8b3a-571c-3296-e0487fa473fa@gmail.com> <20200807131429.GB664450@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200807131429.GB664450@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200821_120323_505715_6BB5579A X-CRM114-Status: GOOD ( 22.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nick Desaulniers , Andrew Jones , Florian Fainelli , Fangrui Song , Suzuki K Poulose , Catalin Marinas , Will Deacon , open list , stable@vger.kernel.org, "open list:KERNEL VIRTUAL MACHINE FOR ARM64 \(KVM/arm64\)" , Mark Brown , James Morse , Julien Thierry , Sami Tolvanen , Marc Zyngier , Kristina Martsenko , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 07, 2020 at 03:14:29PM +0200, Greg KH wrote: > On Thu, Aug 06, 2020 at 01:00:54PM -0700, Florian Fainelli wrote: > > > > > > On 7/20/2020 11:26 AM, Florian Fainelli wrote: > > > On 7/20/20 6:04 AM, Greg KH wrote: > > >> On Thu, Jul 09, 2020 at 12:50:23PM -0700, Florian Fainelli wrote: > > >>> From: Will Deacon > > >>> > > >>> commit 679db70801da9fda91d26caf13bf5b5ccc74e8e8 upstream > > >>> > > >>> Some CPUs can speculate past an ERET instruction and potentially perform > > >>> speculative accesses to memory before processing the exception return. > > >>> Since the register state is often controlled by a lower privilege level > > >>> at the point of an ERET, this could potentially be used as part of a > > >>> side-channel attack. > > >>> > > >>> This patch emits an SB sequence after each ERET so that speculation is > > >>> held up on exception return. > > >>> > > >>> Signed-off-by: Will Deacon > > >>> [florian: Adjust hyp-entry.S to account for the label > > >>> added change to hyp/entry.S] > > >>> Signed-off-by: Florian Fainelli > > >>> --- > > >>> Changes in v2: > > >>> > > >>> - added missing hunk in hyp/entry.S per Will's feedback > > >> > > >> What about 4.19.y and 4.14.y trees? I can't take something for 4.9.y > > >> and then have a regression if someone moves to a newer release, right? > > > > > > Sure, send you candidates for 4.14 and 4.19. > > > > Greg, did you have a chance to queue those changes for 4.9, 4.14 and 4.19? > > > > https://lore.kernel.org/linux-arm-kernel/20200720182538.13304-1-f.fainelli@gmail.com/ > > https://lore.kernel.org/linux-arm-kernel/20200720182937.14099-1-f.fainelli@gmail.com/ > > https://lore.kernel.org/linux-arm-kernel/20200709195034.15185-1-f.fainelli@gmail.com/ > > Nope, I was waiting for Will's "ack" for these. This patch doesn't even build for me (the 'sb' macro is not defined in 4.9), and I really wonder why we bother backporting it at all. Nobody's ever shown it to be a problem in practice, and it's clear that this is just being submitted to tick a box rather than anything else (otherwise it would build, right?). So I'm not going to Ack any of them. As with a lot of this side-channel stuff the cure is far worse than the disease. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel