From: Linus Walleij <linus.walleij@linaro.org>
To: Sekhar Nori <nsekhar@ti.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: davinci: dm646x: Convert LEDs to GPIO descriptor table
Date: Wed, 26 Aug 2020 16:31:29 +0200 [thread overview]
Message-ID: <20200826143129.123837-1-linus.walleij@linaro.org> (raw)
This converts the DaVinci DM646x LEDs to use GPIO
descriptor look-ups.
Cc: Sekhar Nori <nsekhar@ti.com>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ChangeLog v1->v2:
- Collect Bartosz' review tag
- Rebase on v5.9-rc1
- Resend
---
arch/arm/mach-davinci/board-dm646x-evm.c | 33 +++++++++++++++++-------
1 file changed, 24 insertions(+), 9 deletions(-)
diff --git a/arch/arm/mach-davinci/board-dm646x-evm.c b/arch/arm/mach-davinci/board-dm646x-evm.c
index dd7d60f4139a..1395352723b0 100644
--- a/arch/arm/mach-davinci/board-dm646x-evm.c
+++ b/arch/arm/mach-davinci/board-dm646x-evm.c
@@ -20,6 +20,7 @@
#include <linux/init.h>
#include <linux/leds.h>
#include <linux/gpio.h>
+#include <linux/gpio/machine.h>
#include <linux/platform_device.h>
#include <linux/i2c.h>
#include <linux/property.h>
@@ -203,10 +204,10 @@ static struct i2c_driver dm6467evm_cpld_driver = {
/* LEDS */
static struct gpio_led evm_leds[] = {
- { .name = "DS1", .active_low = 1, },
- { .name = "DS2", .active_low = 1, },
- { .name = "DS3", .active_low = 1, },
- { .name = "DS4", .active_low = 1, },
+ { .name = "DS1" },
+ { .name = "DS2" },
+ { .name = "DS3" },
+ { .name = "DS4" },
};
static const struct gpio_led_platform_data evm_led_data = {
@@ -214,18 +215,32 @@ static const struct gpio_led_platform_data evm_led_data = {
.leds = evm_leds,
};
+static struct gpiod_lookup_table evm_leds_gpio_table = {
+ .dev_id = "leds-gpio.0",
+ .table = {
+ /*
+ * These GPIOs are on a PCF8574a GPIO expander, which
+ * is in turn named after the I2C device name. This is
+ * device "u2" on I2C bus 1 with address 0x38. These
+ * leds are at offset 4, 5, 6, 7.
+ */
+ GPIO_LOOKUP_IDX("1-0038", 4, NULL, 0, GPIO_ACTIVE_LOW),
+ GPIO_LOOKUP_IDX("1-0038", 5, NULL, 1, GPIO_ACTIVE_LOW),
+ GPIO_LOOKUP_IDX("1-0038", 6, NULL, 2, GPIO_ACTIVE_LOW),
+ GPIO_LOOKUP_IDX("1-0038", 7, NULL, 3, GPIO_ACTIVE_LOW),
+ { },
+ },
+};
+
static struct platform_device *evm_led_dev;
static int evm_led_setup(struct i2c_client *client, int gpio,
unsigned int ngpio, void *c)
{
- struct gpio_led *leds = evm_leds;
int status;
- while (ngpio--) {
- leds->gpio = gpio++;
- leds++;
- }
+ /* Add the lookup table */
+ gpiod_add_lookup_table(&evm_leds_gpio_table);
evm_led_dev = platform_device_alloc("leds-gpio", 0);
platform_device_add_data(evm_led_dev, &evm_led_data,
--
2.26.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2020-08-26 14:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 14:31 Linus Walleij [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-07-27 7:13 [PATCH] ARM: davinci: dm646x: Convert LEDs to GPIO descriptor table Linus Walleij
2020-08-03 19:48 ` Bartosz Golaszewski
2020-09-03 6:21 ` Sekhar Nori
2020-09-03 6:23 ` Sekhar Nori
2020-09-03 19:49 ` Linus Walleij
2020-09-08 4:18 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826143129.123837-1-linus.walleij@linaro.org \
--to=linus.walleij@linaro.org \
--cc=bgolaszewski@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).